Title: Use on_load module attribute by NelsonVides · Pull Request #14 · processone/stringprep · GitHub
Open Graph Title: Use on_load module attribute by NelsonVides · Pull Request #14 · processone/stringprep
X Title: Use on_load module attribute by NelsonVides · Pull Request #14 · processone/stringprep
Description: Before OTP 19.0, if the on_load directive fails, any previously loaded code would become old, essentially leaving the system without any working and reachable instance of the module. This is not true anymore since OTP 19.0, so loading the nifs within the on_load directive is today the cleanest and best code pattern. It seems indeed very convoluted to have an entire application and supervision tree with a worker gen_server just to load the nifs. Also, one of the handle_info heads of the gen_server is even a remnant of the times when fast_tls was implemented as a port driver instead of as nifs, which is a high sign this needed some modernisation. I contributed a similar work for fast_tls a long time ago here: processone/fast_tls#43
Open Graph Description: Before OTP 19.0, if the on_load directive fails, any previously loaded code would become old, essentially leaving the system without any working and reachable instance of the module. This is not tr...
X Description: Before OTP 19.0, if the on_load directive fails, any previously loaded code would become old, essentially leaving the system without any working and reachable instance of the module. This is not tr...
Opengraph URL: https://github.com/processone/stringprep/pull/14
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:dcd855e5-e11f-14b3-d0e8-6bc848438db5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C5BA:34202A:32BEBF:401B67:697DCE7B |
| html-safe-nonce | 3f2f76ca93ca8d51439532c8a3c692761228e65fb80f85f7478b28e178e2a1d0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUJBOjM0MjAyQTozMkJFQkY6NDAxQjY3OjY5N0RDRTdCIiwidmlzaXRvcl9pZCI6IjU2NzQ5NDQwOTk2MTA2NDQwOTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f6980d74c46c07acca53ea830db4b9651da1474afd36692bc9b99986f49063dd |
| hovercard-subject-tag | pull_request:2330679639 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/processone/stringprep/pull/14/files |
| twitter:image | https://avatars.githubusercontent.com/u/27267603?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/27267603?s=400&v=4 |
| og:image:alt | Before OTP 19.0, if the on_load directive fails, any previously loaded code would become old, essentially leaving the system without any working and reachable instance of the module. This is not tr... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/processone/stringprep git https://github.com/processone/stringprep.git |
| octolytics-dimension-user_id | 86724 |
| octolytics-dimension-user_login | processone |
| octolytics-dimension-repository_id | 9217565 |
| octolytics-dimension-repository_nwo | processone/stringprep |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 9217565 |
| octolytics-dimension-repository_network_root_nwo | processone/stringprep |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7c85641c598ad130c74f7bcc27f58575cac69551 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width