René's URL Explorer Experiment


Title: Refactor to exceptions by emhoracek · Pull Request #31 · positiondev/offset · GitHub

Open Graph Title: Refactor to exceptions by emhoracek · Pull Request #31 · positiondev/offset

X Title: Refactor to exceptions by emhoracek · Pull Request #31 · positiondev/offset

Description: Tests currently pass, but still some work to do. Would appreciate comments, suggestions. It seems like I ought to be able to pull out the "log and comment" parts of the exception handling into a fu...

Open Graph Description: Tests currently pass, but still some work to do. Would appreciate comments, suggestions. It seems like I ought to be able to pull out the "log and comment" parts of the exception handling...

X Description: Tests currently pass, but still some work to do. Would appreciate comments, suggestions. It seems like I ought to be able to pull out the "log and comment" parts of the exception ...

Opengraph URL: https://github.com/positiondev/offset/pull/31

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b25f5782-96fe-e9e8-152e-7228a175340d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF2C:2F7640:71765:9C69D:698F3D08
html-safe-nonce8df3ee9ec7ec7c73eec9097a3e943fed268e02a14cf21048e5898d11c4648586
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjJDOjJGNzY0MDo3MTc2NTo5QzY5RDo2OThGM0QwOCIsInZpc2l0b3JfaWQiOiI2MDM0MTYwODA0OTMyNjQxMzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac25d3e677349d8d9fe9e88254d94fb5f54aaa1ce64bcec95a74a970d11c10328c
hovercard-subject-tagpull_request:102920912
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/positiondev/offset/31/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/47a2ab7bd950733d24cfba5c525fd77cef9c338989bade0a811c19a6de3335d0/positiondev/offset/pull/31
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/47a2ab7bd950733d24cfba5c525fd77cef9c338989bade0a811c19a6de3335d0/positiondev/offset/pull/31
og:image:altTests currently pass, but still some work to do. Would appreciate comments, suggestions. It seems like I ought to be able to pull out the "log and comment" parts of the exception handling...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameemhoracek
hostnamegithub.com
expected-hostnamegithub.com
None6102991c714c1a6a27d05fb4f96ea6ca87a6750b4f093b95cc57ed1b84b145a1
turbo-cache-controlno-preview
go-importgithub.com/positiondev/offset git https://github.com/positiondev/offset.git
octolytics-dimension-user_id9354495
octolytics-dimension-user_loginpositiondev
octolytics-dimension-repository_id23900044
octolytics-dimension-repository_nwopositiondev/offset
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id23900044
octolytics-dimension-repository_network_root_nwopositiondev/offset
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released6ba6f2bfbf6399a7c07495a912727369e95bfe8
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpositiondev%2Foffset%2Fpull%2F31
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpositiondev%2Foffset%2Fpull%2F31
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=positiondev%2Foffset
Reloadhttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31
Reloadhttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31
Reloadhttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31
positiondev https://patch-diff.githubusercontent.com/positiondev
offsethttps://patch-diff.githubusercontent.com/positiondev/offset
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fpositiondev%2Foffset
Fork 3 https://patch-diff.githubusercontent.com/login?return_to=%2Fpositiondev%2Foffset
Star 3 https://patch-diff.githubusercontent.com/login?return_to=%2Fpositiondev%2Foffset
Code https://patch-diff.githubusercontent.com/positiondev/offset
Issues 8 https://patch-diff.githubusercontent.com/positiondev/offset/issues
Pull requests 5 https://patch-diff.githubusercontent.com/positiondev/offset/pulls
Actions https://patch-diff.githubusercontent.com/positiondev/offset/actions
Projects 0 https://patch-diff.githubusercontent.com/positiondev/offset/projects
Wiki https://patch-diff.githubusercontent.com/positiondev/offset/wiki
Security 0 https://patch-diff.githubusercontent.com/positiondev/offset/security
Insights https://patch-diff.githubusercontent.com/positiondev/offset/pulse
Code https://patch-diff.githubusercontent.com/positiondev/offset
Issues https://patch-diff.githubusercontent.com/positiondev/offset/issues
Pull requests https://patch-diff.githubusercontent.com/positiondev/offset/pulls
Actions https://patch-diff.githubusercontent.com/positiondev/offset/actions
Projects https://patch-diff.githubusercontent.com/positiondev/offset/projects
Wiki https://patch-diff.githubusercontent.com/positiondev/offset/wiki
Security https://patch-diff.githubusercontent.com/positiondev/offset/security
Insights https://patch-diff.githubusercontent.com/positiondev/offset/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fpositiondev%2Foffset%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fpositiondev%2Foffset%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31#issue-comment-box
emhoracekhttps://patch-diff.githubusercontent.com/emhoracek
masterhttps://patch-diff.githubusercontent.com/positiondev/offset/tree/master
refactor-to-exceptionshttps://patch-diff.githubusercontent.com/positiondev/offset/tree/refactor-to-exceptions
Refactor to exceptions https://patch-diff.githubusercontent.com/positiondev/offset/pull/31#top
emhoracekhttps://patch-diff.githubusercontent.com/emhoracek
masterhttps://patch-diff.githubusercontent.com/positiondev/offset/tree/master
refactor-to-exceptionshttps://patch-diff.githubusercontent.com/positiondev/offset/tree/refactor-to-exceptions
Conversation 5 https://patch-diff.githubusercontent.com/positiondev/offset/pull/31
Commits 4 https://patch-diff.githubusercontent.com/positiondev/offset/pull/31/commits
Checks 0 https://patch-diff.githubusercontent.com/positiondev/offset/pull/31/checks
Files changed https://patch-diff.githubusercontent.com/positiondev/offset/pull/31/files
Please reload this pagehttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/positiondev/offset/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/emhoracek
emhoracekhttps://patch-diff.githubusercontent.com/emhoracek
Jan 24, 2017https://patch-diff.githubusercontent.com/positiondev/offset/pull/31#issue-202822229
Please reload this pagehttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31
Please reload this pagehttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31
emhoracekhttps://patch-diff.githubusercontent.com/emhoracek
January 24, 2017 08:18https://patch-diff.githubusercontent.com/positiondev/offset/pull/31#commits-pushed-6ef8e45
https://patch-diff.githubusercontent.com/emhoracek
Refactor to use exceptionshttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31/commits/6ef8e45dbf0817bf362d032fe45b031aaaf4cad8
6ef8e45https://patch-diff.githubusercontent.com/positiondev/offset/pull/31/commits/6ef8e45dbf0817bf362d032fe45b031aaaf4cad8
https://patch-diff.githubusercontent.com/emhoracek
Handle SomeExceptionshttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31/commits/4e7e0edb7ca520aaa0b17054fdaa0f5f103b2b8b
4e7e0edhttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31/commits/4e7e0edb7ca520aaa0b17054fdaa0f5f103b2b8b
https://patch-diff.githubusercontent.com/emhoracek
Let wreq throw errorshttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31/commits/32462e3895f17dd195cbcc9b7a89f6b2d180b9f4
32462e3https://patch-diff.githubusercontent.com/positiondev/offset/pull/31/commits/32462e3895f17dd195cbcc9b7a89f6b2d180b9f4
https://patch-diff.githubusercontent.com/emhoracek
improve tests, add logging temporarilyhttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31/commits/62e38f22031c5873dc131dae7fdb9de590204348
62e38f2https://patch-diff.githubusercontent.com/positiondev/offset/pull/31/commits/62e38f22031c5873dc131dae7fdb9de590204348
https://patch-diff.githubusercontent.com/emhoracek
emhoracekhttps://patch-diff.githubusercontent.com/emhoracek
Jan 24, 2017 https://patch-diff.githubusercontent.com/positiondev/offset/pull/31#pullrequestreview-18160443
View reviewed changes https://patch-diff.githubusercontent.com/positiondev/offset/pull/31/files/62e38f22031c5873dc131dae7fdb9de590204348
spec/Main.hshttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31/files/62e38f22031c5873dc131dae7fdb9de590204348#diff-d7661558a6c1e4f9b3d05832ad465b687362d9be7e7bae81e821c3c6364d1aef
emhoracekhttps://patch-diff.githubusercontent.com/emhoracek
Jan 24, 2017https://patch-diff.githubusercontent.com/positiondev/offset/pull/31#discussion_r97548496
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31
https://patch-diff.githubusercontent.com/emhoracek
emhoracekhttps://patch-diff.githubusercontent.com/emhoracek
Jan 24, 2017 https://patch-diff.githubusercontent.com/positiondev/offset/pull/31#pullrequestreview-18160790
View reviewed changes https://patch-diff.githubusercontent.com/positiondev/offset/pull/31/files/62e38f22031c5873dc131dae7fdb9de590204348
spec/Main.hshttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31/files/62e38f22031c5873dc131dae7fdb9de590204348#diff-d7661558a6c1e4f9b3d05832ad465b687362d9be7e7bae81e821c3c6364d1aef
emhoracekhttps://patch-diff.githubusercontent.com/emhoracek
Jan 24, 2017https://patch-diff.githubusercontent.com/positiondev/offset/pull/31#discussion_r97548816
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31
https://patch-diff.githubusercontent.com/emhoracek
emhoracekhttps://patch-diff.githubusercontent.com/emhoracek
Jan 24, 2017 https://patch-diff.githubusercontent.com/positiondev/offset/pull/31#pullrequestreview-18160941
View reviewed changes https://patch-diff.githubusercontent.com/positiondev/offset/pull/31/files/62e38f22031c5873dc131dae7fdb9de590204348
src/Web/Offset/Cache.hshttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31/files/62e38f22031c5873dc131dae7fdb9de590204348#diff-9f259f9647c5d8d91f3b8fc5de4fc83bbe06e46e68725873cae68ccd48426f38
emhoracekhttps://patch-diff.githubusercontent.com/emhoracek
Jan 24, 2017https://patch-diff.githubusercontent.com/positiondev/offset/pull/31#discussion_r97548973
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31
patrickthttps://patch-diff.githubusercontent.com/patrickt
Jan 24, 2017https://patch-diff.githubusercontent.com/positiondev/offset/pull/31#discussion_r97552363
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31
https://patch-diff.githubusercontent.com/emhoracek
emhoracekhttps://patch-diff.githubusercontent.com/emhoracek
Jan 24, 2017 https://patch-diff.githubusercontent.com/positiondev/offset/pull/31#pullrequestreview-18162243
View reviewed changes https://patch-diff.githubusercontent.com/positiondev/offset/pull/31/files/62e38f22031c5873dc131dae7fdb9de590204348
src/Web/Offset/Cache.hshttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31/files/62e38f22031c5873dc131dae7fdb9de590204348#diff-9f259f9647c5d8d91f3b8fc5de4fc83bbe06e46e68725873cae68ccd48426f38
emhoracekhttps://patch-diff.githubusercontent.com/emhoracek
Jan 24, 2017https://patch-diff.githubusercontent.com/positiondev/offset/pull/31#discussion_r97550301
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31
https://patch-diff.githubusercontent.com/emhoracek
emhoracekhttps://patch-diff.githubusercontent.com/emhoracek
dhartunianhttps://patch-diff.githubusercontent.com/dhartunian
mattraiberthttps://patch-diff.githubusercontent.com/mattraibert
January 24, 2017 13:59https://patch-diff.githubusercontent.com/positiondev/offset/pull/31#event-934521058
https://patch-diff.githubusercontent.com/mattraibert
mattraiberthttps://patch-diff.githubusercontent.com/mattraibert
dhartunianhttps://patch-diff.githubusercontent.com/dhartunian
mattraiberthttps://patch-diff.githubusercontent.com/mattraibert
May 4, 2022 14:42https://patch-diff.githubusercontent.com/positiondev/offset/pull/31#event-6549124623
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpositiondev%2Foffset%2Fpull%2F31
https://patch-diff.githubusercontent.com/patrickt
patrickt https://patch-diff.githubusercontent.com/patrickt
https://patch-diff.githubusercontent.com/positiondev/offset/pull/31/files/62e38f22031c5873dc131dae7fdb9de590204348
Please reload this pagehttps://patch-diff.githubusercontent.com/positiondev/offset/pull/31
https://patch-diff.githubusercontent.com/emhoracek
https://patch-diff.githubusercontent.com/patrickt
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.