Title: [wip] in-ns form by thomasmulvaney · Pull Request #506 · pixie-lang/pixie · GitHub
Open Graph Title: [wip] in-ns form by thomasmulvaney · Pull Request #506 · pixie-lang/pixie
X Title: [wip] in-ns form by thomasmulvaney · Pull Request #506 · pixie-lang/pixie
Description: This is an attempt to address #366 This makes in-ns just a regular function. Things seem to mostly just work, but i had to change some of the tests slightly. I think most of the issues were probably to with the deftest macro. For example the defprotocol inside a test broke unless i put a (in-ns ...) before it. Also I had to wrap some code in eval so it would end up in the foo namespace and not in the pixie.test.test-stdlib namespace. Ideally we shouldn't have to make the changes I made to the tests. Any thoughts? Cheers.
Open Graph Description: This is an attempt to address #366 This makes in-ns just a regular function. Things seem to mostly just work, but i had to change some of the tests slightly. I think most of the issues were probab...
X Description: This is an attempt to address #366 This makes in-ns just a regular function. Things seem to mostly just work, but i had to change some of the tests slightly. I think most of the issues were probab...
Opengraph URL: https://github.com/pixie-lang/pixie/pull/506
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:e4ff0944-7297-087e-6f35-02c2aeef9247 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 89BC:25408:2ACC665:38BB3D6:6992E5C8 |
| html-safe-nonce | 499d69545f13d6fff4a775d4c4b53befd12702c9edb603f256cb9bb477befcc0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUJDOjI1NDA4OjJBQ0M2NjU6MzhCQjNENjo2OTkyRTVDOCIsInZpc2l0b3JfaWQiOiI4NTkzODcyNjc5MzQ5NzA4MjMyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ace05ef94e7edba74d17331b7cff15f48e8366b9ea764bd1b7c580ef7d02e846 |
| hovercard-subject-tag | pull_request:61843753 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/pixie-lang/pixie/pull/506/checks |
| twitter:image | https://avatars.githubusercontent.com/u/6378932?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/6378932?s=400&v=4 |
| og:image:alt | This is an attempt to address #366 This makes in-ns just a regular function. Things seem to mostly just work, but i had to change some of the tests slightly. I think most of the issues were probab... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| go-import | github.com/pixie-lang/pixie git https://github.com/pixie-lang/pixie.git |
| octolytics-dimension-user_id | 8930965 |
| octolytics-dimension-user_login | pixie-lang |
| octolytics-dimension-repository_id | 24507006 |
| octolytics-dimension-repository_nwo | pixie-lang/pixie |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24507006 |
| octolytics-dimension-repository_network_root_nwo | pixie-lang/pixie |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84dcb133269e3cfe6e0296cc85fbacb92cae92bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width