René's URL Explorer Experiment


Title: Fix #592 - desc index by predictor2718 · Pull Request #636 · phpmyadmin/sql-parser · GitHub

Open Graph Title: Fix #592 - desc index by predictor2718 · Pull Request #636 · phpmyadmin/sql-parser

X Title: Fix #592 - desc index by predictor2718 · Pull Request #636 · phpmyadmin/sql-parser

Description: Description This PR fixes incorrect parsing of DESC inside index definitions in ALTER TABLE statements. Example: ALTER TABLE `t` ADD UNIQUE KEY `idx` (`a`, `b` DESC); This change updates AlterOperation::parse() so that ASC and DESC are not interpreted as new statements within index definitions. Fixes #592.

Open Graph Description: Description This PR fixes incorrect parsing of DESC inside index definitions in ALTER TABLE statements. Example: ALTER TABLE `t` ADD UNIQUE KEY `idx` (`a`, `b` DESC); This change updates AlterOpe...

X Description: Description This PR fixes incorrect parsing of DESC inside index definitions in ALTER TABLE statements. Example: ALTER TABLE `t` ADD UNIQUE KEY `idx` (`a`, `b` DESC); This change updates AlterOpe...

Opengraph URL: https://github.com/phpmyadmin/sql-parser/pull/636

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:284294f3-06c2-f40a-54cf-1758cbf97d98
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E3C:4DF1B:1D7A71A:26EC433:696D778B
html-safe-nonce9c695789a8dcee69835174ce77e0f5743a0c98f3badce30c07a18fd085cedfd0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTNDOjRERjFCOjFEN0E3MUE6MjZFQzQzMzo2OTZENzc4QiIsInZpc2l0b3JfaWQiOiIzMTE1NDI2MDU0MDEyNzYxOTk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacadf553e6be92ffbca68bf9982daddf5ddbda6b9dde9e5c338538ef974a41ed22
hovercard-subject-tagpull_request:3041712788
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/phpmyadmin/sql-parser/pull/636/files
twitter:imagehttps://avatars.githubusercontent.com/u/245527909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/245527909?s=400&v=4
og:image:altDescription This PR fixes incorrect parsing of DESC inside index definitions in ALTER TABLE statements. Example: ALTER TABLE `t` ADD UNIQUE KEY `idx` (`a`, `b` DESC); This change updates AlterOpe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4922b452d03cd8dbce479d866a11bc25b59ef6ee2da23aa9b0ddefa6bd4d0064
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/phpmyadmin/sql-parser git https://github.com/phpmyadmin/sql-parser.git
octolytics-dimension-user_id1351977
octolytics-dimension-user_loginphpmyadmin
octolytics-dimension-repository_id36256604
octolytics-dimension-repository_nwophpmyadmin/sql-parser
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36256604
octolytics-dimension-repository_network_root_nwophpmyadmin/sql-parser
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7e5ae23c70136152637ceee8d6faceb35596ec46
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpmyadmin%2Fsql-parser%2Fpull%2F636%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpmyadmin%2Fsql-parser%2Fpull%2F636%2Ffiles
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=phpmyadmin%2Fsql-parser
Reloadhttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files
Reloadhttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files
Reloadhttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files
phpmyadmin https://patch-diff.githubusercontent.com/phpmyadmin
sql-parserhttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser
Please reload this pagehttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fphpmyadmin%2Fsql-parser
Fork 110 https://patch-diff.githubusercontent.com/login?return_to=%2Fphpmyadmin%2Fsql-parser
Star 472 https://patch-diff.githubusercontent.com/login?return_to=%2Fphpmyadmin%2Fsql-parser
Code https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser
Issues 50 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/issues
Pull requests 5 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pulls
Actions https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/actions
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/security
Please reload this pagehttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files
Insights https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pulse
Code https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser
Issues https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/issues
Pull requests https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pulls
Actions https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/actions
Security https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/security
Insights https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fphpmyadmin%2Fsql-parser%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fphpmyadmin%2Fsql-parser%2Fissues%2Fnew%2Fchoose
predictor2718https://patch-diff.githubusercontent.com/predictor2718
phpmyadmin:6.0.xhttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/tree/6.0.x
predictor2718:fix-592-desc-indexhttps://patch-diff.githubusercontent.com/predictor2718/sql-parser/tree/fix-592-desc-index
Conversation 4 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636
Commits 5 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits
Checks 0 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/checks
Files changed https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files
Please reload this pagehttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files
Fix #592 - desc index https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#top
Show all changes 5 commits https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files
54b5586 Fix ALTER index parsing: DESC should not begin a new statement (#592) predictor2718 Nov 24, 2025 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/54b5586414ce43c24c4fadef3c638264d471f6bd
bc4e5e9 Add test for DESC index (#592) predictor2718 Nov 24, 2025 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/bc4e5e9214b0ba72d1bab33a6c656601e095bc74
5b35ae7 Fix too long line - phpcs linting hint (#592) predictor2718 Nov 26, 2025 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/5b35ae747e037d01d1b21e343fb4e39fb612c76d
eac040f Add tests for ASC and lowercase keyword (#592) predictor2718 Nov 26, 2025 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/eac040f8f91f2eefa48c60acab2978102901eac0
3c2e0be #592 link test files and add asc-desc index tests predictor2718 Jan 3, 2026 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/3c2e0be7918ace8814b1b08a94b6120a26787585
Clear filters https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files
Please reload this pagehttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files
Please reload this pagehttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files
AlterOperations.php https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-3e6ea00045acfa8ceb9655104da93b6f84013ce9c911615033a4f17962104872
AlterStatementTest.php https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-28d0e0a508ed8d5736042f2a90ee313e08cce9ce206d24a6bfc0ae09dba3e9e4
parseAlterTableAddUniqueKeyAsc.in https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-e06cdcbb53e80b763a548d0242d5d61abe7b1ad5df093fd720cf29f1c6e2e80a
parseAlterTableAddUniqueKeyAsc.out https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-99e36ebea164be085f570db760d9f293cf4ca725c3919c1309a1451cf81c0f43
parseAlterTableAddUniqueKeyAscDesc.in https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-cd274c5f60ac500c6edaf18c6e6d72adfb9bd86b06b256de1a4bfc71cc229e19
parseAlterTableAddUniqueKeyAscDesc.out https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-db29334ae5378bb16f538d972afacc48bdb85c059529abc68f1eb33f957e8bdb
parseAlterTableAddUniqueKeyAscLower.in https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-c32d2dbab43b61b3930c7ad4a212806c0452f81923f87d6e0f22e36ff5fe8431
parseAlterTableAddUniqueKeyAscLower.out https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-ffe809887dfc1aacfda2034306cc52bedb5ab3799cd49a1b06c69731e5665ae0
parseAlterTableAddUniqueKeyDesc.in https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-2691effe80e4fb1928d3534898d01799c0b9817c327c3d9fdc9e3fad3f9740ce
parseAlterTableAddUniqueKeyDesc.out https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-b041d107af0a600e369aa2ac6ed50a235088ef699748a010fa10923b0269baf6
parseAlterTableAddUniqueKeyDescAsc.in https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-f3008ed9fbefe3349773b0e63c111cd17289397eb3035ad46edb8a4b64f05891
parseAlterTableAddUniqueKeyDescAsc.out https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-d8bc8e2084d4e6cfef3e939b0383231b46d9e42602708cdd34766822aaeb7d7c
parseAlterTableAddUniqueKeyDescLower.in https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-227539fa3a19a8447270583db7c8eae504672bc152ee61baa6783d6a68421baa
parseAlterTableAddUniqueKeyDescLower.out https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-646a4ed1cf3b4266c401bcf86950870b2bdb46d57c34eb9217efa6dc70d097e0
parseAlterTableAddUniqueKeyTwoDesc.in https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-997d949e7b2b92918904daeebeab664fdac2c94724cca5d37c560e48bdd186fd
parseAlterTableAddUniqueKeyTwoDesc.out https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-a091b83e2941311c8001b0bdb0b27c22e25d1093191c378bff59046a5e0aae58
src/Parsers/AlterOperations.phphttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-3e6ea00045acfa8ceb9655104da93b6f84013ce9c911615033a4f17962104872
View file https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/blob/3c2e0be7918ace8814b1b08a94b6120a26787585/src/Parsers/AlterOperations.php
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-3e6ea00045acfa8ceb9655104da93b6f84013ce9c911615033a4f17962104872
https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-3e6ea00045acfa8ceb9655104da93b6f84013ce9c911615033a4f17962104872
tests/Parser/AlterStatementTest.phphttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-28d0e0a508ed8d5736042f2a90ee313e08cce9ce206d24a6bfc0ae09dba3e9e4
View file https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/blob/3c2e0be7918ace8814b1b08a94b6120a26787585/tests/Parser/AlterStatementTest.php
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-28d0e0a508ed8d5736042f2a90ee313e08cce9ce206d24a6bfc0ae09dba3e9e4
williamdeshttps://patch-diff.githubusercontent.com/williamdes
Jan 2, 2026https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#r2657438152
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files
predictor2718https://patch-diff.githubusercontent.com/predictor2718
Jan 3, 2026https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#r2658895190
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files
https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-28d0e0a508ed8d5736042f2a90ee313e08cce9ce206d24a6bfc0ae09dba3e9e4
tests/data/parser/parseAlterTableAddUniqueKeyAsc.inhttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-e06cdcbb53e80b763a548d0242d5d61abe7b1ad5df093fd720cf29f1c6e2e80a
View file https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/blob/3c2e0be7918ace8814b1b08a94b6120a26787585/tests/data/parser/parseAlterTableAddUniqueKeyAsc.in
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/{{ revealButtonHref }}
tests/data/parser/parseAlterTableAddUniqueKeyAsc.outhttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-99e36ebea164be085f570db760d9f293cf4ca725c3919c1309a1451cf81c0f43
View file https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/blob/3c2e0be7918ace8814b1b08a94b6120a26787585/tests/data/parser/parseAlterTableAddUniqueKeyAsc.out
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/{{ revealButtonHref }}
tests/data/parser/parseAlterTableAddUniqueKeyAscDesc.inhttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files#diff-cd274c5f60ac500c6edaf18c6e6d72adfb9bd86b06b256de1a4bfc71cc229e19
View file https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/blob/3c2e0be7918ace8814b1b08a94b6120a26787585/tests/data/parser/parseAlterTableAddUniqueKeyAscDesc.in
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/{{ revealButtonHref }}
Please reload this pagehttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.