René's URL Explorer Experiment


Title: Fix #592 - desc index by predictor2718 · Pull Request #636 · phpmyadmin/sql-parser · GitHub

Open Graph Title: Fix #592 - desc index by predictor2718 · Pull Request #636 · phpmyadmin/sql-parser

X Title: Fix #592 - desc index by predictor2718 · Pull Request #636 · phpmyadmin/sql-parser

Description: Description This PR fixes incorrect parsing of DESC inside index definitions in ALTER TABLE statements. Example: ALTER TABLE `t` ADD UNIQUE KEY `idx` (`a`, `b` DESC); This change updates AlterOpe...

Open Graph Description: Description This PR fixes incorrect parsing of DESC inside index definitions in ALTER TABLE statements. Example: ALTER TABLE `t` ADD UNIQUE KEY `idx` (`a`, `b` DESC); This change updates AlterOpe...

X Description: Description This PR fixes incorrect parsing of DESC inside index definitions in ALTER TABLE statements. Example: ALTER TABLE `t` ADD UNIQUE KEY `idx` (`a`, `b` DESC); This change updates AlterOpe...

Opengraph URL: https://github.com/phpmyadmin/sql-parser/pull/636

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bb3ef6aa-74dc-b9d1-16a5-b76d213e639e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3A6:192DFC:1314D6D:1929381:696D5204
html-safe-nonce0ce6397830ecb940954fc0bf2ffb9167b67f60eb43f8e7eae606033f0dadee9b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0E2OjE5MkRGQzoxMzE0RDZEOjE5MjkzODE6Njk2RDUyMDQiLCJ2aXNpdG9yX2lkIjoiNjIzMjE3MTM2OTg4NjIwODUxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2b10e570a92b8aa9bce8b8b4f39d60ad363c7ffe7f476d11c619892e700aa608
hovercard-subject-tagpull_request:3041712788
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/phpmyadmin/sql-parser/636/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cdb99053b3bb6a34e7ce91be160f019f0499a3b4d1f6280bc6b477f456fa383e/phpmyadmin/sql-parser/pull/636
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cdb99053b3bb6a34e7ce91be160f019f0499a3b4d1f6280bc6b477f456fa383e/phpmyadmin/sql-parser/pull/636
og:image:altDescription This PR fixes incorrect parsing of DESC inside index definitions in ALTER TABLE statements. Example: ALTER TABLE `t` ADD UNIQUE KEY `idx` (`a`, `b` DESC); This change updates AlterOpe...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepredictor2718
hostnamegithub.com
expected-hostnamegithub.com
None0944e430045f4fb5f7bd103e0660080acfe593174063212555773ca41c144a14
turbo-cache-controlno-preview
go-importgithub.com/phpmyadmin/sql-parser git https://github.com/phpmyadmin/sql-parser.git
octolytics-dimension-user_id1351977
octolytics-dimension-user_loginphpmyadmin
octolytics-dimension-repository_id36256604
octolytics-dimension-repository_nwophpmyadmin/sql-parser
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36256604
octolytics-dimension-repository_network_root_nwophpmyadmin/sql-parser
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release66b6e773801d28660016072069017cfcc851f54b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpmyadmin%2Fsql-parser%2Fpull%2F636
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpmyadmin%2Fsql-parser%2Fpull%2F636
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=phpmyadmin%2Fsql-parser
Reloadhttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636
Reloadhttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636
Reloadhttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636
phpmyadmin https://patch-diff.githubusercontent.com/phpmyadmin
sql-parserhttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser
Please reload this pagehttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fphpmyadmin%2Fsql-parser
Fork 110 https://patch-diff.githubusercontent.com/login?return_to=%2Fphpmyadmin%2Fsql-parser
Star 472 https://patch-diff.githubusercontent.com/login?return_to=%2Fphpmyadmin%2Fsql-parser
Code https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser
Issues 50 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/issues
Pull requests 5 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pulls
Actions https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/actions
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/security
Please reload this pagehttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636
Insights https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pulse
Code https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser
Issues https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/issues
Pull requests https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pulls
Actions https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/actions
Security https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/security
Insights https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fphpmyadmin%2Fsql-parser%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fphpmyadmin%2Fsql-parser%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636#issue-comment-box
predictor2718https://patch-diff.githubusercontent.com/predictor2718
phpmyadmin:6.0.xhttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/tree/6.0.x
predictor2718:fix-592-desc-indexhttps://patch-diff.githubusercontent.com/predictor2718/sql-parser/tree/fix-592-desc-index
Fix #592 - desc index https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636#top
predictor2718https://patch-diff.githubusercontent.com/predictor2718
phpmyadmin:6.0.xhttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/tree/6.0.x
predictor2718:fix-592-desc-indexhttps://patch-diff.githubusercontent.com/predictor2718/sql-parser/tree/fix-592-desc-index
Conversation 4 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636
Commits 5 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits
Checks 0 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/checks
Files changed https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files
Please reload this pagehttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/predictor2718
predictor2718https://patch-diff.githubusercontent.com/predictor2718
Nov 24, 2025https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636#issue-3660796823
#592https://github.com/phpmyadmin/sql-parser/issues/592
Please reload this pagehttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636
predictor2718https://patch-diff.githubusercontent.com/predictor2718
November 24, 2025 23:38https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636#commits-pushed-54b5586
https://patch-diff.githubusercontent.com/predictor2718
Fix ALTER index parsing: DESC should not begin a new statement (https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/54b5586414ce43c24c4fadef3c638264d471f6bd
phpmy…https://github.com/phpmyadmin/sql-parser/issues/592
54b5586https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/54b5586414ce43c24c4fadef3c638264d471f6bd
…admin#592https://github.com/phpmyadmin/sql-parser/issues/592
https://patch-diff.githubusercontent.com/predictor2718
Add test for DESC index (https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/bc4e5e9214b0ba72d1bab33a6c656601e095bc74
phpmyadmin#592https://github.com/phpmyadmin/sql-parser/issues/592
)https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/bc4e5e9214b0ba72d1bab33a6c656601e095bc74
bc4e5e9https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/bc4e5e9214b0ba72d1bab33a6c656601e095bc74
https://patch-diff.githubusercontent.com/predictor2718
predictor2718https://patch-diff.githubusercontent.com/predictor2718
Nov 24, 2025 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636#ref-issue-2905451083
Fail to copy database when it includes descending Indexes phpmyadmin/phpmyadmin#19626 https://patch-diff.githubusercontent.com/phpmyadmin/phpmyadmin/issues/19626
https://patch-diff.githubusercontent.com/williamdes
williamdeshttps://patch-diff.githubusercontent.com/williamdes
Nov 25, 2025https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636#event-21173721840
https://patch-diff.githubusercontent.com/williamdes
williamdeshttps://patch-diff.githubusercontent.com/williamdes
Nov 25, 2025 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636#pullrequestreview-3506740660
View reviewed changes https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files/bc4e5e9214b0ba72d1bab33a6c656601e095bc74
williamdeshttps://patch-diff.githubusercontent.com/williamdes
https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636#pullrequestreview-3506740660
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636
predictor2718https://patch-diff.githubusercontent.com/predictor2718
November 26, 2025 23:18https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636#commits-pushed-5b35ae7
https://patch-diff.githubusercontent.com/predictor2718
Fix too long line - phpcs linting hint (https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/5b35ae747e037d01d1b21e343fb4e39fb612c76d
phpmyadmin#592https://github.com/phpmyadmin/sql-parser/issues/592
)https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/5b35ae747e037d01d1b21e343fb4e39fb612c76d
5b35ae7https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/5b35ae747e037d01d1b21e343fb4e39fb612c76d
https://patch-diff.githubusercontent.com/predictor2718
Add tests for ASC and lowercase keyword (https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/eac040f8f91f2eefa48c60acab2978102901eac0
phpmyadmin#592https://github.com/phpmyadmin/sql-parser/issues/592
)https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/eac040f8f91f2eefa48c60acab2978102901eac0
eac040fhttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/eac040f8f91f2eefa48c60acab2978102901eac0
https://patch-diff.githubusercontent.com/predictor2718
predictor2718https://patch-diff.githubusercontent.com/predictor2718
Nov 26, 2025https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636#issuecomment-3583441186
Please reload this pagehttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636
https://patch-diff.githubusercontent.com/williamdes
williamdeshttps://patch-diff.githubusercontent.com/williamdes
Jan 2, 2026 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636#pullrequestreview-3622828964
View reviewed changes https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files/eac040f8f91f2eefa48c60acab2978102901eac0
tests/Parser/AlterStatementTest.phphttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files/eac040f8f91f2eefa48c60acab2978102901eac0#diff-28d0e0a508ed8d5736042f2a90ee313e08cce9ce206d24a6bfc0ae09dba3e9e4
williamdeshttps://patch-diff.githubusercontent.com/williamdes
Jan 2, 2026https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636#discussion_r2657438152
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636
predictor2718https://patch-diff.githubusercontent.com/predictor2718
Jan 3, 2026https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636#discussion_r2658895190
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636
https://patch-diff.githubusercontent.com/williamdes
williamdeshttps://patch-diff.githubusercontent.com/williamdes
Jan 2, 2026 https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636#pullrequestreview-3622831951
View reviewed changes https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files/eac040f8f91f2eefa48c60acab2978102901eac0
https://patch-diff.githubusercontent.com/predictor2718
phpmyadmin#592https://github.com/phpmyadmin/sql-parser/issues/592
link test files and add asc-desc index testshttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/3c2e0be7918ace8814b1b08a94b6120a26787585
3c2e0behttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/commits/3c2e0be7918ace8814b1b08a94b6120a26787585
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpmyadmin%2Fsql-parser%2Fpull%2F636
https://patch-diff.githubusercontent.com/williamdes
williamdes https://patch-diff.githubusercontent.com/williamdes
https://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636/files/eac040f8f91f2eefa48c60acab2978102901eac0
Please reload this pagehttps://patch-diff.githubusercontent.com/phpmyadmin/sql-parser/pull/636
https://patch-diff.githubusercontent.com/predictor2718
https://patch-diff.githubusercontent.com/williamdes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.