| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:07bf9066-4ae5-464f-7219-d92fd544c920 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D750:301219:58063D:77B9D9:698E2FDA |
| html-safe-nonce | 6e095230dae9212212f6ef7615fb6a67b587403efd820b89362442552660aa38 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzUwOjMwMTIxOTo1ODA2M0Q6NzdCOUQ5OjY5OEUyRkRBIiwidmlzaXRvcl9pZCI6IjkxMDQ4Mzk1MzU0ODU2NjExNDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 04afa728d1ed226b3df3a57b303ebda3fc51808e1f2463171cfdb608b9468c2a |
| hovercard-subject-tag | pull_request:2196794166 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/pcb2gcode/pcb2gcode/692/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/301fdc471e21084889df936163867ec23fef4a41ff95e6dc7795bbe9df8ccc28/pcb2gcode/pcb2gcode/pull/692 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/301fdc471e21084889df936163867ec23fef4a41ff95e6dc7795bbe9df8ccc28/pcb2gcode/pcb2gcode/pull/692 |
| og:image:alt | This avoids leaving a chunk of material in the middle of the hole when milldrilling holes larger than twice the cutter diameter, which can cause various problems.
It isn't quite finished, but i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tomjnixon |
| hostname | github.com |
| expected-hostname | github.com |
| None | a5632af64f7fed7bff1d6a428d1aca1b94fa7a48f760de2d39d9b1effdbf0082 |
| turbo-cache-control | no-cache |
| go-import | github.com/pcb2gcode/pcb2gcode git https://github.com/pcb2gcode/pcb2gcode.git |
| octolytics-dimension-user_id | 11042572 |
| octolytics-dimension-user_login | pcb2gcode |
| octolytics-dimension-repository_id | 30911983 |
| octolytics-dimension-repository_nwo | pcb2gcode/pcb2gcode |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 30911983 |
| octolytics-dimension-repository_network_root_nwo | pcb2gcode/pcb2gcode |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | df1885ca022c7c5634d3a31e5a91e6a35990d0b7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpcb2gcode%2Fpcb2gcode%2Fpull%2F692 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpcb2gcode%2Fpcb2gcode%2Fpull%2F692 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=pcb2gcode%2Fpcb2gcode |
| Reload | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692 |
| Reload | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692 |
| Reload | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692 |
|
pcb2gcode
| https://patch-diff.githubusercontent.com/pcb2gcode |
| pcb2gcode | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fpcb2gcode%2Fpcb2gcode |
|
Fork
112
| https://patch-diff.githubusercontent.com/login?return_to=%2Fpcb2gcode%2Fpcb2gcode |
|
Star
473
| https://patch-diff.githubusercontent.com/login?return_to=%2Fpcb2gcode%2Fpcb2gcode |
|
Code
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode |
|
Issues
62
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/issues |
|
Pull requests
12
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/wiki |
|
Security
0
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/security |
|
Insights
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pulse |
|
Code
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode |
|
Issues
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/actions |
|
Projects
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/wiki |
|
Security
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/security |
|
Insights
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pulse |
| tomjnixon | https://patch-diff.githubusercontent.com/tomjnixon |
| pcb2gcode:master | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/tree/master |
| tomjnixon:multi_step_milldrill | https://patch-diff.githubusercontent.com/tomjnixon/pcb2gcode/tree/multi_step_milldrill |
| Conversation | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692 |
| Commits11 (11) | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits |
| Checks | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/checks |
| Files changed | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/files |
| use multiple steps when milldrilling large holes | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692#top |
| tomjnixon | https://patch-diff.githubusercontent.com/tomjnixon |
| pcb2gcode:master | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/tree/master |
| tomjnixon:multi_step_milldrill | https://patch-diff.githubusercontent.com/tomjnixon/pcb2gcode/tree/multi_step_milldrill |
|
| https://patch-diff.githubusercontent.com/tomjnixon |
| tomjnixon | https://patch-diff.githubusercontent.com/tomjnixon |
| Nov 24, 2024 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692#issue-2687772266 |
| Please reload this page | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692 |
| https://private-user-images.githubusercontent.com/178226/389277260-6edf1b8c-fac7-41b0-9d21-6ec54f568e28.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzA5MjYzNDMsIm5iZiI6MTc3MDkyNjA0MywicGF0aCI6Ii8xNzgyMjYvMzg5Mjc3MjYwLTZlZGYxYjhjLWZhYzctNDFiMC05ZDIxLTZlYzU0ZjU2OGUyOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDIxMlQxOTU0MDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lYWMzMzhlNGNiOGNkMjA1OTNhMGQzYmQzZDQ1NzJlOTk4MGExMDgwYTQxZjVlNjFjMjExOTQyZTUxMWMzZTMwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.i_dgGQzibnye3RTSGjGuABWtr-Tz1CWVxyAMq0zFJms |
| https://private-user-images.githubusercontent.com/178226/389277263-c2ac2fdb-bb0c-4207-9904-a54aa9dfdd6a.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzA5MjYzNDMsIm5iZiI6MTc3MDkyNjA0MywicGF0aCI6Ii8xNzgyMjYvMzg5Mjc3MjYzLWMyYWMyZmRiLWJiMGMtNDIwNy05OTA0LWE1NGFhOWRmZGQ2YS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDIxMlQxOTU0MDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lMjU5ODdkMWIyM2FkNTkyZmRiMjQ5MjZmNDdiMzdlYjI5MmZjZTMyYWU0NmZkYzIwMWU0ZTc0ZjliNWJlODA2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.NjYZCBVmJq8hAeGRJPgDWabRK0PtG3T5-GL37CN2HlU |
| https://private-user-images.githubusercontent.com/178226/389277261-f856dbe5-732e-4d7f-876f-04cd235c683b.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzA5MjYzNDMsIm5iZiI6MTc3MDkyNjA0MywicGF0aCI6Ii8xNzgyMjYvMzg5Mjc3MjYxLWY4NTZkYmU1LTczMmUtNGQ3Zi04NzZmLTA0Y2QyMzVjNjgzYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDIxMlQxOTU0MDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kZGViOWQzMzY2NTlkMGRkNDk3ZDA0NzAyYzVhOWU4NThlYWNjZjkzNGEwOTcxMDIzNWRkZWZlZWMyYTg0NjNhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Bbth8epB4BDak6zrZCMEvX1gDm9xNLuIve6m7EwoyT0 |
| Please reload this page | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692 |
| tomjnixon | https://patch-diff.githubusercontent.com/tomjnixon |
| November 24, 2024 14:05 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692#commits-pushed-ad84c6c |
|
| https://patch-diff.githubusercontent.com/tomjnixon |
| use multiple steps when milldrilling large holes | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/ad84c6c172ba6479c3da3a1ca6bbc6d4405dc8ed |
| ad84c6c | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/ad84c6c172ba6479c3da3a1ca6bbc6d4405dc8ed |
|
| https://patch-diff.githubusercontent.com/tomjnixon |
| fix typo in min-milldrill-hole-diameter help | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/f47153d07d1fcf942c18c2d4b503e84c1878422e |
| f47153d | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/f47153d07d1fcf942c18c2d4b503e84c1878422e |
|
| https://patch-diff.githubusercontent.com/tomjnixon |
| update tests for multi-step milldrill | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/b1dade8f669e6441dca613539a4ab7b606831e66 |
| b1dade8 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/b1dade8f669e6441dca613539a4ab7b606831e66 |
| https://patch-diff.githubusercontent.com/tomjnixon |
| tomjnixon | https://patch-diff.githubusercontent.com/tomjnixon |
| force-pushed | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/compare/2fd1be23d24660c268da87a8aa4e0eeec5e06902..b1dade8f669e6441dca613539a4ab7b606831e66 |
| 2fd1be2 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/commit/2fd1be23d24660c268da87a8aa4e0eeec5e06902 |
| b1dade8 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/commit/b1dade8f669e6441dca613539a4ab7b606831e66 |
|
Compare
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/compare/2fd1be23d24660c268da87a8aa4e0eeec5e06902..b1dade8f669e6441dca613539a4ab7b606831e66 |
| November 24, 2024 14:06 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692#event-15410680372 |
| https://patch-diff.githubusercontent.com/eyal0 |
| eyal0 | https://patch-diff.githubusercontent.com/eyal0 |
| Nov 24, 2024 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692#issuecomment-2496108780 |
| Please reload this page | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692 |
| https://patch-diff.githubusercontent.com/coveralls |
| coveralls | https://patch-diff.githubusercontent.com/coveralls |
| Nov 24, 2024 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692#issuecomment-2496121086 |
| https://coveralls.io/builds/71026057 |
| b1dade8 | https://github.com/pcb2gcode/pcb2gcode/commit/b1dade8f669e6441dca613539a4ab7b606831e66 |
| 8c084af | https://github.com/pcb2gcode/pcb2gcode/commit/8c084afd00c6653dfa9cbf24a1dbeeb24f592aa9 |
| Please reload this page | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692 |
| https://patch-diff.githubusercontent.com/eyal0 |
| eyal0 | https://patch-diff.githubusercontent.com/eyal0 |
|
Nov 24, 2024
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692#pullrequestreview-2456777490 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/files/b1dade8f669e6441dca613539a4ab7b606831e66 |
| drill.cpp | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/files/b1dade8f669e6441dca613539a4ab7b606831e66#diff-eab54a7d9e10bca71815c25e8838dbb89a7df8d5697499b41fbb92e3738fc919 |
| eyal0 | https://patch-diff.githubusercontent.com/eyal0 |
| Nov 24, 2024 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692#discussion_r1855518125 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692 |
| tomjnixon | https://patch-diff.githubusercontent.com/tomjnixon |
| Nov 24, 2024 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692#discussion_r1855530358 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| pcb2gcode/drill.cpp | https://github.com/pcb2gcode/pcb2gcode/blob/b1dade8f669e6441dca613539a4ab7b606831e66/drill.cpp#L716-L717 |
| b1dade8 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/commit/b1dade8f669e6441dca613539a4ab7b606831e66 |
| Please reload this page | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692 |
| eyal0 | https://patch-diff.githubusercontent.com/eyal0 |
| Nov 24, 2024 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692#discussion_r1855541572 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692 |
| tomjnixon | https://patch-diff.githubusercontent.com/tomjnixon |
| Nov 24, 2024 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692#discussion_r1855547822 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692 |
| https://patch-diff.githubusercontent.com/eyal0 |
| eyal0 | https://patch-diff.githubusercontent.com/eyal0 |
| Nov 24, 2024 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692#issuecomment-2496185361 |
| Please reload this page | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692 |
| https://patch-diff.githubusercontent.com/tomjnixon |
| tomjnixon | https://patch-diff.githubusercontent.com/tomjnixon |
| Nov 24, 2024 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692#issuecomment-2496221628 |
| Please reload this page | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692 |
| https://patch-diff.githubusercontent.com/eyal0 |
| eyal0 | https://patch-diff.githubusercontent.com/eyal0 |
| Nov 24, 2024 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692#issuecomment-2496244721 |
| https://coveralls.io/jobs/156533579/source_files/36521372103#L575 | https://coveralls.io/jobs/156533579/source_files/36521372103#L575 |
| Please reload this page | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692 |
| tomjnixon | https://patch-diff.githubusercontent.com/tomjnixon |
| November 24, 2024 22:03 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692#commits-pushed-55b7d7b |
|
| https://patch-diff.githubusercontent.com/tomjnixon |
| fixup: simplify and correct bad hole calculation | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/55b7d7bdf167420ce4ae5411a21ec6dae8b10609 |
| 55b7d7b | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/55b7d7bdf167420ce4ae5411a21ec6dae8b10609 |
|
| https://patch-diff.githubusercontent.com/tomjnixon |
| fixup: add missing assert on cutter | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/153100b632e5fd850aede531fb14f99a589181f3 |
| 153100b | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/153100b632e5fd850aede531fb14f99a589181f3 |
|
| https://patch-diff.githubusercontent.com/tomjnixon |
| fixup: use correct indentation | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/4d41999eb58f99a21cd0065bbc062801f3a94153 |
| 4d41999 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/4d41999eb58f99a21cd0065bbc062801f3a94153 |
|
| https://patch-diff.githubusercontent.com/tomjnixon |
| fixup: avoid possible divide by zero in multi-pass arm | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/a6f58149d9621a2e6c1aa31e6a701821f77da6a7 |
| a6f5814 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/a6f58149d9621a2e6c1aa31e6a701821f77da6a7 |
|
| https://patch-diff.githubusercontent.com/tomjnixon |
| fixup: add tolerance for single-pass | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/7bddc5f40c85c28c70f7001d4da618f3f2b88d75 |
| 7bddc5f | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/7bddc5f40c85c28c70f7001d4da618f3f2b88d75 |
|
| https://patch-diff.githubusercontent.com/tomjnixon |
| fixup: simplify tolerances | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/0fbca9c5b2a4e71311c70ed1306cbace8c8dff84 |
| 0fbca9c | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/0fbca9c5b2a4e71311c70ed1306cbace8c8dff84 |
|
| https://patch-diff.githubusercontent.com/tomjnixon |
| fixup: make sure entry_diameter is less than max_entry | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/6920744703680a35f8f12e14b1e1333a4b3801c5 |
| 6920744 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/6920744703680a35f8f12e14b1e1333a4b3801c5 |
|
| https://patch-diff.githubusercontent.com/tomjnixon |
| add multi-step milldrill test | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/651fb8f556c03da2e06aa2433a49995cf2022906 |
| 651fb8f | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/commits/651fb8f556c03da2e06aa2433a49995cf2022906 |
| https://patch-diff.githubusercontent.com/tomjnixon |
| tomjnixon | https://patch-diff.githubusercontent.com/tomjnixon |
| force-pushed | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/compare/4c5a9c9d4cb9d9fec1d769f7befdcf5bf486f8a8..651fb8f556c03da2e06aa2433a49995cf2022906 |
| 4c5a9c9 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/commit/4c5a9c9d4cb9d9fec1d769f7befdcf5bf486f8a8 |
| 651fb8f | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/commit/651fb8f556c03da2e06aa2433a49995cf2022906 |
|
Compare
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/compare/4c5a9c9d4cb9d9fec1d769f7befdcf5bf486f8a8..651fb8f556c03da2e06aa2433a49995cf2022906 |
| November 25, 2024 17:45 | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692#event-15424478658 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/{{ revealButtonHref }} |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpcb2gcode%2Fpcb2gcode%2Fpull%2F692 |
|
| https://patch-diff.githubusercontent.com/eyal0 |
|
eyal0
| https://patch-diff.githubusercontent.com/eyal0 |
|
| https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692/files/b1dade8f669e6441dca613539a4ab7b606831e66 |
| Please reload this page | https://patch-diff.githubusercontent.com/pcb2gcode/pcb2gcode/pull/692 |
|
| https://patch-diff.githubusercontent.com/tomjnixon |
|
| https://patch-diff.githubusercontent.com/eyal0 |
|
| https://patch-diff.githubusercontent.com/coveralls |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |