René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[RulePad] Incorrect violations are produced for a design rule.","articleBody":"- RulePad:\r\n![Screenshot 2024-08-28 at 12 29 09 PM](https://github.com/user-attachments/assets/5a6daa84-d6ad-483d-8973-e52720be5a6a)\r\n![Screenshot 2024-08-28 at 12 29 51 PM](https://github.com/user-attachments/assets/92f64f35-6edc-43fa-b768-461bb9aa687e)\r\n\r\n- Code:\r\n```Java\r\npackage io.hexlet.typoreporter.controller;\r\n\r\nimport io.hexlet.typoreporter.domain.typo.TypoEvent;\r\nimport io.hexlet.typoreporter.service.TypoService;\r\nimport io.hexlet.typoreporter.service.WorkspaceService;\r\nimport io.hexlet.typoreporter.handler.exception.TypoNotFoundException;\r\nimport io.hexlet.typoreporter.handler.exception.WorkspaceNotFoundException;\r\nimport lombok.RequiredArgsConstructor;\r\nimport lombok.extern.slf4j.Slf4j;\r\nimport org.springframework.stereotype.Controller;\r\nimport org.springframework.web.bind.annotation.PatchMapping;\r\nimport org.springframework.web.bind.annotation.PathVariable;\r\nimport org.springframework.web.bind.annotation.RequestMapping;\r\nimport org.springframework.web.bind.annotation.RequestParam;\r\n\r\nimport java.util.Optional;\r\n\r\n//TODO add tests\r\n@Slf4j\r\n@Controller\r\n@RequestMapping(\"/typos\")\r\n@RequiredArgsConstructor\r\npublic class TypoController {\r\n\r\n    private final TypoService typoService;\r\n\r\n    private final WorkspaceService workspaceService;\r\n\r\n    @PatchMapping(\"/{id}/status\")\r\n    public String updateTypoStatus(@PathVariable Long id,\r\n                                   @RequestParam Optional\u003cLong\u003e wksId,\r\n                                   @RequestParam Optional\u003cTypoEvent\u003e event,\r\n                                   @RequestParam Optional\u003cString\u003e next) {\r\n        if (wksId.isEmpty() || !workspaceService.existsWorkspaceById(wksId.get())) {\r\n            //TODO send to error page\r\n            final var e = new WorkspaceNotFoundException(wksId.orElse(0L));\r\n            log.error(e.toString(), e);\r\n            return \"redirect:/workspaces\";\r\n        }\r\n        if (event.isEmpty()) {\r\n            //TODO send to error page\r\n            log.error(\"TypoEvent={} must not be null\", event.orElse(null));\r\n            return (\"redirect:/workspace/\") + wksId.get() + next.orElse(\"/typos\");\r\n        }\r\n        final var updatedTypo = typoService.updateTypoStatus(id, event.get());\r\n        if (updatedTypo.isEmpty()) {\r\n            //TODO send to error page\r\n            final var e = new TypoNotFoundException(id);\r\n            log.error(e.getMessage(), e);\r\n        }\r\n        return (\"redirect:/workspace/\") + wksId.get() + next.orElse(\"/typos\");\r\n    }\r\n\r\n}\r\n```\r\n- Authored DesignRule:\r\n```json\r\n[\r\n  {\r\n    \"index\": \"1724830895\",\r\n    \"title\": \"Controller class must have a service field\",\r\n    \"description\": \"Controller class must have service class field to handle business logic processing\",\r\n    \"tags\": [],\r\n    \"checkForFilesFoldersConstraints\": \"INCLUDE\",\r\n    \"checkForFilesFolders\": [\r\n      \"hexlet-correction/src/main/java/io/hexlet/typoreporter/controller\"\r\n    ],\r\n    \"processFilesFolders\": \"WITHIN\",\r\n    \"quantifierXPathQuery\": [\r\n      \"src:unit/src:class\"\r\n    ],\r\n    \"constraintXPathQuery\": [\r\n      \"src:unit/src:class[src:annotation/src:name[text()=\\\"Controller\\\"] and src:specifier[text()=\\\"public\\\"] and src:name[substring(text(),string-length(text())-string-length(\\\"Controller\\\")+1)=\\\"Controller\\\"] and descendant-or-self::src:decl_stmt/src:decl[(src:specifier[text()=\\\"private\\\"] and src:specifier[text()=\\\"final\\\"] and src:name[substring(text(),string-length(text())-string-length(\\\"Service\\\")+1)=\\\"Service\\\"])]]\"\r\n    ],\r\n    \"grammar\": \"class with declaration statement with ( visibility \\\"private\\\" and specifier \\\"final\\\" and name \\\"...Service\\\" ) must have annotation \\\"Controller\\\" and visibility \\\"public\\\" and name \\\"...Controller\\\" and declaration statement with ( visibility \\\"private\\\" and specifier \\\"final\\\" and name \\\"...Service\\\" )\"\r\n  }\r\n]\r\n```","author":{"url":"https://github.com/SaharMehrpour","@type":"Person","name":"SaharMehrpour"},"datePublished":"2024-08-28T16:32:01.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/28/ActiveDocumentation-webapp/issues/28"}