René's URL Explorer Experiment


Title: Improve executor performance by ivanpauno · Pull Request #87 · osrf/ros2_java · GitHub

Open Graph Title: Improve executor performance by ivanpauno · Pull Request #87 · osrf/ros2_java

X Title: Improve executor performance by ivanpauno · Pull Request #87 · osrf/ros2_java

Description: This PR applies two minor improvements: (1) Avoid to repeating some iterations over the same colections. Doesn't reduce time complexity, but it reduces the total amount of "operations" done. (2) C...

Open Graph Description: This PR applies two minor improvements: (1) Avoid to repeating some iterations over the same colections. Doesn't reduce time complexity, but it reduces the total amount of "operations&quo...

X Description: This PR applies two minor improvements: (1) Avoid to repeating some iterations over the same colections. Doesn't reduce time complexity, but it reduces the total amount of "operat...

Opengraph URL: https://github.com/osrf/ros2_java/pull/87

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d0d0db0c-7d8e-3989-dd8b-d1ec760652b7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA0A:3CBB1D:5494B6:6B4623:697FBB22
html-safe-nonce6c3eed37031cbeb9eb99fd464739c9b9f2caca772338e87a9e907c72c967b688
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTBBOjNDQkIxRDo1NDk0QjY6NkI0NjIzOjY5N0ZCQjIyIiwidmlzaXRvcl9pZCI6IjE1NDA3ODQ0NDIyMTIwNzIyMjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf5e0eabf78dcb965b6e8c8199155ae8be427e899ccc6c66e9fb3e30e964bef4c
hovercard-subject-tagpull_request:827911224
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/osrf/ros2_java/87/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e4968c976f7d744b794f38066231d1f6950c2ccdf1bf4b70b2e6b762f5d6107d/osrf/ros2_java/pull/87
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e4968c976f7d744b794f38066231d1f6950c2ccdf1bf4b70b2e6b762f5d6107d/osrf/ros2_java/pull/87
og:image:altThis PR applies two minor improvements: (1) Avoid to repeating some iterations over the same colections. Doesn't reduce time complexity, but it reduces the total amount of "operations&quo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameivanpauno
hostnamegithub.com
expected-hostnamegithub.com
None60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6
turbo-cache-controlno-preview
go-importgithub.com/osrf/ros2_java git https://github.com/osrf/ros2_java.git
octolytics-dimension-user_id3999730
octolytics-dimension-user_loginosrf
octolytics-dimension-repository_id278167259
octolytics-dimension-repository_nwoosrf/ros2_java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id52850323
octolytics-dimension-repository_parent_nworos2-java/ros2_java
octolytics-dimension-repository_network_root_id52850323
octolytics-dimension-repository_network_root_nworos2-java/ros2_java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7c85641c598ad130c74f7bcc27f58575cac69551
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fosrf%2Fros2_java%2Fpull%2F87
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fosrf%2Fros2_java%2Fpull%2F87
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=osrf%2Fros2_java
Reloadhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87
Reloadhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87
Reloadhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87
osrf https://patch-diff.githubusercontent.com/osrf
ros2_javahttps://patch-diff.githubusercontent.com/osrf/ros2_java
ros2-java/ros2_javahttps://patch-diff.githubusercontent.com/ros2-java/ros2_java
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fosrf%2Fros2_java
Fork 9 https://patch-diff.githubusercontent.com/login?return_to=%2Fosrf%2Fros2_java
Star 4 https://patch-diff.githubusercontent.com/login?return_to=%2Fosrf%2Fros2_java
Code https://patch-diff.githubusercontent.com/osrf/ros2_java
Pull requests 2 https://patch-diff.githubusercontent.com/osrf/ros2_java/pulls
Actions https://patch-diff.githubusercontent.com/osrf/ros2_java/actions
Projects 0 https://patch-diff.githubusercontent.com/osrf/ros2_java/projects
Security 0 https://patch-diff.githubusercontent.com/osrf/ros2_java/security
Insights https://patch-diff.githubusercontent.com/osrf/ros2_java/pulse
Code https://patch-diff.githubusercontent.com/osrf/ros2_java
Pull requests https://patch-diff.githubusercontent.com/osrf/ros2_java/pulls
Actions https://patch-diff.githubusercontent.com/osrf/ros2_java/actions
Projects https://patch-diff.githubusercontent.com/osrf/ros2_java/projects
Security https://patch-diff.githubusercontent.com/osrf/ros2_java/security
Insights https://patch-diff.githubusercontent.com/osrf/ros2_java/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fosrf%2Fros2_java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fosrf%2Fros2_java%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87#issue-comment-box
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
mainhttps://patch-diff.githubusercontent.com/osrf/ros2_java/tree/main
ivanpauno/improve-executor-performancehttps://patch-diff.githubusercontent.com/osrf/ros2_java/tree/ivanpauno/improve-executor-performance
Improve executor performance https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87#top
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
mainhttps://patch-diff.githubusercontent.com/osrf/ros2_java/tree/main
ivanpauno/improve-executor-performancehttps://patch-diff.githubusercontent.com/osrf/ros2_java/tree/ivanpauno/improve-executor-performance
Conversation 4 https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87
Commits 6 https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/commits
Checks 0 https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/checks
Files changed https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/files
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/ivanpauno
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
Jan 20, 2022https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87#issue-1109748011
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87
visualvmhttps://visualvm.github.io/download.html
herehttps://krimson8.github.io/linux/2019/03/13/Configuring-CPU-frequency.html
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
January 19, 2022 17:31https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87#commits-pushed-25cbf1c
https://patch-diff.githubusercontent.com/ivanpauno
Improve executor performancehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/commits/25cbf1c879e83b465441cf87a86ea5c423f90a82
25cbf1chttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/commits/25cbf1c879e83b465441cf87a86ea5c423f90a82
https://patch-diff.githubusercontent.com/ivanpauno
Another minor improvementhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/commits/0610b4434f4fe9b727aa3960de2a8c716b6aebb3
0610b44https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/commits/0610b4434f4fe9b727aa3960de2a8c716b6aebb3
https://patch-diff.githubusercontent.com/ivanpauno
Add native method to resize waitsethttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/commits/68af1aa4a82e9a49a07370ed0e9d6629440c68b9
68af1aahttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/commits/68af1aa4a82e9a49a07370ed0e9d6629440c68b9
https://patch-diff.githubusercontent.com/ivanpauno
Cache waitset through spin calls, to avoid allocations/deallocationshttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/commits/3de3325080108f72a0e031ec9f4cd3fade3e3cff
3de3325https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/commits/3de3325080108f72a0e031ec9f4cd3fade3e3cff
https://patch-diff.githubusercontent.com/ivanpauno
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
enhancement https://patch-diff.githubusercontent.com/osrf/ros2_java/issues?q=state%3Aopen%20label%3Aenhancement
Jan 20, 2022https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87#event-5927928743
https://patch-diff.githubusercontent.com/ivanpauno
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
January 20, 2022 20:43https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87#event-5927928750
https://patch-diff.githubusercontent.com/ivanpauno
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
Jan 20, 2022https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87#event-5927928775
https://patch-diff.githubusercontent.com/ivanpauno
Fix indexing errorhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/commits/80ff53dba799f239fef0a5f546fb0b5f8a24656a
80ff53dhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/commits/80ff53dba799f239fef0a5f546fb0b5f8a24656a
https://patch-diff.githubusercontent.com/ivanpauno
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
Jan 21, 2022https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87#issuecomment-1018758451
80ff53dhttps://github.com/osrf/ros2_java/commit/80ff53dba799f239fef0a5f546fb0b5f8a24656a
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
Jan 26, 2022 https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87#pullrequestreview-862707889
View reviewed changes https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/files/80ff53dba799f239fef0a5f546fb0b5f8a24656a
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87#pullrequestreview-862707889
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87
rcljava/include/org_ros2_rcljava_executors_BaseExecutor.hhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/files/80ff53dba799f239fef0a5f546fb0b5f8a24656a#diff-4b2330ba5571a42813111148c4b385e25dbd9520a264e545806819d90d928721
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87
https://patch-diff.githubusercontent.com/ivanpauno
https://patch-diff.githubusercontent.com/jacobperron
Update native method signature in docshttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/commits/3dcc11cc9a6ce714bef66632d8bcb214dd1248e7
3dcc11chttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/commits/3dcc11cc9a6ce714bef66632d8bcb214dd1248e7
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fosrf%2Fros2_java%2Fpull%2F87
https://patch-diff.githubusercontent.com/jacobperron
jacobperron https://patch-diff.githubusercontent.com/jacobperron
https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87/files/80ff53dba799f239fef0a5f546fb0b5f8a24656a
https://patch-diff.githubusercontent.com/ivanpauno
ivanpauno https://patch-diff.githubusercontent.com/ivanpauno
enhancement https://patch-diff.githubusercontent.com/osrf/ros2_java/issues?q=state%3Aopen%20label%3Aenhancement
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/87
https://patch-diff.githubusercontent.com/ivanpauno
https://patch-diff.githubusercontent.com/jacobperron
https://patch-diff.githubusercontent.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.