René's URL Explorer Experiment


Title: Add action server with logic for accepting and canceling goals by jacobperron · Pull Request #53 · osrf/ros2_java · GitHub

Open Graph Title: Add action server with logic for accepting and canceling goals by jacobperron · Pull Request #53 · osrf/ros2_java

X Title: Add action server with logic for accepting and canceling goals by jacobperron · Pull Request #53 · osrf/ros2_java

Description: Depends on #52 This is a partial implementation; trying to keep the diff smaller for review. I'll follow-up with more PRs competing the implementation.

Open Graph Description: Depends on #52 This is a partial implementation; trying to keep the diff smaller for review. I'll follow-up with more PRs competing the implementation.

X Description: Depends on #52 This is a partial implementation; trying to keep the diff smaller for review. I'll follow-up with more PRs competing the implementation.

Opengraph URL: https://github.com/osrf/ros2_java/pull/53

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:59abdcf9-6c2a-e713-b0a1-5d3c8717c1e1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD5C:36DEBA:233D54F:2D9677A:697FD6FE
html-safe-nonce0a1fcdf546bb5653e42a57d01f2a375ffbd9544a1617cbaa821a71e61f49f7e2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDVDOjM2REVCQToyMzNENTRGOjJEOTY3N0E6Njk3RkQ2RkUiLCJ2aXNpdG9yX2lkIjoiOTAzOTIxMjczNTg0OTU1MTYxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7ed822291107e3ae137dd00a74d4bb75a8259b604690924c378a5e4893122a56
hovercard-subject-tagpull_request:520728422
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/osrf/ros2_java/53/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/532dc3f2670855ad82d88f0adfe0d0472ce1cee6ed666da6db1ae1390319a2b6/osrf/ros2_java/pull/53
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/532dc3f2670855ad82d88f0adfe0d0472ce1cee6ed666da6db1ae1390319a2b6/osrf/ros2_java/pull/53
og:image:altDepends on #52 This is a partial implementation; trying to keep the diff smaller for review. I'll follow-up with more PRs competing the implementation.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejacobperron
hostnamegithub.com
expected-hostnamegithub.com
None60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6
turbo-cache-controlno-preview
go-importgithub.com/osrf/ros2_java git https://github.com/osrf/ros2_java.git
octolytics-dimension-user_id3999730
octolytics-dimension-user_loginosrf
octolytics-dimension-repository_id278167259
octolytics-dimension-repository_nwoosrf/ros2_java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id52850323
octolytics-dimension-repository_parent_nworos2-java/ros2_java
octolytics-dimension-repository_network_root_id52850323
octolytics-dimension-repository_network_root_nworos2-java/ros2_java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7c85641c598ad130c74f7bcc27f58575cac69551
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fosrf%2Fros2_java%2Fpull%2F53
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fosrf%2Fros2_java%2Fpull%2F53
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=osrf%2Fros2_java
Reloadhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
Reloadhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
Reloadhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
osrf https://patch-diff.githubusercontent.com/osrf
ros2_javahttps://patch-diff.githubusercontent.com/osrf/ros2_java
ros2-java/ros2_javahttps://patch-diff.githubusercontent.com/ros2-java/ros2_java
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fosrf%2Fros2_java
Fork 9 https://patch-diff.githubusercontent.com/login?return_to=%2Fosrf%2Fros2_java
Star 4 https://patch-diff.githubusercontent.com/login?return_to=%2Fosrf%2Fros2_java
Code https://patch-diff.githubusercontent.com/osrf/ros2_java
Pull requests 2 https://patch-diff.githubusercontent.com/osrf/ros2_java/pulls
Actions https://patch-diff.githubusercontent.com/osrf/ros2_java/actions
Projects 0 https://patch-diff.githubusercontent.com/osrf/ros2_java/projects
Security 0 https://patch-diff.githubusercontent.com/osrf/ros2_java/security
Insights https://patch-diff.githubusercontent.com/osrf/ros2_java/pulse
Code https://patch-diff.githubusercontent.com/osrf/ros2_java
Pull requests https://patch-diff.githubusercontent.com/osrf/ros2_java/pulls
Actions https://patch-diff.githubusercontent.com/osrf/ros2_java/actions
Projects https://patch-diff.githubusercontent.com/osrf/ros2_java/projects
Security https://patch-diff.githubusercontent.com/osrf/ros2_java/security
Insights https://patch-diff.githubusercontent.com/osrf/ros2_java/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fosrf%2Fros2_java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fosrf%2Fros2_java%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#issue-comment-box
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
galactic-develhttps://patch-diff.githubusercontent.com/osrf/ros2_java/tree/galactic-devel
jacob/action_serverhttps://patch-diff.githubusercontent.com/osrf/ros2_java/tree/jacob/action_server
Add action server with logic for accepting and canceling goals https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#top
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
galactic-develhttps://patch-diff.githubusercontent.com/osrf/ros2_java/tree/galactic-devel
jacob/action_serverhttps://patch-diff.githubusercontent.com/osrf/ros2_java/tree/jacob/action_server
Conversation 74 https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
Commits 32 https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits
Checks 0 https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/checks
Files changed https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
Nov 13, 2020https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#issue-742643972
#52https://github.com/osrf/ros2_java/pull/52
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
November 13, 2020 17:39https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#event-3994571932
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
Nov 13, 2020https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#event-3994571975
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
Nov 13, 2020 https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#ref-pullrequest-742641108
Add action interfaces for goal request and goal response #52 https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/52
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
November 16, 2020 18:35https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#event-4001761577
https://patch-diff.githubusercontent.com/ivanpauno
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
Nov 16, 2020 https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#pullrequestreview-531600837
View reviewed changes https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#pullrequestreview-531600837
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/include/org_ros2_rcljava_action_ActionServerImpl.hhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-8a8b3f9bc2f80d15b5089636b2b6d71403e1994242dc9a2e24dfe84f373707c5
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/src/main/cpp/org_ros2_rcljava_action_ActionServerImpl.cpphttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-08a75797b9f07509c3059f4b5af0b477d392f7a67d30c7412e5075ccb55312d2
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/src/main/cpp/org_ros2_rcljava_action_ActionServerImpl.cpphttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-08a75797b9f07509c3059f4b5af0b477d392f7a67d30c7412e5075ccb55312d2
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/src/main/cpp/convert.hpphttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-85b6959180d94d91c9addce72bca70861a8b5f5f92ba0e2444dd311becaf6619
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/src/main/cpp/org_ros2_rcljava_action_ActionServerImpl_GoalHandleImpl.cpphttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-c5498c58ce4df841a5ce978ead62367fde2e3dcb186e051dab139ac479275e7a
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
https://patch-diff.githubusercontent.com/ivanpauno
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
Jan 5, 2021 https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#pullrequestreview-561146990
View reviewed changes https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#pullrequestreview-561146990
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/CMakeLists.txthttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-4f48a02bfcde36562ca555f728634ccbe6a7fe3d9569c2845c661b7ec88ebb95
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/CMakeLists.txthttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-4f48a02bfcde36562ca555f728634ccbe6a7fe3d9569c2845c661b7ec88ebb95
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/CMakeLists.txthttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-4f48a02bfcde36562ca555f728634ccbe6a7fe3d9569c2845c661b7ec88ebb95
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/src/main/java/org/ros2/rcljava/action/ActionServerGoalHandle.javahttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-b72e71a5986085296d5cd68f19e7f1ec03f92a4814cf3d437529bd21d40ea3df
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/src/main/java/org/ros2/rcljava/action/ActionServerGoalHandle.javahttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-b72e71a5986085296d5cd68f19e7f1ec03f92a4814cf3d437529bd21d40ea3df
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/src/main/java/org/ros2/rcljava/action/ActionServerImpl.javahttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-d5e31f2870f8429406fbba4938fc4b68010d87fe52fc848366c921bb97acdc93
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/src/main/java/org/ros2/rcljava/action/CancelCallback.javahttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-a3b96ca1a1aacae8f566f621bbffc05359e149e86b8e9c287851788d2d6fb57b
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/src/main/java/org/ros2/rcljava/action/CancelCallback.javahttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-a3b96ca1a1aacae8f566f621bbffc05359e149e86b8e9c287851788d2d6fb57b
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/src/main/java/org/ros2/rcljava/action/GoalCallback.javahttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-6153a641deb671a7a88397615b3deeab016f446f47336bbf1f6bf6257304c2c2
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/src/main/java/org/ros2/rcljava/action/ActionServerImpl.javahttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-d5e31f2870f8429406fbba4938fc4b68010d87fe52fc848366c921bb97acdc93
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
force-pushedhttps://patch-diff.githubusercontent.com/osrf/ros2_java/compare/0230bb20cb988c85feeb6c1978d71f87d24bb76b..21b194a1a5c5b016c2356b086dc1ea8621483ce4
0230bb2https://patch-diff.githubusercontent.com/osrf/ros2_java/commit/0230bb20cb988c85feeb6c1978d71f87d24bb76b
21b194ahttps://patch-diff.githubusercontent.com/osrf/ros2_java/commit/21b194a1a5c5b016c2356b086dc1ea8621483ce4
Compare https://patch-diff.githubusercontent.com/osrf/ros2_java/compare/0230bb20cb988c85feeb6c1978d71f87d24bb76b..21b194a1a5c5b016c2356b086dc1ea8621483ce4
January 13, 2021 20:16https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#event-4203043052
https://patch-diff.githubusercontent.com/ivanpauno
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
Jan 18, 2021 https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#pullrequestreview-570500165
View reviewed changes https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#pullrequestreview-570500165
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/src/main/cpp/convert.hpphttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-85b6959180d94d91c9addce72bca70861a8b5f5f92ba0e2444dd311becaf6619
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/src/main/cpp/convert.hpphttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-85b6959180d94d91c9addce72bca70861a8b5f5f92ba0e2444dd311becaf6619
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/src/main/java/org/ros2/rcljava/executors/BaseExecutor.javahttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-f575b3e4d253d9d5c03ac4fe0c389a3f9ad4d2f67203cf9c85f7fa4577c4caf6
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
rcljava/src/main/java/org/ros2/rcljava/node/Node.javahttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files#diff-9f5bf036be2b893d8b72c636659af84f6439f3d0d372af4816022e7bab14a40a
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
January 20, 2021 11:06https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#commits-pushed-4a5d229
https://patch-diff.githubusercontent.com/jacobperron
Add interfaces for action goal, result, and feedbackhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/4a5d229fecdb74d87a18322dc16ae5a20cdfef4a
4a5d229https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/4a5d229fecdb74d87a18322dc16ae5a20cdfef4a
https://patch-diff.githubusercontent.com/jacobperron
Add new definitions for action goal response and requesthttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/768b6d470200dad2aa5946a465d941b56dc091d0
768b6d4https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/768b6d470200dad2aa5946a465d941b56dc091d0
https://patch-diff.githubusercontent.com/jacobperron
Add getter for UUID to SendGoalRequesthttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/bdecfa7aef77d5013c6b42f91bd354b7d2e50396
bdecfa7https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/bdecfa7aef77d5013c6b42f91bd354b7d2e50396
https://patch-diff.githubusercontent.com/jacobperron
Add getStamp method to GoalResponseDefinitionhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/1b65d7fd91a95cd7e112c33d1f4ea8f2312a6bb6
1b65d7fhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/1b65d7fd91a95cd7e112c33d1f4ea8f2312a6bb6
https://patch-diff.githubusercontent.com/jacobperron
Partially revert "Add interfaces for action goal, result, and feedback"https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/b725144feda52eadff2e1d8b46d995bab12d0298
b725144https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/b725144feda52eadff2e1d8b46d995bab12d0298
dd04614https://github.com/osrf/ros2_java/commit/dd046147d38c1aa844376149f62c4f3aaec04d96
https://patch-diff.githubusercontent.com/jacobperron
Parameterize goal request and response interfaces on action typehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/f7d7f557acc63f05804a33daaa212e13090bb208
f7d7f55https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/f7d7f557acc63f05804a33daaa212e13090bb208
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
force-pushedhttps://patch-diff.githubusercontent.com/osrf/ros2_java/compare/492496557172241dd38db10bb36fbf85e1c2846b..f7d7f557acc63f05804a33daaa212e13090bb208
4924965https://patch-diff.githubusercontent.com/osrf/ros2_java/commit/492496557172241dd38db10bb36fbf85e1c2846b
f7d7f55https://patch-diff.githubusercontent.com/osrf/ros2_java/commit/f7d7f557acc63f05804a33daaa212e13090bb208
Compare https://patch-diff.githubusercontent.com/osrf/ros2_java/compare/492496557172241dd38db10bb36fbf85e1c2846b..f7d7f557acc63f05804a33daaa212e13090bb208
January 20, 2021 19:06https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#event-4229504294
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
January 20, 2021 11:55https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#commits-pushed-7a6a47f
https://patch-diff.githubusercontent.com/jacobperron
Fix getGoalUuid implementationhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/7a6a47f645c5afedbb39b760c0ec685dfcb0b5ef
7a6a47fhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/7a6a47f645c5afedbb39b760c0ec685dfcb0b5ef
https://patch-diff.githubusercontent.com/jacobperron
List -> byte[]https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/63200b3af16a1afd3d01f69e868b8524e4db5851
63200b3https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/63200b3af16a1afd3d01f69e868b8524e4db5851
https://patch-diff.githubusercontent.com/jacobperron
Add ActionServer skeletonhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/cd347890b9809d4a100aa30696db0b8edac2102d
cd34789https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/cd347890b9809d4a100aa30696db0b8edac2102d
https://patch-diff.githubusercontent.com/jacobperron
Add ActionServer creation logic and unit testshttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/f988e401674b723ad74dbb92b8a25f06f5ece5e4
f988e40https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/f988e401674b723ad74dbb92b8a25f06f5ece5e4
https://patch-diff.githubusercontent.com/jacobperron
Add action server logic for accepting and canceling goalshttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/676fcae11dee0f01eae1c897c586b7769040b4bd
676fcaehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/676fcae11dee0f01eae1c897c586b7769040b4bd
https://patch-diff.githubusercontent.com/jacobperron
cleanuphttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/0494903042df03e7c982da8e35a3cbb5579bbfbd
0494903https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/0494903042df03e7c982da8e35a3cbb5579bbfbd
https://patch-diff.githubusercontent.com/jacobperron
more cleanuphttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/5a50ddcf484c108a4d77ba0f9352ca6a71246623
5a50ddchttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/5a50ddcf484c108a4d77ba0f9352ca6a71246623
https://patch-diff.githubusercontent.com/jacobperron
Minor refactor: move response enums into callback interfaceshttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/af943df368093c92d81e08e29a585c4a0460d10b
af943dfhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/af943df368093c92d81e08e29a585c4a0460d10b
https://patch-diff.githubusercontent.com/jacobperron
Remove TODOhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/7929ece50dbc06845cbff4b1521e8cb1755aab2a
7929ecehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/7929ece50dbc06845cbff4b1521e8cb1755aab2a
https://patch-diff.githubusercontent.com/jacobperron
Fix accidenthttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/98fd96f67ac5a8b997a8badba792bd42b4bd004a
98fd96fhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/98fd96f67ac5a8b997a8badba792bd42b4bd004a
https://patch-diff.githubusercontent.com/jacobperron
Alphabetizehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/1a3403866121c6475e0202fbc7a2d1e91c259a96
1a34038https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/1a3403866121c6475e0202fbc7a2d1e91c259a96
https://patch-diff.githubusercontent.com/jacobperron
Refactor: replace 'getNumberOf*()' JNI functions with single 'getNumb…https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/08d180a911c93a2135e225ce27936edd6ed56008
08d180ahttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/08d180a911c93a2135e225ce27936edd6ed56008
https://patch-diff.githubusercontent.com/jacobperron
Avoid string copyhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/ac784b3d9c9825ffdf30497bbacb58b5ae28d2ad
ac784b3https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/ac784b3d9c9825ffdf30497bbacb58b5ae28d2ad
https://patch-diff.githubusercontent.com/jacobperron
Remove extern Chttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/d61317534816c92a051a97a9638bfc2d30fc9550
d613175https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/d61317534816c92a051a97a9638bfc2d30fc9550
https://patch-diff.githubusercontent.com/jacobperron
Remove unnecessary synchronizationhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/ed684b12201ed579259d8356cad93e6e25634a60
ed684b1https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/ed684b12201ed579259d8356cad93e6e25634a60
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
January 20, 2021 11:56https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#commits-pushed-f2de762
https://patch-diff.githubusercontent.com/jacobperron
Refactor access to goalCallbackhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/f2de7627cebd7c19447be5c2f2d03afbb4db2c8b
f2de762https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/f2de7627cebd7c19447be5c2f2d03afbb4db2c8b
https://patch-diff.githubusercontent.com/jacobperron
typesafe request and response definitionshttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/11b107e2cd0d5258efeba326da82789544da514b
11b107ehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/11b107e2cd0d5258efeba326da82789544da514b
https://patch-diff.githubusercontent.com/jacobperron
Be more specific about template type for GoalCallbackhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/6203cead13af7973abbfdab409d6a6c25c809058
6203ceahttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/6203cead13af7973abbfdab409d6a6c25c809058
https://patch-diff.githubusercontent.com/jacobperron
Minor refactorhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/5e4693ad1472d96b3c1eed4de4d31ba35b11dc3d
5e4693ahttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/5e4693ad1472d96b3c1eed4de4d31ba35b11dc3d
https://patch-diff.githubusercontent.com/jacobperron
Make GoalHandleImpl inner class instead of statichttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/9c93a03be4f5ff0a1ac024cfd05645f788b243c3
9c93a03https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/9c93a03be4f5ff0a1ac024cfd05645f788b243c3
https://patch-diff.githubusercontent.com/jacobperron
Remove synchronized from getHandlehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/f6dbc953cdb793ad4a9732aa772b6fb893503c0c
f6dbc95https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/f6dbc953cdb793ad4a9732aa772b6fb893503c0c
https://patch-diff.githubusercontent.com/jacobperron
Add TODO for Waitable interfacehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/c652771557d7fcf3809f64b243898af79f89d51c
c652771https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/c652771557d7fcf3809f64b243898af79f89d51c
https://patch-diff.githubusercontent.com/jacobperron
Fix stylehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/59b2d2464ea4b1cba309599a6410cde808cf1920
59b2d24https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/59b2d2464ea4b1cba309599a6410cde808cf1920
https://patch-diff.githubusercontent.com/jacobperron
Minor refactorhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/b4b79229437ebb5e20e74fb3cfe9df1612435565
b4b7922https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/b4b79229437ebb5e20e74fb3cfe9df1612435565
https://patch-diff.githubusercontent.com/jacobperron
Add docs for createActionServerhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/6014fad407d9f11ab7c6eada9c1e142da3cfa26d
6014fadhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/6014fad407d9f11ab7c6eada9c1e142da3cfa26d
https://patch-diff.githubusercontent.com/jacobperron
Switch from List to arrayhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/f94150b1a8a9bbf87e299471f3c632acca4e9b6e
f94150bhttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/commits/f94150b1a8a9bbf87e299471f3c632acca4e9b6e
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
force-pushedhttps://patch-diff.githubusercontent.com/osrf/ros2_java/compare/6fe23e6423821671b29e26cfd29fc2e527fcd7d2..f94150b1a8a9bbf87e299471f3c632acca4e9b6e
6fe23e6https://patch-diff.githubusercontent.com/osrf/ros2_java/commit/6fe23e6423821671b29e26cfd29fc2e527fcd7d2
f94150bhttps://patch-diff.githubusercontent.com/osrf/ros2_java/commit/f94150b1a8a9bbf87e299471f3c632acca4e9b6e
Compare https://patch-diff.githubusercontent.com/osrf/ros2_java/compare/6fe23e6423821671b29e26cfd29fc2e527fcd7d2..f94150b1a8a9bbf87e299471f3c632acca4e9b6e
January 20, 2021 20:42https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#event-4229869439
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
Jan 20, 2021https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#issuecomment-763920968
@ivanpaunohttps://github.com/ivanpauno
f94150bhttps://github.com/osrf/ros2_java/commit/f94150b1a8a9bbf87e299471f3c632acca4e9b6e
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
January 20, 2021 21:02https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#event-4229941451
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
January 20, 2021 21:49https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#event-4230139452
https://patch-diff.githubusercontent.com/ivanpauno
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
Jan 21, 2021 https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#pullrequestreview-573306088
View reviewed changes https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files/f94150b1a8a9bbf87e299471f3c632acca4e9b6e
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#pullrequestreview-573306088
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
af0ba27https://patch-diff.githubusercontent.com/osrf/ros2_java/commit/af0ba277e26a5ce7c9a2ba9464616f473d4931a8
Jan 21, 2021https://github.com/osrf/ros2_java/pull/53#event-4234916752
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
January 21, 2021 18:08https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#event-4234917035
ivanpaunohttps://patch-diff.githubusercontent.com/ivanpauno
May 17, 2021 https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#ref-commit-187e661
https://patch-diff.githubusercontent.com/jacobperron
https://patch-diff.githubusercontent.com/ivanpauno
Add action server with logic for accepting and canceling goals (https://patch-diff.githubusercontent.com/osrf/ros2_java/commit/187e6614632f98d8395d1d7978d7a3deca4fd8ee
#53https://github.com/osrf/ros2_java/pull/53
)https://patch-diff.githubusercontent.com/osrf/ros2_java/commit/187e6614632f98d8395d1d7978d7a3deca4fd8ee
187e661https://patch-diff.githubusercontent.com/osrf/ros2_java/commit/187e6614632f98d8395d1d7978d7a3deca4fd8ee
dd04614https://github.com/osrf/ros2_java/commit/dd046147d38c1aa844376149f62c4f3aaec04d96
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
May 17, 2022 https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53#ref-commit-d2ea45d
https://patch-diff.githubusercontent.com/jacobperron
Add action server with logic for accepting and canceling goals (https://patch-diff.githubusercontent.com/ros2-java/ros2_java/commit/d2ea45d985dae4e3bb68559284a5191a24f2be37
osrf#53https://github.com/osrf/ros2_java/pull/53
)https://patch-diff.githubusercontent.com/ros2-java/ros2_java/commit/d2ea45d985dae4e3bb68559284a5191a24f2be37
d2ea45dhttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/commit/d2ea45d985dae4e3bb68559284a5191a24f2be37
dd04614https://github.com/ros2-java/ros2_java/commit/dd046147d38c1aa844376149f62c4f3aaec04d96
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fosrf%2Fros2_java%2Fpull%2F53
https://patch-diff.githubusercontent.com/ivanpauno
ivanpauno https://patch-diff.githubusercontent.com/ivanpauno
https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53/files/f94150b1a8a9bbf87e299471f3c632acca4e9b6e
https://patch-diff.githubusercontent.com/jacobperron
jacobperron https://patch-diff.githubusercontent.com/jacobperron
Please reload this pagehttps://patch-diff.githubusercontent.com/osrf/ros2_java/pull/53
https://patch-diff.githubusercontent.com/jacobperron
https://patch-diff.githubusercontent.com/ivanpauno
https://patch-diff.githubusercontent.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.