| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0d83299f-0d57-9a48-67f4-b7422f4e9569 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BAA6:1D96F5:64D99:8336D:698E98C9 |
| html-safe-nonce | e0ce191768013124c029decbbf700f6c76277064607a03c3bcb506784f351b56 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUE2OjFEOTZGNTo2NEQ5OTo4MzM2RDo2OThFOThDOSIsInZpc2l0b3JfaWQiOiI4NTQ3MDk0MDk0NTg0NjQ5OTI5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e408b2b102e1a638d48adcb936d7f2324bd3a28ae66f30dd0955c4c9bd68ffe6 |
| hovercard-subject-tag | pull_request:3063627363 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/openzim/python-scraperlib/273/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6ff4eb93874ba2c2f157f9acafabcb467523a7b7fc8dda06112b9e2df608f226/openzim/python-scraperlib/pull/273 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6ff4eb93874ba2c2f157f9acafabcb467523a7b7fc8dda06112b9e2df608f226/openzim/python-scraperlib/pull/273 |
| og:image:alt | Type hints could be more precise thanks to @overload python feature (see https://typing.python.org/en/latest/spec/overload.html) |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | benoit74 |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb2828a801ee6b7be618f3ac76fbf55def35bbc30f053a9c41bf90210b8b72ba |
| turbo-cache-control | no-preview |
| go-import | github.com/openzim/python-scraperlib git https://github.com/openzim/python-scraperlib.git |
| octolytics-dimension-user_id | 26540839 |
| octolytics-dimension-user_login | openzim |
| octolytics-dimension-repository_id | 237924365 |
| octolytics-dimension-repository_nwo | openzim/python-scraperlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 237924365 |
| octolytics-dimension-repository_network_root_nwo | openzim/python-scraperlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6b91a7e6e46287d26887e3fb7a4161657bab8f7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenzim%2Fpython-scraperlib%2Fpull%2F273 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenzim%2Fpython-scraperlib%2Fpull%2F273 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=openzim%2Fpython-scraperlib |
| Reload | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273 |
| Reload | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273 |
| Reload | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273 |
|
openzim
| https://patch-diff.githubusercontent.com/openzim |
| python-scraperlib | https://patch-diff.githubusercontent.com/openzim/python-scraperlib |
| Please reload this page | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273 |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fopenzim%2Fpython-scraperlib |
|
Fork
19
| https://patch-diff.githubusercontent.com/login?return_to=%2Fopenzim%2Fpython-scraperlib |
|
Star
25
| https://patch-diff.githubusercontent.com/login?return_to=%2Fopenzim%2Fpython-scraperlib |
|
Code
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib |
|
Issues
21
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/issues |
|
Pull requests
4
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/wiki |
|
Security
0
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/security |
|
Insights
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pulse |
|
Code
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib |
|
Issues
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/actions |
|
Projects
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/wiki |
|
Security
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/security |
|
Insights
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Fopenzim%2Fpython-scraperlib%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Fopenzim%2Fpython-scraperlib%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273#issue-comment-box |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| main | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/tree/main |
| add_overloads | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/tree/add_overloads |
|
Add proper typing @overload to zimscraperlib.image.optimize_xxx methods
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273#top |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| main | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/tree/main |
| add_overloads | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/tree/add_overloads |
|
Conversation
4
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273 |
|
Commits
1
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273/commits |
|
Checks
9
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273/files |
| Please reload this page | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/benoit74 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| Dec 2, 2025 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273#issue-3685915278 |
| https://typing.python.org/en/latest/spec/overload.html | https://typing.python.org/en/latest/spec/overload.html |
| Please reload this page | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273 |
| https://patch-diff.githubusercontent.com/benoit74 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| Dec 2, 2025 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273#event-21306369417 |
| https://patch-diff.githubusercontent.com/apps/codecov |
| codecov | https://patch-diff.githubusercontent.com/apps/codecov |
| Dec 2, 2025 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273#issuecomment-3602146491 |
| Please reload this page | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273 |
| Codecov | https://app.codecov.io/gh/openzim/python-scraperlib/pull/273?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim |
| 26e3ab1 | https://app.codecov.io/gh/openzim/python-scraperlib/commit/26e3ab16e8f6d82c5d0723dfcaf09fe9f23663b6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim |
| 1893e14 | https://app.codecov.io/gh/openzim/python-scraperlib/commit/1893e14d1021c56047b597ad333f46d855fa51be?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim |
| Files with missing lines | https://app.codecov.io/gh/openzim/python-scraperlib/pull/273?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim |
| src/zimscraperlib/image/optimization.py | https://app.codecov.io/gh/openzim/python-scraperlib/pull/273?src=pr&el=tree&filepath=src%2Fzimscraperlib%2Fimage%2Foptimization.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim#diff-c3JjL3ppbXNjcmFwZXJsaWIvaW1hZ2Uvb3B0aW1pemF0aW9uLnB5 |
| 6 Missing ⚠️ | https://app.codecov.io/gh/openzim/python-scraperlib/pull/273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim |
| ☔ View full report in Codecov by Sentry | https://app.codecov.io/gh/openzim/python-scraperlib/pull/273?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim |
| Share it here | https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim |
| Test Analytics | https://docs.codecov.com/docs/test-analytics |
| JS Bundle Analysis | https://docs.codecov.com/docs/javascript-bundle-analysis |
| Please reload this page | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273 |
| https://patch-diff.githubusercontent.com/benoit74 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| rgaudin | https://patch-diff.githubusercontent.com/rgaudin |
| December 2, 2025 13:54 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273#event-21306744986 |
| https://patch-diff.githubusercontent.com/benoit74 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| 5.4.0 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/milestone/16 |
| Dec 2, 2025 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273#event-21306746666 |
| https://patch-diff.githubusercontent.com/rgaudin |
| rgaudin | https://patch-diff.githubusercontent.com/rgaudin |
|
Dec 2, 2025
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273#pullrequestreview-3530290577 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273/files |
| rgaudin | https://patch-diff.githubusercontent.com/rgaudin |
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273#pullrequestreview-3530290577 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273 |
|
| https://patch-diff.githubusercontent.com/benoit74 |
| Add proper typing | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273/commits/1893e14d1021c56047b597ad333f46d855fa51be |
| @overload | https://github.com/overload |
| to methods | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273/commits/1893e14d1021c56047b597ad333f46d855fa51be |
| 1893e14 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273/commits/1893e14d1021c56047b597ad333f46d855fa51be |
| https://patch-diff.githubusercontent.com/benoit74 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| force-pushed | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/compare/b85376395eb4f340a8f758aa594f81cbf068e6a2..1893e14d1021c56047b597ad333f46d855fa51be |
| b853763 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/commit/b85376395eb4f340a8f758aa594f81cbf068e6a2 |
| 1893e14 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/commit/1893e14d1021c56047b597ad333f46d855fa51be |
|
Compare
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/compare/b85376395eb4f340a8f758aa594f81cbf068e6a2..1893e14d1021c56047b597ad333f46d855fa51be |
| December 2, 2025 14:46 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273#event-21308016512 |
| https://patch-diff.githubusercontent.com/benoit74 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| Dec 2, 2025 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273#issuecomment-3602421667 |
| Please reload this page | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273 |
| https://patch-diff.githubusercontent.com/benoit74 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| Dec 2, 2025 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273#issuecomment-3602432519 |
| Please reload this page | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273 |
| https://patch-diff.githubusercontent.com/benoit74 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| 9904777 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/commit/99047776f5998ef4244a78afb5499e2c23890c70 |
| Dec 2, 2025 | https://github.com/openzim/python-scraperlib/pull/273#event-21308099612 |
| Please reload this page | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273 |
| https://patch-diff.githubusercontent.com/benoit74 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| December 2, 2025 14:49 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273#event-21308100457 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenzim%2Fpython-scraperlib%2Fpull%2F273 |
|
| https://patch-diff.githubusercontent.com/rgaudin |
|
rgaudin
| https://patch-diff.githubusercontent.com/rgaudin |
|
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273/files/b85376395eb4f340a8f758aa594f81cbf068e6a2 |
|
| https://patch-diff.githubusercontent.com/benoit74 |
|
benoit74
| https://patch-diff.githubusercontent.com/benoit74 |
|
5.4.0
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/milestone/16 |
| Please reload this page | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/273 |
|
| https://patch-diff.githubusercontent.com/benoit74 |
|
| https://patch-diff.githubusercontent.com/rgaudin |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |