| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c1517126-1618-5089-d915-0b277d13abef |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CE94:113E66:131D66F:185715F:6990D66C |
| html-safe-nonce | c80fcc61b3cf74c1eb0baa23d817b50eaeabfb8f3b67dd2a8ffd3e0a095c11e4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTk0OjExM0U2NjoxMzFENjZGOjE4NTcxNUY6Njk5MEQ2NkMiLCJ2aXNpdG9yX2lkIjoiNzIzOTYzNzU0MDY1OTA1ODI4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 31bd710eab790fde86f9c323e32e9ebc20fb98dc9220421b4ceee2cc0a803ac7 |
| hovercard-subject-tag | pull_request:2169266336 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/openzim/python-scraperlib/213/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f2335c32444d707db4cafdd90550b9ade74c97b71a79e68d88770bb7d7f2f33f/openzim/python-scraperlib/pull/213 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f2335c32444d707db4cafdd90550b9ade74c97b71a79e68d88770bb7d7f2f33f/openzim/python-scraperlib/pull/213 |
| og:image:alt | Very simplified version of #211 since for now decided not to include an executor but rely on joblib (or another parallel processing lib) for now.
Changes:
fix few type hints to be more precise
add... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | benoit74 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/openzim/python-scraperlib git https://github.com/openzim/python-scraperlib.git |
| octolytics-dimension-user_id | 26540839 |
| octolytics-dimension-user_login | openzim |
| octolytics-dimension-repository_id | 237924365 |
| octolytics-dimension-repository_nwo | openzim/python-scraperlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 237924365 |
| octolytics-dimension-repository_network_root_nwo | openzim/python-scraperlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenzim%2Fpython-scraperlib%2Fpull%2F213 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenzim%2Fpython-scraperlib%2Fpull%2F213 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=openzim%2Fpython-scraperlib |
| Reload | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213 |
| Reload | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213 |
| Reload | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213 |
|
openzim
| https://patch-diff.githubusercontent.com/openzim |
| python-scraperlib | https://patch-diff.githubusercontent.com/openzim/python-scraperlib |
| Please reload this page | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213 |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fopenzim%2Fpython-scraperlib |
|
Fork
19
| https://patch-diff.githubusercontent.com/login?return_to=%2Fopenzim%2Fpython-scraperlib |
|
Star
25
| https://patch-diff.githubusercontent.com/login?return_to=%2Fopenzim%2Fpython-scraperlib |
|
Code
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib |
|
Issues
21
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/issues |
|
Pull requests
4
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/wiki |
|
Security
0
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/security |
|
Insights
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pulse |
|
Code
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib |
|
Issues
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/actions |
|
Projects
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/wiki |
|
Security
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/security |
|
Insights
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pulse |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| main | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/tree/main |
| small_changes | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/tree/small_changes |
| Conversation | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213 |
| Commits2 (2) | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213/commits |
| Checks | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213/checks |
| Files changed | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213/files |
| Small changes for mindtouch | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213#top |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| main | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/tree/main |
| small_changes | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/tree/small_changes |
|
| https://patch-diff.githubusercontent.com/benoit74 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| Nov 8, 2024 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213#issue-2643545910 |
| Please reload this page | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213 |
| #211 | https://github.com/openzim/python-scraperlib/pull/211 |
| Please reload this page | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| November 8, 2024 10:06 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213#commits-pushed-e57f6de |
|
| https://patch-diff.githubusercontent.com/benoit74 |
| Fix typing | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213/commits/e57f6ded52a601b9a4dbfbf51d7850609d9c47a3 |
| e57f6de | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213/commits/e57f6ded52a601b9a4dbfbf51d7850609d9c47a3 |
|
| https://patch-diff.githubusercontent.com/benoit74 |
| Add standard log format displaying thread name | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213/commits/f5f04123088defd01c75e80325f493bc76cade89 |
| f5f0412 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213/commits/f5f04123088defd01c75e80325f493bc76cade89 |
| https://patch-diff.githubusercontent.com/benoit74 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| Nov 8, 2024 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213#event-15209519146 |
| https://patch-diff.githubusercontent.com/benoit74 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| Nov 8, 2024 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213#event-15209524643 |
| https://patch-diff.githubusercontent.com/apps/codecov |
| codecov | https://patch-diff.githubusercontent.com/apps/codecov |
| Nov 8, 2024 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213#issuecomment-2464312377 |
| Please reload this page | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213 |
| Codecov | https://app.codecov.io/gh/openzim/python-scraperlib/pull/213?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim |
| (7b41b04) | https://app.codecov.io/gh/openzim/python-scraperlib/commit/7b41b049ec2a6499b1844f217046ac7a02851405?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim |
| (f5f0412) | https://app.codecov.io/gh/openzim/python-scraperlib/commit/f5f04123088defd01c75e80325f493bc76cade89?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim |
| ☔ View full report in Codecov by Sentry | https://app.codecov.io/gh/openzim/python-scraperlib/pull/213?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim |
| Share it here | https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim |
| Please reload this page | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213 |
| https://patch-diff.githubusercontent.com/benoit74 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| November 8, 2024 13:05 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213#event-15215302891 |
| https://patch-diff.githubusercontent.com/benoit74 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| rgaudin | https://patch-diff.githubusercontent.com/rgaudin |
| November 8, 2024 13:06 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213#event-15215311609 |
| https://patch-diff.githubusercontent.com/rgaudin |
| rgaudin | https://patch-diff.githubusercontent.com/rgaudin |
|
Nov 8, 2024
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213#pullrequestreview-2423979935 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213/files/f5f04123088defd01c75e80325f493bc76cade89 |
| https://patch-diff.githubusercontent.com/benoit74 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| e89899c | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/commit/e89899c6a8dbb551d286e887dbbc358b482f2f84 |
| Nov 8, 2024 | https://github.com/openzim/python-scraperlib/pull/213#event-15217539703 |
| https://patch-diff.githubusercontent.com/benoit74 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| November 8, 2024 14:55 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213#event-15217540355 |
| https://patch-diff.githubusercontent.com/benoit74 |
| benoit74 | https://patch-diff.githubusercontent.com/benoit74 |
| 5.0.0 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/milestone/10 |
| Nov 8, 2024 | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213#event-15217568458 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenzim%2Fpython-scraperlib%2Fpull%2F213 |
|
| https://patch-diff.githubusercontent.com/rgaudin |
|
rgaudin
| https://patch-diff.githubusercontent.com/rgaudin |
|
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213/files/f5f04123088defd01c75e80325f493bc76cade89 |
|
| https://patch-diff.githubusercontent.com/benoit74 |
|
benoit74
| https://patch-diff.githubusercontent.com/benoit74 |
|
5.0.0
| https://patch-diff.githubusercontent.com/openzim/python-scraperlib/milestone/10 |
| Please reload this page | https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pull/213 |
|
| https://patch-diff.githubusercontent.com/benoit74 |
|
| https://patch-diff.githubusercontent.com/rgaudin |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |