René's URL Explorer Experiment


Title: [next major] Do not shadow Python standard-library module · Issue #246 · openzim/python-scraperlib · GitHub

Open Graph Title: [next major] Do not shadow Python standard-library module · Issue #246 · openzim/python-scraperlib

X Title: [next major] Do not shadow Python standard-library module · Issue #246 · openzim/python-scraperlib

Description: Ruff / Flake8 has a new rule A005: https://docs.astral.sh/ruff/rules/stdlib-module-shadowing/ It is recommended to not shadow Python standard-library modules. Currently, we have 5 issues: src/zimscraperlib/html.py:1:1: A005 Module `html`...

Open Graph Description: Ruff / Flake8 has a new rule A005: https://docs.astral.sh/ruff/rules/stdlib-module-shadowing/ It is recommended to not shadow Python standard-library modules. Currently, we have 5 issues: src/zimsc...

X Description: Ruff / Flake8 has a new rule A005: https://docs.astral.sh/ruff/rules/stdlib-module-shadowing/ It is recommended to not shadow Python standard-library modules. Currently, we have 5 issues: src/zimsc...

Opengraph URL: https://github.com/openzim/python-scraperlib/issues/246

X: @github

direct link

Domain: patch-diff.githubusercontent.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[next major] Do not shadow Python standard-library module","articleBody":"Ruff / Flake8 has a new rule `A005`: https://docs.astral.sh/ruff/rules/stdlib-module-shadowing/\n\nIt is recommended to not shadow Python standard-library modules.\n\nCurrently, we have 5 issues:\n\n```\nsrc/zimscraperlib/html.py:1:1: A005 Module `html` shadows a Python standard-library module\nsrc/zimscraperlib/logging.py:1:1: A005 Module `logging` shadows a Python standard-library module\nsrc/zimscraperlib/rewriting/html.py:1:1: A005 Module `html` shadows a Python standard-library module\nsrc/zimscraperlib/types.py:1:1: A005 Module `types` shadows a Python standard-library module\nsrc/zimscraperlib/typing.py:1:1: A005 Module `typing` shadows a Python standard-library module\n```\n\nFor now, I've disabled the rule `A005` in https://github.com/openzim/python-scraperlib/pull/245 but we need to make a finer decision.\n\nI think that `logging` module is shadowing \"on-purpose\" and might be allowed. Others could be considered for renaming. But I don't have very good suggestions of names, so I'm not 100% convinced, if we end-up with bad names, I'm not sure it really ease maintenance at all.","author":{"url":"https://github.com/benoit74","@type":"Person","name":"benoit74"},"datePublished":"2025-01-20T08:16:43.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/246/python-scraperlib/issues/246"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:b68d7567-ed13-35d2-d795-a76354a29cd7
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9E54:38B840:53899B:6BEF3F:698EAB9C
html-safe-nonce16995ff47a1a7939ca6bde61d60a925017732dcad2438ac47f943756b5e0964f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTU0OjM4Qjg0MDo1Mzg5OUI6NkJFRjNGOjY5OEVBQjlDIiwidmlzaXRvcl9pZCI6IjQ4NzkxMTE2OTA3MzIzNTAzNjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb2af22242a5433eab9f305e29c4aeaaf2ae11bd8a3f8d619155b3067776ddac6
hovercard-subject-tagissue:2798532770
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openzim/python-scraperlib/246/issue_layout
twitter:imagehttps://opengraph.githubassets.com/68bb4f7c4351e5b04fdbf7228f896d26692218214679d03436210b3aade4ae3c/openzim/python-scraperlib/issues/246
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/68bb4f7c4351e5b04fdbf7228f896d26692218214679d03436210b3aade4ae3c/openzim/python-scraperlib/issues/246
og:image:altRuff / Flake8 has a new rule A005: https://docs.astral.sh/ruff/rules/stdlib-module-shadowing/ It is recommended to not shadow Python standard-library modules. Currently, we have 5 issues: src/zimsc...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebenoit74
hostnamegithub.com
expected-hostnamegithub.com
Nonecb2828a801ee6b7be618f3ac76fbf55def35bbc30f053a9c41bf90210b8b72ba
turbo-cache-controlno-preview
go-importgithub.com/openzim/python-scraperlib git https://github.com/openzim/python-scraperlib.git
octolytics-dimension-user_id26540839
octolytics-dimension-user_loginopenzim
octolytics-dimension-repository_id237924365
octolytics-dimension-repository_nwoopenzim/python-scraperlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id237924365
octolytics-dimension-repository_network_root_nwoopenzim/python-scraperlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6b91a7e6e46287d26887e3fb7a4161657bab8f7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/openzim/python-scraperlib/issues/246#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenzim%2Fpython-scraperlib%2Fissues%2F246
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenzim%2Fpython-scraperlib%2Fissues%2F246
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=openzim%2Fpython-scraperlib
Reloadhttps://patch-diff.githubusercontent.com/openzim/python-scraperlib/issues/246
Reloadhttps://patch-diff.githubusercontent.com/openzim/python-scraperlib/issues/246
Reloadhttps://patch-diff.githubusercontent.com/openzim/python-scraperlib/issues/246
openzim https://patch-diff.githubusercontent.com/openzim
python-scraperlibhttps://patch-diff.githubusercontent.com/openzim/python-scraperlib
Please reload this pagehttps://patch-diff.githubusercontent.com/openzim/python-scraperlib/issues/246
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fopenzim%2Fpython-scraperlib
Fork 19 https://patch-diff.githubusercontent.com/login?return_to=%2Fopenzim%2Fpython-scraperlib
Star 25 https://patch-diff.githubusercontent.com/login?return_to=%2Fopenzim%2Fpython-scraperlib
Code https://patch-diff.githubusercontent.com/openzim/python-scraperlib
Issues 21 https://patch-diff.githubusercontent.com/openzim/python-scraperlib/issues
Pull requests 4 https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pulls
Actions https://patch-diff.githubusercontent.com/openzim/python-scraperlib/actions
Projects 0 https://patch-diff.githubusercontent.com/openzim/python-scraperlib/projects
Wiki https://patch-diff.githubusercontent.com/openzim/python-scraperlib/wiki
Security 0 https://patch-diff.githubusercontent.com/openzim/python-scraperlib/security
Insights https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pulse
Code https://patch-diff.githubusercontent.com/openzim/python-scraperlib
Issues https://patch-diff.githubusercontent.com/openzim/python-scraperlib/issues
Pull requests https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pulls
Actions https://patch-diff.githubusercontent.com/openzim/python-scraperlib/actions
Projects https://patch-diff.githubusercontent.com/openzim/python-scraperlib/projects
Wiki https://patch-diff.githubusercontent.com/openzim/python-scraperlib/wiki
Security https://patch-diff.githubusercontent.com/openzim/python-scraperlib/security
Insights https://patch-diff.githubusercontent.com/openzim/python-scraperlib/pulse
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/openzim/python-scraperlib/issues/246
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/openzim/python-scraperlib/issues/246
[next major] Do not shadow Python standard-library modulehttps://patch-diff.githubusercontent.com/openzim/python-scraperlib/issues/246#top
https://patch-diff.githubusercontent.com/benoit74
enhancementNew feature or requesthttps://github.com/openzim/python-scraperlib/issues?q=state%3Aopen%20label%3A%22enhancement%22
6.0.0https://github.com/openzim/python-scraperlib/milestone/12
https://github.com/benoit74
https://github.com/benoit74
benoit74https://github.com/benoit74
on Jan 20, 2025https://github.com/openzim/python-scraperlib/issues/246#issue-2798532770
https://docs.astral.sh/ruff/rules/stdlib-module-shadowing/https://docs.astral.sh/ruff/rules/stdlib-module-shadowing/
#245https://github.com/openzim/python-scraperlib/pull/245
benoit74https://patch-diff.githubusercontent.com/benoit74
enhancementNew feature or requesthttps://github.com/openzim/python-scraperlib/issues?q=state%3Aopen%20label%3A%22enhancement%22
6.0.0No due datehttps://github.com/openzim/python-scraperlib/milestone/12
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.