René's URL Explorer Experiment


Title: fix logic for merging object schemas within a property by eli-bl · Pull Request #1159 · openapi-generators/openapi-python-client · GitHub

Open Graph Title: fix logic for merging object schemas within a property by eli-bl · Pull Request #1159 · openapi-generators/openapi-python-client

X Title: fix logic for merging object schemas within a property by eli-bl · Pull Request #1159 · openapi-generators/openapi-python-client

Description: Fixes #1123. Details are as described in the changeset. This is a breaking change only in cases where the previous logic was producing an unambiguously wrong result. That is, in the example shown in the changeset, any code that had previously relied on ModelB.result being an instance of BaseResult rather than ExtendedResult would now fail.

Open Graph Description: Fixes #1123. Details are as described in the changeset. This is a breaking change only in cases where the previous logic was producing an unambiguously wrong result. That is, in the example shown i...

X Description: Fixes #1123. Details are as described in the changeset. This is a breaking change only in cases where the previous logic was producing an unambiguously wrong result. That is, in the example shown i...

Opengraph URL: https://github.com/openapi-generators/openapi-python-client/pull/1159

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c79dff5c-634e-308b-37b2-05330972eb17
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB9C4:3FE7A:4952C:668C4:6980FA3F
html-safe-nonce637a7e98e6e2247f3e4a60aacb8b6cdc43943b245cf5b049853a38d3f2a7aa49
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUM0OjNGRTdBOjQ5NTJDOjY2OEM0OjY5ODBGQTNGIiwidmlzaXRvcl9pZCI6IjE3MjYxMzYwMTkzMTg3OTg5MTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac32934aadcff76f4d2856d8d3c47cc8ead101a7d4f75e8dfe59c921977c95b1a2
hovercard-subject-tagpull_request:2163696387
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openapi-generators/openapi-python-client/pull/1159/files
twitter:imagehttps://avatars.githubusercontent.com/u/170372326?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/170372326?s=400&v=4
og:image:altFixes #1123. Details are as described in the changeset. This is a breaking change only in cases where the previous logic was producing an unambiguously wrong result. That is, in the example shown i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None39fe8101494cbb823c09b619b68c80cd4d05ab7279997038dbe06bb91608abe1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openapi-generators/openapi-python-client git https://github.com/openapi-generators/openapi-python-client.git
octolytics-dimension-user_id84925606
octolytics-dimension-user_loginopenapi-generators
octolytics-dimension-repository_id240776275
octolytics-dimension-repository_nwoopenapi-generators/openapi-python-client
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id240776275
octolytics-dimension-repository_network_root_nwoopenapi-generators/openapi-python-client
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released5b34a4e4898b066c629879feb4b184bc471d6a7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenapi-generators%2Fopenapi-python-client%2Fpull%2F1159%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenapi-generators%2Fopenapi-python-client%2Fpull%2F1159%2Ffiles
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openapi-generators%2Fopenapi-python-client
Reloadhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files
Reloadhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files
Reloadhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files
openapi-generators https://patch-diff.githubusercontent.com/openapi-generators
openapi-python-clienthttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client
Please reload this pagehttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client
Fork 264 https://patch-diff.githubusercontent.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client
Star 1.9k https://patch-diff.githubusercontent.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client
Code https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client
Issues 77 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/issues
Pull requests 14 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pulls
Discussions https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/discussions
Actions https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/actions
Security 2 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/security
Insights https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pulse
Code https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client
Issues https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/issues
Pull requests https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pulls
Discussions https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/discussions
Actions https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/actions
Security https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/security
Insights https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fopenapi-generators%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
openapi-generators:mainhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/tree/main
eli-bl:issue1123-merge-modelhttps://patch-diff.githubusercontent.com/eli-bl/openapi-python-client/tree/issue1123-merge-model
Conversation 2 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159
Commits 6 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits
Checks 19 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/checks
Files changed https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files
Please reload this pagehttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files
fix logic for merging object schemas within a property https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#top
Show all changes 6 commits https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files
850df2e fix: use correct class name when overriding model property eli-bl Sep 20, 2024 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/850df2e572dd84428ae3181a3c15ec4bffff2c10
5cd16ac misc implementation changes eli-bl Oct 10, 2024 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/5cd16ac385d2abc403a32c6af1da9874ea5557c6
e35b31a Merge branch 'main' of github.com:openapi-generators/openapi-python-c… eli-bl Nov 5, 2024 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/e35b31a74ff55d6a3bddc76132c00121aea6ee54
e6cdf95 lint eli-bl Nov 5, 2024 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/e6cdf95cc386f689da56bd81b73eab999b1c12b7
c363974 simplify a bit eli-bl Nov 5, 2024 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/c363974148c079f88d23d1c88a0a0786edde393b
9e7e7b1 Merge branch 'upstream-main' into issue1123-merge-model eli-bl Dec 7, 2024 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/9e7e7b12b6ff08dcc6183d8f16966115768748cc
Clear filters https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files
Please reload this pagehttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files
Please reload this pagehttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files
fix-model-override.md https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-ced3b989d6d65629477358616dee0c77aa769a23b28ee8e33e4e1dd72d491721
merge_properties.py https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-ffb5e1aa2463e1fa840ed7fae5f48b5772724e9b3303b4265fb0ee7139f689cb
model_property.py https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-847f198f92313c7725c39f40576feedc900c9717eecba3a5e70f551926128d73
protocol.py https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-aa3ab959b1c570baf547f33a45d7dcb7c3b431ef3519e5cde1eb9c1184d7b0be
conftest.py https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-e52e4ddd58b7ef887ab03c04116e676f6280b824ab7469d5d3080e5cba4f2128
test_merge_properties.py https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-f170c167671d2a9bcf97905ab6353d0b7b13856599abdf7303dddaa1312f60af
test_model_property.py https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-36824c880ba9e752de856f28c0fc852da3c47b40e9ad9b6a250d38f2f251bcdb
test_protocol.py https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-10faa49b6757f18635195ab5a0b300047af55ce92e9879d45c216e9e80e0b8b5
.changeset/fix-model-override.mdhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-ced3b989d6d65629477358616dee0c77aa769a23b28ee8e33e4e1dd72d491721
View file https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/blob/9e7e7b12b6ff08dcc6183d8f16966115768748cc/.changeset/fix-model-override.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/{{ revealButtonHref }}
openapi_python_client/parser/properties/merge_properties.pyhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-ffb5e1aa2463e1fa840ed7fae5f48b5772724e9b3303b4265fb0ee7139f689cb
View file https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/blob/9e7e7b12b6ff08dcc6183d8f16966115768748cc/openapi_python_client/parser/properties/merge_properties.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-ffb5e1aa2463e1fa840ed7fae5f48b5772724e9b3303b4265fb0ee7139f689cb
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Nov 5, 2024https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#r1829963808
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files
https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-ffb5e1aa2463e1fa840ed7fae5f48b5772724e9b3303b4265fb0ee7139f689cb
https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-ffb5e1aa2463e1fa840ed7fae5f48b5772724e9b3303b4265fb0ee7139f689cb
https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-ffb5e1aa2463e1fa840ed7fae5f48b5772724e9b3303b4265fb0ee7139f689cb
https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-ffb5e1aa2463e1fa840ed7fae5f48b5772724e9b3303b4265fb0ee7139f689cb
https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-ffb5e1aa2463e1fa840ed7fae5f48b5772724e9b3303b4265fb0ee7139f689cb
https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-ffb5e1aa2463e1fa840ed7fae5f48b5772724e9b3303b4265fb0ee7139f689cb
Please reload this pagehttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files
Please reload this pagehttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.