René's URL Explorer Experiment


Title: fix logic for merging object schemas within a property by eli-bl · Pull Request #1159 · openapi-generators/openapi-python-client · GitHub

Open Graph Title: fix logic for merging object schemas within a property by eli-bl · Pull Request #1159 · openapi-generators/openapi-python-client

X Title: fix logic for merging object schemas within a property by eli-bl · Pull Request #1159 · openapi-generators/openapi-python-client

Description: Fixes #1123. Details are as described in the changeset. This is a breaking change only in cases where the previous logic was producing an unambiguously wrong result. That is, in the example shown i...

Open Graph Description: Fixes #1123. Details are as described in the changeset. This is a breaking change only in cases where the previous logic was producing an unambiguously wrong result. That is, in the example shown i...

X Description: Fixes #1123. Details are as described in the changeset. This is a breaking change only in cases where the previous logic was producing an unambiguously wrong result. That is, in the example shown i...

Opengraph URL: https://github.com/openapi-generators/openapi-python-client/pull/1159

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dc111a33-62e0-c34a-dc72-a398b706d789
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7AE:6D35F:19C7036:216FA2C:6980274A
html-safe-nonceec99b5f8f01be294aa63f6e7cd2cd05d4cce02c45913888626ae7756ed79327b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0FFOjZEMzVGOjE5QzcwMzY6MjE2RkEyQzo2OTgwMjc0QSIsInZpc2l0b3JfaWQiOiI4MTU2MzQ1NDA0NTgyMDEyNzQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac567c44932e7b8ac5bf77206f219990b031d12042418722c9426733651d7193c3
hovercard-subject-tagpull_request:2163696387
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/openapi-generators/openapi-python-client/1159/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/abbd977556e7a520b1ce6c306066e961c7d25a748d61667f85bf9705e6137541/openapi-generators/openapi-python-client/pull/1159
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/abbd977556e7a520b1ce6c306066e961c7d25a748d61667f85bf9705e6137541/openapi-generators/openapi-python-client/pull/1159
og:image:altFixes #1123. Details are as described in the changeset. This is a breaking change only in cases where the previous logic was producing an unambiguously wrong result. That is, in the example shown i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameeli-bl
hostnamegithub.com
expected-hostnamegithub.com
None60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6
turbo-cache-controlno-preview
go-importgithub.com/openapi-generators/openapi-python-client git https://github.com/openapi-generators/openapi-python-client.git
octolytics-dimension-user_id84925606
octolytics-dimension-user_loginopenapi-generators
octolytics-dimension-repository_id240776275
octolytics-dimension-repository_nwoopenapi-generators/openapi-python-client
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id240776275
octolytics-dimension-repository_network_root_nwoopenapi-generators/openapi-python-client
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7c85641c598ad130c74f7bcc27f58575cac69551
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenapi-generators%2Fopenapi-python-client%2Fpull%2F1159
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenapi-generators%2Fopenapi-python-client%2Fpull%2F1159
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=openapi-generators%2Fopenapi-python-client
Reloadhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159
Reloadhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159
Reloadhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159
openapi-generators https://patch-diff.githubusercontent.com/openapi-generators
openapi-python-clienthttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client
Please reload this pagehttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client
Fork 264 https://patch-diff.githubusercontent.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client
Star 1.9k https://patch-diff.githubusercontent.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client
Code https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client
Issues 77 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/issues
Pull requests 14 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pulls
Discussions https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/discussions
Actions https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/actions
Security 2 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/security
Insights https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pulse
Code https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client
Issues https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/issues
Pull requests https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pulls
Discussions https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/discussions
Actions https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/actions
Security https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/security
Insights https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fopenapi-generators%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159#issue-comment-box
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
openapi-generators:mainhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/tree/main
eli-bl:issue1123-merge-modelhttps://patch-diff.githubusercontent.com/eli-bl/openapi-python-client/tree/issue1123-merge-model
fix logic for merging object schemas within a property https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159#top
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
openapi-generators:mainhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/tree/main
eli-bl:issue1123-merge-modelhttps://patch-diff.githubusercontent.com/eli-bl/openapi-python-client/tree/issue1123-merge-model
Conversation 2 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159
Commits 6 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits
Checks 19 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/checks
Files changed https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files
Please reload this pagehttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Nov 5, 2024https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159#issue-2636193410
Please reload this pagehttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159
#1123https://github.com/openapi-generators/openapi-python-client/issues/1123
Please reload this pagehttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
September 20, 2024 19:07https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159#commits-pushed-850df2e
https://patch-diff.githubusercontent.com/eli-bl
fix: use correct class name when overriding model propertyhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/850df2e572dd84428ae3181a3c15ec4bffff2c10
850df2ehttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/850df2e572dd84428ae3181a3c15ec4bffff2c10
https://patch-diff.githubusercontent.com/eli-bl
misc implementation changeshttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/5cd16ac385d2abc403a32c6af1da9874ea5557c6
5cd16achttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/5cd16ac385d2abc403a32c6af1da9874ea5557c6
https://patch-diff.githubusercontent.com/eli-bl
Merge branch 'main' of github.com:openapi-generators/openapi-python-c…https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/e35b31a74ff55d6a3bddc76132c00121aea6ee54
e35b31ahttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/e35b31a74ff55d6a3bddc76132c00121aea6ee54
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Nov 5, 2024https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159#event-15125628169
https://patch-diff.githubusercontent.com/eli-bl
linthttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/e6cdf95cc386f689da56bd81b73eab999b1c12b7
e6cdf95https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/e6cdf95cc386f689da56bd81b73eab999b1c12b7
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
force-pushedhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/10cae28fc56dbf773759ce65201065f0f3997c77..e6cdf95cc386f689da56bd81b73eab999b1c12b7
10cae28https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/10cae28fc56dbf773759ce65201065f0f3997c77
e6cdf95https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/e6cdf95cc386f689da56bd81b73eab999b1c12b7
Compare https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/10cae28fc56dbf773759ce65201065f0f3997c77..e6cdf95cc386f689da56bd81b73eab999b1c12b7
November 5, 2024 20:29https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159#event-15126795897
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Nov 5, 2024 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159#pullrequestreview-2416630654
View reviewed changes https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files/e6cdf95cc386f689da56bd81b73eab999b1c12b7
openapi_python_client/parser/properties/merge_properties.pyhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files/e6cdf95cc386f689da56bd81b73eab999b1c12b7#diff-ffb5e1aa2463e1fa840ed7fae5f48b5772724e9b3303b4265fb0ee7139f689cb
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Nov 5, 2024https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159#discussion_r1829963808
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Nov 5, 2024 https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159#pullrequestreview-2416700934
View reviewed changes https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files
openapi_python_client/parser/properties/model_property.pyhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/files#diff-847f198f92313c7725c39f40576feedc900c9717eecba3a5e70f551926128d73
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
Nov 5, 2024https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159#discussion_r1830006615
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159
https://patch-diff.githubusercontent.com/eli-bl
simplify a bithttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/c363974148c079f88d23d1c88a0a0786edde393b
c363974https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/c363974148c079f88d23d1c88a0a0786edde393b
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
force-pushedhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/fccd38230c60b9d5d01e1e5a113605899b34e16c..c363974148c079f88d23d1c88a0a0786edde393b
fccd382https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/fccd38230c60b9d5d01e1e5a113605899b34e16c
c363974https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/c363974148c079f88d23d1c88a0a0786edde393b
Compare https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/fccd38230c60b9d5d01e1e5a113605899b34e16c..c363974148c079f88d23d1c88a0a0786edde393b
November 5, 2024 21:17https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159#event-15127904218
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
November 5, 2024 21:22https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159#event-15128037903
https://patch-diff.githubusercontent.com/eli-bl
eli-blhttps://patch-diff.githubusercontent.com/eli-bl
dbantyhttps://patch-diff.githubusercontent.com/dbanty
November 5, 2024 21:22https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159#event-15128039267
https://patch-diff.githubusercontent.com/eli-bl
Merge branch 'upstream-main' into issue1123-merge-modelhttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/9e7e7b12b6ff08dcc6183d8f16966115768748cc
9e7e7b1https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159/commits/9e7e7b12b6ff08dcc6183d8f16966115768748cc
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenapi-generators%2Fopenapi-python-client%2Fpull%2F1159
https://patch-diff.githubusercontent.com/dbanty
dbanty https://patch-diff.githubusercontent.com/dbanty
overriding model property with more specific object type doesn't work https://github.com/openapi-generators/openapi-python-client/issues/1123
Please reload this pagehttps://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1159
https://patch-diff.githubusercontent.com/eli-bl
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.