| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bdd09843-1f04-9ec3-bef2-089566671dc9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A06E:3F5C87:1CE3117:26F6CE9:69807196 |
| html-safe-nonce | bb5a4f2a625b3dc79e43502abf275235a44dc51aad2e65138be00d54919508cc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDZFOjNGNUM4NzoxQ0UzMTE3OjI2RjZDRTk6Njk4MDcxOTYiLCJ2aXNpdG9yX2lkIjoiNTI3MDQwODQ4NzI3OTU1NDk2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 09d6f1b0046cd53fad968130307ca879d1cc45a29e33bf575d2033e83c2190dc |
| hovercard-subject-tag | pull_request:2149913527 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/openapi-generators/openapi-python-client/1154/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7ed98f9f1913f57c336a39187933ecf3e9c9564189afbb864138b7f90106385f/openapi-generators/openapi-python-client/pull/1154 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7ed98f9f1913f57c336a39187933ecf3e9c9564189afbb864138b7f90106385f/openapi-generators/openapi-python-client/pull/1154 |
| og:image:alt | This more fully fixes #219, and supersedes #717.
Any valid discriminator definition as described in OpenAPI 3.1.0 should work correctly with these changes, including:
Discriminators with a mapping... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | eli-bl |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0959b1a93ca48b0c88b3bddbdfd04ca43f388cb1a8293105a28c5ef6e8079db8 |
| turbo-cache-control | no-preview |
| go-import | github.com/openapi-generators/openapi-python-client git https://github.com/openapi-generators/openapi-python-client.git |
| octolytics-dimension-user_id | 84925606 |
| octolytics-dimension-user_login | openapi-generators |
| octolytics-dimension-repository_id | 240776275 |
| octolytics-dimension-repository_nwo | openapi-generators/openapi-python-client |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 240776275 |
| octolytics-dimension-repository_network_root_nwo | openapi-generators/openapi-python-client |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 78307334c66591a8f87f493dd2968126b34961dd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenapi-generators%2Fopenapi-python-client%2Fpull%2F1154 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenapi-generators%2Fopenapi-python-client%2Fpull%2F1154 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=openapi-generators%2Fopenapi-python-client |
| Reload | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
| Reload | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
| Reload | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
|
openapi-generators
| https://patch-diff.githubusercontent.com/openapi-generators |
| openapi-python-client | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client |
| Please reload this page | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client |
|
Fork
264
| https://patch-diff.githubusercontent.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client |
|
Star
1.9k
| https://patch-diff.githubusercontent.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client |
|
Code
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client |
|
Issues
77
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/issues |
|
Pull requests
14
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pulls |
|
Discussions
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/discussions |
|
Actions
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/actions |
|
Security
2
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/security |
|
Insights
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pulse |
|
Code
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client |
|
Issues
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pulls |
|
Discussions
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/discussions |
|
Actions
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/actions |
|
Security
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/security |
|
Insights
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Fopenapi-generators%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#issue-comment-box |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| openapi-generators:main | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/tree/main |
| benchling:discriminators | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/tree/discriminators |
|
add discriminator property support
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#top |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| openapi-generators:main | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/tree/main |
| benchling:discriminators | https://patch-diff.githubusercontent.com/benchling/openapi-python-client/tree/discriminators |
|
Conversation
9
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
|
Commits
9
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits |
|
Checks
19
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/files |
| Please reload this page | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| Oct 28, 2024 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#issue-2619273842 |
| Please reload this page | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
| #219 | https://github.com/openapi-generators/openapi-python-client/issues/219 |
| #717 | https://github.com/openapi-generators/openapi-python-client/pull/717 |
| OpenAPI 3.1.0 | https://spec.openapis.org/oas/v3.1.0.html#discriminator-object |
| Please reload this page | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| force-pushed | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/a9c27ab143fca6988677d3935851c571a9235914..964381af6a5e42cb58f250935f8e4877cd5883f0 |
| a9c27ab | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/a9c27ab143fca6988677d3935851c571a9235914 |
| 964381a | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/964381af6a5e42cb58f250935f8e4877cd5883f0 |
|
Compare
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/a9c27ab143fca6988677d3935851c571a9235914..964381af6a5e42cb58f250935f8e4877cd5883f0 |
| October 28, 2024 19:00 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#event-14968021726 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| dbanty | https://patch-diff.githubusercontent.com/dbanty |
| October 28, 2024 19:01 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#event-14968035732 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| force-pushed | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/c2f78b6ab2604ec5f99a428adbcc211b845d321e..de524e90cf873a8658e971d9fba09e312094ecb8 |
| c2f78b6 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/c2f78b6ab2604ec5f99a428adbcc211b845d321e |
| de524e9 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/de524e90cf873a8658e971d9fba09e312094ecb8 |
|
Compare
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/c2f78b6ab2604ec5f99a428adbcc211b845d321e..de524e90cf873a8658e971d9fba09e312094ecb8 |
| October 28, 2024 19:11 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#event-14968164940 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
|
Oct 28, 2024
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#pullrequestreview-2399991792 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/files |
| end_to_end_tests/baseline_openapi_3.0.json | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/files#diff-77684f26aa921fc62d68726ed5ff58c4f476b3d33708bbc21b960aefeec84157 |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| Oct 28, 2024 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#discussion_r1819615416 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| Oct 29, 2024 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#discussion_r1821605154 |
| Please reload this page | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| what OpenAPI says | https://spec.openapis.org/oas/v3.1.0.html#discriminator-object |
| Please reload this page | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
|
Oct 28, 2024
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#pullrequestreview-2399993032 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/files |
| openapi_python_client/parser/properties/union.py | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/files#diff-cd8d1b6355e7d64432afb9f7431c2898f051978253484bb7e9af78db96b8c470 |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| Oct 28, 2024 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#discussion_r1819616474 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| force-pushed | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/de524e90cf873a8658e971d9fba09e312094ecb8..caa81a742f854642d1d8911ee97406fde477ecf8 |
| de524e9 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/de524e90cf873a8658e971d9fba09e312094ecb8 |
| caa81a7 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/caa81a742f854642d1d8911ee97406fde477ecf8 |
|
Compare
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/de524e90cf873a8658e971d9fba09e312094ecb8..caa81a742f854642d1d8911ee97406fde477ecf8 |
| October 28, 2024 19:20 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#event-14968285044 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| October 28, 2024 19:26 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#event-14968368533 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
|
Oct 28, 2024
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#ref-pullrequest-2619395782 |
|
add discriminator property support
benchling/openapi-python-client#214
| https://patch-diff.githubusercontent.com/benchling/openapi-python-client/pull/214 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| force-pushed | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/2136c1431ac1fa70ae53f30c56803b942272750a..1956f6834d37ae4e63d05b685179449a6634e629 |
| 2136c14 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/2136c1431ac1fa70ae53f30c56803b942272750a |
| 1956f68 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/1956f6834d37ae4e63d05b685179449a6634e629 |
|
Compare
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/2136c1431ac1fa70ae53f30c56803b942272750a..1956f6834d37ae4e63d05b685179449a6634e629 |
| October 28, 2024 21:30 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#event-14969827433 |
|
| https://patch-diff.githubusercontent.com/eli-bl |
| add discriminator property support | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/0496ff886af2a73718b2ceb250e49078905fc666 |
| 0496ff8 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/0496ff886af2a73718b2ceb250e49078905fc666 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| force-pushed | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/1956f6834d37ae4e63d05b685179449a6634e629..0496ff886af2a73718b2ceb250e49078905fc666 |
| 1956f68 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/1956f6834d37ae4e63d05b685179449a6634e629 |
| 0496ff8 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/0496ff886af2a73718b2ceb250e49078905fc666 |
|
Compare
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/1956f6834d37ae4e63d05b685179449a6634e629..0496ff886af2a73718b2ceb250e49078905fc666 |
| October 28, 2024 21:33 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#event-14969852297 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| Oct 28, 2024 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#issuecomment-2442773546 |
| the spec | https://spec.openapis.org/oas/v3.1.0.html#discriminator-object |
| the official answer | https://github.com/OAI/OpenAPI-Specification/issues/2215#issuecomment-1912860237 |
| Please reload this page | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| October 30, 2024 21:03 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#event-15018310702 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| Oct 30, 2024 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#issuecomment-2448378854 |
| Please reload this page | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| October 30, 2024 15:25 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#commits-pushed-b75adda |
|
| https://patch-diff.githubusercontent.com/eli-bl |
| simply the discriminator logic a bit | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/b75adda0bcf64009120f8b6eedeaf55bf95a5fde |
| b75adda | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/b75adda0bcf64009120f8b6eedeaf55bf95a5fde |
|
| https://patch-diff.githubusercontent.com/eli-bl |
| remove new category of tests for now | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/29414518643acfaa72d97e21a17b64224cb0ef24 |
| 2941451 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/29414518643acfaa72d97e21a17b64224cb0ef24 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| force-pushed | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/9e719360af461fc0582a048dd279d74b16bb8bbf..29414518643acfaa72d97e21a17b64224cb0ef24 |
| 9e71936 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/9e719360af461fc0582a048dd279d74b16bb8bbf |
| 2941451 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/29414518643acfaa72d97e21a17b64224cb0ef24 |
|
Compare
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/9e719360af461fc0582a048dd279d74b16bb8bbf..29414518643acfaa72d97e21a17b64224cb0ef24 |
| October 31, 2024 17:18 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#event-15042283519 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
|
Oct 31, 2024
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#pullrequestreview-2408634864 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/files/29414518643acfaa72d97e21a17b64224cb0ef24 |
| openapi_python_client/parser/properties/model_property.py | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/files/29414518643acfaa72d97e21a17b64224cb0ef24#diff-847f198f92313c7725c39f40576feedc900c9717eecba3a5e70f551926128d73 |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| Oct 31, 2024 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#discussion_r1824885063 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/openapi-generators/openapi-python-client/pull/1154/files#diff-91d61e88486ae43dc0579d44f7964667c53749e7091907d6a064d80b57a4b26dR145 | https://github.com/openapi-generators/openapi-python-client/pull/1154/files#diff-91d61e88486ae43dc0579d44f7964667c53749e7091907d6a064d80b57a4b26dR145 |
| Please reload this page | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| Oct 31, 2024 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#issuecomment-2450448019 |
| Please reload this page | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| October 31, 2024 17:33 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#event-15042648362 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
|
Oct 31, 2024
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#pullrequestreview-2408651730 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/files/29414518643acfaa72d97e21a17b64224cb0ef24 |
| openapi_python_client/templates/property_templates/union_property.py.jinja | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/files/29414518643acfaa72d97e21a17b64224cb0ef24#diff-23d4c94f056bacffca42533cd744b9df1851d32b1947472bc1683f52cf977da6 |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| Oct 31, 2024 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#discussion_r1824895292 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| November 5, 2024 13:29 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#commits-pushed-d189f77 |
|
| https://patch-diff.githubusercontent.com/eli-bl |
| lint | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/d189f771180f189555e7109aee24da871d548724 |
| d189f77 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/d189f771180f189555e7109aee24da871d548724 |
|
| https://patch-diff.githubusercontent.com/eli-bl |
| lint | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/de1ddf33667318aad595227492109fed6436bb70 |
| de1ddf3 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/de1ddf33667318aad595227492109fed6436bb70 |
| https://patch-diff.githubusercontent.com/eli-bl |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| force-pushed | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/344ec970cd4eaf177784522be1a1daabdac9342b..de1ddf33667318aad595227492109fed6436bb70 |
| 344ec97 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/344ec970cd4eaf177784522be1a1daabdac9342b |
| de1ddf3 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/commit/de1ddf33667318aad595227492109fed6436bb70 |
|
Compare
| https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/compare/344ec970cd4eaf177784522be1a1daabdac9342b..de1ddf33667318aad595227492109fed6436bb70 |
| November 5, 2024 23:38 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#event-15131174303 |
| eli-bl | https://patch-diff.githubusercontent.com/eli-bl |
| November 6, 2024 13:21 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#commits-pushed-9071de0 |
|
| https://patch-diff.githubusercontent.com/eli-bl |
| handle a case where there's multiple values mapped to same type | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/9071de05a4158ff397f74ac829ba3eb9f11daf62 |
| 9071de0 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/9071de05a4158ff397f74ac829ba3eb9f11daf62 |
|
| https://patch-diff.githubusercontent.com/eli-bl |
| documentation | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/0a8b3f74d99f32ece166dde1051770acdac78835 |
| 0a8b3f7 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/0a8b3f74d99f32ece166dde1051770acdac78835 |
|
| https://patch-diff.githubusercontent.com/eli-bl |
| Merge branch 'upstream-main' into discriminators | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/f2e84aa47692da7a9cd461a01fa121deb4a49849 |
| f2e84aa | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/f2e84aa47692da7a9cd461a01fa121deb4a49849 |
|
| https://patch-diff.githubusercontent.com/eli-bl |
| lint | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/8197b1486dcaa3e92ee25459598e7f14b0cb32a3 |
| 8197b14 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154/commits/8197b1486dcaa3e92ee25459598e7f14b0cb32a3 |
| https://patch-diff.githubusercontent.com/ranma42 |
| ranma42 | https://patch-diff.githubusercontent.com/ranma42 |
| Dec 22, 2025 | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154#issuecomment-3681624812 |
| Please reload this page | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenapi-generators%2Fopenapi-python-client%2Fpull%2F1154 |
|
| https://patch-diff.githubusercontent.com/dbanty |
|
dbanty
| https://patch-diff.githubusercontent.com/dbanty |
|
Support discriminator for polymorphic types and support oneOf
| https://github.com/openapi-generators/openapi-python-client/issues/219 |
| Please reload this page | https://patch-diff.githubusercontent.com/openapi-generators/openapi-python-client/pull/1154 |
|
| https://patch-diff.githubusercontent.com/eli-bl |
|
| https://patch-diff.githubusercontent.com/ranma42 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |