Title: improve UnionProperty behavior for anyOf/oneOf, lists of types, and nullable enums by eli-bl · Pull Request #1121 · openapi-generators/openapi-python-client · GitHub
Open Graph Title: improve UnionProperty behavior for anyOf/oneOf, lists of types, and nullable enums by eli-bl · Pull Request #1121 · openapi-generators/openapi-python-client
X Title: improve UnionProperty behavior for anyOf/oneOf, lists of types, and nullable enums by eli-bl · Pull Request #1121 · openapi-generators/openapi-python-client
Description: Fixes #1120. There are two related changes here: First, when processing the anyOf/oneOf items in a union, check whether each item will generate a named Python class (i.e. is it an enum or a model). If exactly one of them will, then we should not use a synthetic name like xyz_type_1; instead just use the original name xyz. (If more than one of them will, then we do need to add name suffixes; if none of them will, then it doesn't really matter since none of the synthetic names will show up in Python code anyway). That fixes the case described in the issue where nullable object/enum classes got an unnecessary "Type1" suffix. It's a breaking change, but, I think, a desirable one— I don't think anyone prefers to have "Type1" added in those cases, and depending on that would be a bad idea anyway since it's an obscure implementation detail. So I haven't gated it behind a config option. Second, if we're creating a union and type has been explicitly specified— these were the cases where a bunch of spurious -Type1, -Type2Type1, etc. were being created, because of faulty logic that assumed every explicit type had to be added separately to the union. I believe the correct behavior is: If the union is just because there are multiple types, then go ahead and add a Property for each one. If there is a type or types, but there is also anyOf or oneOf, then we don't need to add anything, because the schemas in the anyOf/oneOf list already describe what kind of values there can be. (We could add a check to make sure the types aren't contradictory— for instance, if type is ["string", "number"] but the anyOf variants are objects— but that's out of scope here.) The second issue was also the reason for the weird behavior of nullable with enums in 3.0, because we are handling nullable by converting the type into a union.
Open Graph Description: Fixes #1120. There are two related changes here: First, when processing the anyOf/oneOf items in a union, check whether each item will generate a named Python class (i.e. is it an enum or a model)....
X Description: Fixes #1120. There are two related changes here: First, when processing the anyOf/oneOf items in a union, check whether each item will generate a named Python class (i.e. is it an enum or a model)....
Opengraph URL: https://github.com/openapi-generators/openapi-python-client/pull/1121
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5b88a96b-06f4-2598-a4af-1ca5507d31f7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 84B4:DBF78:251D60F:326E602:69808C7B |
| html-safe-nonce | 973d48f8e2a8fc8f2888f619c75666978f64572d8132fac31e044de065b7e3e9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEI0OkRCRjc4OjI1MUQ2MEY6MzI2RTYwMjo2OTgwOEM3QiIsInZpc2l0b3JfaWQiOiIzOTQ1MTUyOTE0NTY5MzMzODgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 650bfc1706be3d7a9737da82c84b20f7e6805c1c8f9efdeb97b19bc73f3d8954 |
| hovercard-subject-tag | pull_request:2069840157 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/openapi-generators/openapi-python-client/pull/1121/files |
| twitter:image | https://avatars.githubusercontent.com/u/170372326?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/170372326?s=400&v=4 |
| og:image:alt | Fixes #1120. There are two related changes here: First, when processing the anyOf/oneOf items in a union, check whether each item will generate a named Python class (i.e. is it an enum or a model).... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 469777838102ab297ec4fcad28d2f2800ba15f98fafe1027761c30ba1171be52 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/openapi-generators/openapi-python-client git https://github.com/openapi-generators/openapi-python-client.git |
| octolytics-dimension-user_id | 84925606 |
| octolytics-dimension-user_login | openapi-generators |
| octolytics-dimension-repository_id | 240776275 |
| octolytics-dimension-repository_nwo | openapi-generators/openapi-python-client |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 240776275 |
| octolytics-dimension-repository_network_root_nwo | openapi-generators/openapi-python-client |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | abd13d780acc53a8d052b86a5b6ac82b79676965 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width