| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:28430ca8-a633-0866-ed1e-d4ae471e69a8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C068:CC209:1680E5:1BE1DA:6990660C |
| html-safe-nonce | c90609953dca52f818697dc43c165bbde45c69a8f749b866d805b6d7d80125cf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDY4OkNDMjA5OjE2ODBFNToxQkUxREE6Njk5MDY2MEMiLCJ2aXNpdG9yX2lkIjoiNzQ0MTg0MjU2OTQzNTE3ODUwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2fc5be8716f727883d2511936008777777ecca118dd1b320e246ba4703e0ddef |
| hovercard-subject-tag | pull_request:235914322 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/24832/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/02dff44961a1075fcb394bd6aa654bc8aa24cd513eea5ff14954c0004aa6de0f/nodejs/node/pull/24832 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/02dff44961a1075fcb394bd6aa654bc8aa24cd513eea5ff14954c0004aa6de0f/nodejs/node/pull/24832 |
| og:image:alt | 2018-12-18, Version 8.14.1 'Carbon' (LTS), @MylesBorins prepared by @BethGriggs
Notable changes
assert:
revert breaking change (Ruben Bridgewater) #24786
http2:
fix sequence of error/c... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | BethGriggs |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24832 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24832 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
| Reload | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
| Reload | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
|
nodejs
| https://patch-diff.githubusercontent.com/nodejs |
| node | https://patch-diff.githubusercontent.com/nodejs/node |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://patch-diff.githubusercontent.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://patch-diff.githubusercontent.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://patch-diff.githubusercontent.com/nodejs/node |
|
Issues
1.7k
| https://patch-diff.githubusercontent.com/nodejs/node/issues |
|
Pull requests
706
| https://patch-diff.githubusercontent.com/nodejs/node/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/nodejs/node/actions |
|
Projects
3
| https://patch-diff.githubusercontent.com/nodejs/node/projects |
|
Security
0
| https://patch-diff.githubusercontent.com/nodejs/node/security |
|
Insights
| https://patch-diff.githubusercontent.com/nodejs/node/pulse |
|
Code
| https://patch-diff.githubusercontent.com/nodejs/node |
|
Issues
| https://patch-diff.githubusercontent.com/nodejs/node/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/nodejs/node/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/nodejs/node/actions |
|
Projects
| https://patch-diff.githubusercontent.com/nodejs/node/projects |
|
Security
| https://patch-diff.githubusercontent.com/nodejs/node/security |
|
Insights
| https://patch-diff.githubusercontent.com/nodejs/node/pulse |
| MylesBorins | https://patch-diff.githubusercontent.com/MylesBorins |
| v8.x | https://patch-diff.githubusercontent.com/nodejs/node/tree/v8.x |
| v8.14.1-proposal | https://patch-diff.githubusercontent.com/nodejs/node/tree/v8.14.1-proposal |
| Conversation | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
| Commits88 (88) | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits |
| Checks | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/checks |
| Files changed | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/files |
| v8.14.1 proposal | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#top |
| MylesBorins | https://patch-diff.githubusercontent.com/MylesBorins |
| v8.x | https://patch-diff.githubusercontent.com/nodejs/node/tree/v8.x |
| v8.14.1-proposal | https://patch-diff.githubusercontent.com/nodejs/node/tree/v8.14.1-proposal |
|
| https://patch-diff.githubusercontent.com/BethGriggs |
| BethGriggs | https://patch-diff.githubusercontent.com/BethGriggs |
| Dec 4, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#issue-387422551 |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
| @MylesBorins | https://github.com/MylesBorins |
| @BethGriggs | https://github.com/BethGriggs |
| #24786 | https://github.com/nodejs/node/pull/24786 |
| #24789 | https://github.com/nodejs/node/pull/24789 |
| a8402fe1c8 | https://github.com/nodejs/node/commit/a8402fe1c8 |
| #24575 | https://github.com/nodejs/node/pull/24575 |
| 26743369d3 | https://github.com/nodejs/node/commit/26743369d3 |
| #21459 | https://github.com/nodejs/node/pull/21459 |
| 1da04c208d | https://github.com/nodejs/node/commit/1da04c208d |
| #21215 | https://github.com/nodejs/node/pull/21215 |
| 7612024939 | https://github.com/nodejs/node/commit/7612024939 |
| #21059 | https://github.com/nodejs/node/pull/21059 |
| f70e79a7b2 | https://github.com/nodejs/node/commit/f70e79a7b2 |
| #23763 | https://github.com/nodejs/node/pull/23763 |
| 15d1f67c60 | https://github.com/nodejs/node/commit/15d1f67c60 |
| #22991 | https://github.com/nodejs/node/pull/22991 |
| 85a6daeaef | https://github.com/nodejs/node/commit/85a6daeaef |
| #23778 | https://github.com/nodejs/node/pull/23778 |
| 313ef6fa73 | https://github.com/nodejs/node/commit/313ef6fa73 |
| #22417 | https://github.com/nodejs/node/pull/22417 |
| 22b41495ea | https://github.com/nodejs/node/commit/22b41495ea |
| #22416 | https://github.com/nodejs/node/pull/22416 |
| 499605618b | https://github.com/nodejs/node/commit/499605618b |
| #23687 | https://github.com/nodejs/node/pull/23687 |
| 34d91296df | https://github.com/nodejs/node/commit/34d91296df |
| #23764 | https://github.com/nodejs/node/pull/23764 |
| 50347297a1 | https://github.com/nodejs/node/commit/50347297a1 |
| #23958 | https://github.com/nodejs/node/pull/23958 |
| 9bedae5266 | https://github.com/nodejs/node/commit/9bedae5266 |
| 6bc4bfe | https://github.com/nodejs/node/commit/6bc4bfeb07e894ea39449c1ad447f283a251b4b8 |
| #23958 | https://github.com/nodejs/node/pull/23958 |
| 4f3c9e6aab | https://github.com/nodejs/node/commit/4f3c9e6aab |
| #23958 | https://github.com/nodejs/node/pull/23958 |
| 6d8c65e574 | https://github.com/nodejs/node/commit/6d8c65e574 |
| #19709 | https://github.com/nodejs/node/pull/19709 |
| 33b7c50036 | https://github.com/nodejs/node/commit/33b7c50036 |
| #19690 | https://github.com/nodejs/node/pull/19690 |
| 216e7da8c5 | https://github.com/nodejs/node/commit/216e7da8c5 |
| #19689 | https://github.com/nodejs/node/pull/19689 |
| 17e84217c7 | https://github.com/nodejs/node/commit/17e84217c7 |
| #19641 | https://github.com/nodejs/node/pull/19641 |
| 06daf5276f | https://github.com/nodejs/node/commit/06daf5276f |
| #19620 | https://github.com/nodejs/node/pull/19620 |
| bf95392e86 | https://github.com/nodejs/node/commit/bf95392e86 |
| #19622 | https://github.com/nodejs/node/pull/19622 |
| e48cc3c403 | https://github.com/nodejs/node/commit/e48cc3c403 |
| #19552 | https://github.com/nodejs/node/pull/19552 |
| 9d249bf6d5 | https://github.com/nodejs/node/commit/9d249bf6d5 |
| #19610 | https://github.com/nodejs/node/pull/19610 |
| c3ecf05b01 | https://github.com/nodejs/node/commit/c3ecf05b01 |
| #19321 | https://github.com/nodejs/node/pull/19321 |
| 8338700d05 | https://github.com/nodejs/node/commit/8338700d05 |
| #18802 | https://github.com/nodejs/node/pull/18802 |
| 63d8632611 | https://github.com/nodejs/node/commit/63d8632611 |
| #19571 | https://github.com/nodejs/node/pull/19571 |
| b2fc3b556c | https://github.com/nodejs/node/commit/b2fc3b556c |
| #19205 | https://github.com/nodejs/node/pull/19205 |
| d79e7d6e89 | https://github.com/nodejs/node/commit/d79e7d6e89 |
| #19547 | https://github.com/nodejs/node/pull/19547 |
| 06491482f8 | https://github.com/nodejs/node/commit/06491482f8 |
| #19075 | https://github.com/nodejs/node/pull/19075 |
| 4db289ca17 | https://github.com/nodejs/node/commit/4db289ca17 |
| #19416 | https://github.com/nodejs/node/pull/19416 |
| f5683a9a6d | https://github.com/nodejs/node/commit/f5683a9a6d |
| #24684 | https://github.com/nodejs/node/pull/24684 |
| ffe1f8033c | https://github.com/nodejs/node/commit/ffe1f8033c |
| #24682 | https://github.com/nodejs/node/pull/24682 |
| 78d9a5e6e4 | https://github.com/nodejs/node/commit/78d9a5e6e4 |
| #23978 | https://github.com/nodejs/node/pull/23978 |
| d1eebb2e43 | https://github.com/nodejs/node/commit/d1eebb2e43 |
| #23990 | https://github.com/nodejs/node/pull/23990 |
| 003eb0c8e1 | https://github.com/nodejs/node/commit/003eb0c8e1 |
| #23989 | https://github.com/nodejs/node/pull/23989 |
| c1723c8bca | https://github.com/nodejs/node/commit/c1723c8bca |
| #23967 | https://github.com/nodejs/node/pull/23967 |
| 8bb67a1fb9 | https://github.com/nodejs/node/commit/8bb67a1fb9 |
| #23967 | https://github.com/nodejs/node/pull/23967 |
| 73e0bb1f52 | https://github.com/nodejs/node/commit/73e0bb1f52 |
| #23970 | https://github.com/nodejs/node/pull/23970 |
| 6d76f852a9 | https://github.com/nodejs/node/commit/6d76f852a9 |
| #23914 | https://github.com/nodejs/node/pull/23914 |
| 3025f351db | https://github.com/nodejs/node/commit/3025f351db |
| #23932 | https://github.com/nodejs/node/pull/23932 |
| 2459e150bb | https://github.com/nodejs/node/commit/2459e150bb |
| #22237 | https://github.com/nodejs/node/pull/22237 |
| 27b35833bd | https://github.com/nodejs/node/commit/27b35833bd |
| #23931 | https://github.com/nodejs/node/pull/23931 |
| 0d4de59967 | https://github.com/nodejs/node/commit/0d4de59967 |
| #23881 | https://github.com/nodejs/node/pull/23881 |
| 9afdc09f98 | https://github.com/nodejs/node/commit/9afdc09f98 |
| #23864 | https://github.com/nodejs/node/pull/23864 |
| 3f2a01688d | https://github.com/nodejs/node/commit/3f2a01688d |
| #23605 | https://github.com/nodejs/node/pull/23605 |
| f037942fe7 | https://github.com/nodejs/node/commit/f037942fe7 |
| @phillipj | https://github.com/phillipj |
| #23790 | https://github.com/nodejs/node/pull/23790 |
| e5f75cf82e | https://github.com/nodejs/node/commit/e5f75cf82e |
| #23762 | https://github.com/nodejs/node/pull/23762 |
| 0ff88a3510 | https://github.com/nodejs/node/commit/0ff88a3510 |
| #23772 | https://github.com/nodejs/node/pull/23772 |
| 32ae851710 | https://github.com/nodejs/node/commit/32ae851710 |
| #23746 | https://github.com/nodejs/node/pull/23746 |
| e2d2ce6706 | https://github.com/nodejs/node/commit/e2d2ce6706 |
| #23745 | https://github.com/nodejs/node/pull/23745 |
| 8afbd5ce41 | https://github.com/nodejs/node/commit/8afbd5ce41 |
| #19666 | https://github.com/nodejs/node/pull/19666 |
| fa12532000 | https://github.com/nodejs/node/commit/fa12532000 |
| #23902 | https://github.com/nodejs/node/pull/23902 |
| e8dbd09414 | https://github.com/nodejs/node/commit/e8dbd09414 |
| #23894 | https://github.com/nodejs/node/pull/23894 |
| 5e09a3d4ed | https://github.com/nodejs/node/commit/5e09a3d4ed |
| #19703 | https://github.com/nodejs/node/pull/19703 |
| 970164f3a8 | https://github.com/nodejs/node/commit/970164f3a8 |
| #19629 | https://github.com/nodejs/node/pull/19629 |
| 086570e4e1 | https://github.com/nodejs/node/commit/086570e4e1 |
| #19659 | https://github.com/nodejs/node/pull/19659 |
| a7b3274af4 | https://github.com/nodejs/node/commit/a7b3274af4 |
| #19700 | https://github.com/nodejs/node/pull/19700 |
| 1bda58289a | https://github.com/nodejs/node/commit/1bda58289a |
| #19668 | https://github.com/nodejs/node/pull/19668 |
| bd9cc92e8d | https://github.com/nodejs/node/commit/bd9cc92e8d |
| #19707 | https://github.com/nodejs/node/pull/19707 |
| 3ca10faf00 | https://github.com/nodejs/node/commit/3ca10faf00 |
| #19636 | https://github.com/nodejs/node/pull/19636 |
| 8a546e822d | https://github.com/nodejs/node/commit/8a546e822d |
| #19660 | https://github.com/nodejs/node/pull/19660 |
| a62df1b379 | https://github.com/nodejs/node/commit/a62df1b379 |
| #19640 | https://github.com/nodejs/node/pull/19640 |
| 8a0ecf4360 | https://github.com/nodejs/node/commit/8a0ecf4360 |
| #19625 | https://github.com/nodejs/node/pull/19625 |
| 0cbe813e90 | https://github.com/nodejs/node/commit/0cbe813e90 |
| #19593 | https://github.com/nodejs/node/pull/19593 |
| ea1fda6228 | https://github.com/nodejs/node/commit/ea1fda6228 |
| #19536 | https://github.com/nodejs/node/pull/19536 |
| 18c4e5e886 | https://github.com/nodejs/node/commit/18c4e5e886 |
| #19525 | https://github.com/nodejs/node/pull/19525 |
| 146c488bf5 | https://github.com/nodejs/node/commit/146c488bf5 |
| #19092 | https://github.com/nodejs/node/pull/19092 |
| 8fa5bd3761 | https://github.com/nodejs/node/commit/8fa5bd3761 |
| #19332 | https://github.com/nodejs/node/pull/19332 |
| d34ade8755 | https://github.com/nodejs/node/commit/d34ade8755 |
| #23956 | https://github.com/nodejs/node/pull/23956 |
| 6ae07a9248 | https://github.com/nodejs/node/commit/6ae07a9248 |
| #23968 | https://github.com/nodejs/node/pull/23968 |
| b1e6de80c1 | https://github.com/nodejs/node/commit/b1e6de80c1 |
| #23871 | https://github.com/nodejs/node/pull/23871 |
| d0368b8245 | https://github.com/nodejs/node/commit/d0368b8245 |
| #23829 | https://github.com/nodejs/node/pull/23829 |
| 3a864d716e | https://github.com/nodejs/node/commit/3a864d716e |
| #23800 | https://github.com/nodejs/node/pull/23800 |
| e7a573a9e2 | https://github.com/nodejs/node/commit/e7a573a9e2 |
| #23691 | https://github.com/nodejs/node/pull/23691 |
| ac91346776 | https://github.com/nodejs/node/commit/ac91346776 |
| #23768 | https://github.com/nodejs/node/pull/23768 |
| 0f98c4926a | https://github.com/nodejs/node/commit/0f98c4926a |
| #23771 | https://github.com/nodejs/node/pull/23771 |
| 73d19b1516 | https://github.com/nodejs/node/commit/73d19b1516 |
| #23678 | https://github.com/nodejs/node/pull/23678 |
| 544e64d68d | https://github.com/nodejs/node/commit/544e64d68d |
| #23787 | https://github.com/nodejs/node/pull/23787 |
| e84c01d1f3 | https://github.com/nodejs/node/commit/e84c01d1f3 |
| #23980 | https://github.com/nodejs/node/pull/23980 |
| 02209c5fa7 | https://github.com/nodejs/node/commit/02209c5fa7 |
| #23742 | https://github.com/nodejs/node/pull/23742 |
| 22043ccb84 | https://github.com/nodejs/node/commit/22043ccb84 |
| #23725 | https://github.com/nodejs/node/pull/23725 |
| 2a8a28c436 | https://github.com/nodejs/node/commit/2a8a28c436 |
| #23397 | https://github.com/nodejs/node/pull/23397 |
| c15d236545 | https://github.com/nodejs/node/commit/c15d236545 |
| #22452 | https://github.com/nodejs/node/pull/22452 |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
| November 28, 2018 11:26 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#commits-pushed-9bedae5 |
|
| https://patch-diff.githubusercontent.com/rvagg |
| deps: cherry-pick | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/9bedae52667d91e59a2d63d27a4211bf25890e29 |
| 6bc4bfe | https://github.com/nodejs/node/commit/6bc4bfeb07e894ea39449c1ad447f283a251b4b8 |
| from V8 upstream | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/9bedae52667d91e59a2d63d27a4211bf25890e29 |
| 9bedae5 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/9bedae52667d91e59a2d63d27a4211bf25890e29 |
| https://chromium-review.googlesource.com/927484 | https://chromium-review.googlesource.com/927484 |
| #52071 | https://github.com/nodejs/node/pull/52071 |
| #23958 | https://github.com/nodejs/node/pull/23958 |
|
| https://patch-diff.githubusercontent.com/rvagg |
| deps: cherry-pick d2e0166 from V8 upstream | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/50347297a106cd592c9638448eba611e09bb39e5 |
| 5034729 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/50347297a106cd592c9638448eba611e09bb39e5 |
| v8:8193 | https://bugs.chromium.org/p/v8/issues/detail?id=8193 |
| https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976 | https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976 |
| https://chromium-review.googlesource.com/1228633 | https://chromium-review.googlesource.com/1228633 |
| #56275 | https://github.com/nodejs/node/pull/56275 |
| #23958 | https://github.com/nodejs/node/pull/23958 |
|
| https://patch-diff.githubusercontent.com/rvagg |
| deps,v8: fix gyp build on Aix platform | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/4f3c9e6aab54ace23bda9266ffb6999f05ae2009 |
| 4f3c9e6 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/4f3c9e6aab54ace23bda9266ffb6999f05ae2009 |
| #23958 | https://github.com/nodejs/node/pull/23958 |
|
| https://patch-diff.githubusercontent.com/jasnell |
|
| https://patch-diff.githubusercontent.com/rvagg |
| doc: remove reference to sslv3 in tls.md | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/e2d2ce6706ee853b2da2d0e7cbdc76db93fa2992 |
| e2d2ce6 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/e2d2ce6706ee853b2da2d0e7cbdc76db93fa2992 |
| #23745 | https://github.com/nodejs/node/pull/23745 |
| #9822 | https://github.com/nodejs/node/issues/9822 |
|
| https://patch-diff.githubusercontent.com/Aiden01 |
|
| https://patch-diff.githubusercontent.com/rvagg |
| test: fix assertion arguments order | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/544e64d68dd1d9098602dbdaba1cf595880fc253 |
| 544e64d | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/544e64d68dd1d9098602dbdaba1cf595880fc253 |
| #23787 | https://github.com/nodejs/node/pull/23787 |
|
| https://patch-diff.githubusercontent.com/sam-github |
|
| https://patch-diff.githubusercontent.com/rvagg |
| test: ensure openssl version prints correctly | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/73d19b15160a39f40ef725ac353066079cd7b5df |
| 73d19b1 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/73d19b15160a39f40ef725ac353066079cd7b5df |
| #23678 | https://github.com/nodejs/node/pull/23678 |
|
| https://patch-diff.githubusercontent.com/fraxken |
|
| https://patch-diff.githubusercontent.com/rvagg |
| test: fix strictEqual() arguments order | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/0f98c4926a620379cff8dbee7cd4619c9f30f4a1 |
| 0f98c49 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/0f98c4926a620379cff8dbee7cd4619c9f30f4a1 |
| #23771 | https://github.com/nodejs/node/pull/23771 |
|
| https://patch-diff.githubusercontent.com/RomainLanz |
|
| https://patch-diff.githubusercontent.com/rvagg |
| test: fix strictEqual() argument order | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/ac9134677688643aa350931a0849e9aa60a67656 |
| ac91346 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/ac9134677688643aa350931a0849e9aa60a67656 |
| #23768 | https://github.com/nodejs/node/pull/23768 |
|
| https://patch-diff.githubusercontent.com/bzoz |
|
| https://patch-diff.githubusercontent.com/rvagg |
| test: fix test-require-symlink on Windows | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/e7a573a9e287aece608f05fecde900ff82efe2cf |
| e7a573a | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/e7a573a9e287aece608f05fecde900ff82efe2cf |
| #23596 | https://github.com/nodejs/node/issues/23596 |
| #23691 | https://github.com/nodejs/node/pull/23691 |
|
| https://patch-diff.githubusercontent.com/jasnell |
|
| https://patch-diff.githubusercontent.com/rvagg |
| doc: document that addMembership must be called once in a cluster | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/32ae851710a30f740aed0522b45fdd9d872c8db6 |
| 32ae851 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/32ae851710a30f740aed0522b45fdd9d872c8db6 |
| #12572 | https://github.com/nodejs/node/issues/12572 |
| #16240 | https://github.com/nodejs/node/pull/16240 |
| #23746 | https://github.com/nodejs/node/pull/23746 |
|
| https://patch-diff.githubusercontent.com/jasnell |
|
| https://patch-diff.githubusercontent.com/rvagg |
| doc: document ACL limitation for fs.access on Windows | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/0ff88a3510aeb07c0a5ae81360b55337423275fc |
| 0ff88a3 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/0ff88a3510aeb07c0a5ae81360b55337423275fc |
| #19192 | https://github.com/nodejs/node/issues/19192 |
| #23772 | https://github.com/nodejs/node/pull/23772 |
|
| https://patch-diff.githubusercontent.com/jasnell |
|
| https://patch-diff.githubusercontent.com/rvagg |
| doc: add note about removeListener order | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/e5f75cf82ec182cc97e94dc121623bc493444d94 |
| e5f75cf | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/e5f75cf82ec182cc97e94dc121623bc493444d94 |
| #21635 | https://github.com/nodejs/node/issues/21635 |
| #23762 | https://github.com/nodejs/node/pull/23762 |
|
| https://patch-diff.githubusercontent.com/phillipj |
|
| https://patch-diff.githubusercontent.com/rvagg |
| doc: move | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/f037942fe7a94b7bff638bb0e0255c55fa720f63 |
| @phillipj | https://github.com/phillipj |
| to emeriti | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/f037942fe7a94b7bff638bb0e0255c55fa720f63 |
| f037942 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/f037942fe7a94b7bff638bb0e0255c55fa720f63 |
| @phillipj | https://github.com/phillipj |
| #23790 | https://github.com/nodejs/node/pull/23790 |
|
| https://patch-diff.githubusercontent.com/srl295 |
|
| https://patch-diff.githubusercontent.com/rvagg |
| deps: icu: apply workaround patch | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/34d91296df859be3f6eb6ac52b4800953d863043 |
| 34d9129 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/34d91296df859be3f6eb6ac52b4800953d863043 |
| https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 | https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 |
| https://unicode-org.atlassian.net/browse/ICU-20063 | https://unicode-org.atlassian.net/browse/ICU-20063 |
| #22156 | https://github.com/nodejs/node/issues/22156 |
| #23764 | https://github.com/nodejs/node/pull/23764 |
|
| https://patch-diff.githubusercontent.com/danbev |
|
| https://patch-diff.githubusercontent.com/rvagg |
| crypto: add SET_INTEGER_CONSANT macro | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/499605618bcbadb5544a6a6f514ed836c03dc590 |
| 4996056 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/499605618bcbadb5544a6a6f514ed836c03dc590 |
| #23687 | https://github.com/nodejs/node/pull/23687 |
|
| https://patch-diff.githubusercontent.com/ErickWendel |
|
| https://patch-diff.githubusercontent.com/rvagg |
| doc: add review suggestions to require() | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/3f2a01688ddd641630d0424b27c4efc746e00ba7 |
| 3f2a016 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/3f2a01688ddd641630d0424b27c4efc746e00ba7 |
| #23605 | https://github.com/nodejs/node/pull/23605 |
|
| https://patch-diff.githubusercontent.com/rvagg |
| test: fix strictEqual() arguments order | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/3a864d716e448e8f06144335ee7b87ba94d3d13e |
| 3a864d7 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/3a864d716e448e8f06144335ee7b87ba94d3d13e |
| #23800 | https://github.com/nodejs/node/pull/23800 |
|
| https://patch-diff.githubusercontent.com/codebytere |
|
| https://patch-diff.githubusercontent.com/rvagg |
| build: allow for overwriting of use_openssl_def | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/f70e79a7b2f7a03d500deae38ecd461e0f46c7c9 |
| f70e79a | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/f70e79a7b2f7a03d500deae38ecd461e0f46c7c9 |
| #23763 | https://github.com/nodejs/node/pull/23763 |
|
| https://patch-diff.githubusercontent.com/addaleax |
|
| https://patch-diff.githubusercontent.com/rvagg |
| build: initial .travis.yml implementation | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/7612024939a0031b6119c3888c662e357d985666 |
| 7612024 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/7612024939a0031b6119c3888c662e357d985666 |
| ayojs/ayo#14 | https://github.com/ayojs/ayo/pull/14 |
| ayojs/ayo#75 | https://github.com/ayojs/ayo/pull/75 |
| #21059 | https://github.com/nodejs/node/pull/21059 |
|
| https://patch-diff.githubusercontent.com/richardlau |
|
| https://patch-diff.githubusercontent.com/rvagg |
| build: install markdown linter for travis | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/1da04c208d8350737d3121c13f6d72d2f4210ad1 |
| 1da04c2 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/1da04c208d8350737d3121c13f6d72d2f4210ad1 |
| #21215 | https://github.com/nodejs/node/pull/21215 |
|
| https://patch-diff.githubusercontent.com/TimothyGu |
|
| https://patch-diff.githubusercontent.com/rvagg |
| build: improve Travis CI settings | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/26743369d3530a8500f7946d15cc8ea6bd6d3fad |
| 2674336 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/26743369d3530a8500f7946d15cc8ea6bd6d3fad |
| #21459 | https://github.com/nodejs/node/pull/21459 |
|
| https://patch-diff.githubusercontent.com/refack |
|
| https://patch-diff.githubusercontent.com/rvagg |
| build,tools: tweak the travis config | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/313ef6fa7312bb30c9f95922dd1cfbd3eee6cf27 |
| 313ef6f | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/313ef6fa7312bb30c9f95922dd1cfbd3eee6cf27 |
| #22417 | https://github.com/nodejs/node/pull/22417 |
|
| https://patch-diff.githubusercontent.com/targos |
|
| https://patch-diff.githubusercontent.com/rvagg |
| build,doc: remove outdated lint-md-build | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/15d1f67c602ac0e1ed58bc77698d52a8599dcff7 |
| 15d1f67 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/15d1f67c602ac0e1ed58bc77698d52a8599dcff7 |
| #20109 | https://github.com/nodejs/node/pull/20109 |
| #22991 | https://github.com/nodejs/node/pull/22991 |
|
| https://patch-diff.githubusercontent.com/Trott |
|
| https://patch-diff.githubusercontent.com/rvagg |
| tools: apply linting to first commit in PRs | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/c15d2365450273d194f91647990183b6a9c2f8ad |
| c15d236 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/c15d2365450273d194f91647990183b6a9c2f8ad |
| #22452 | https://github.com/nodejs/node/pull/22452 |
|
| https://patch-diff.githubusercontent.com/Trott |
|
| https://patch-diff.githubusercontent.com/rvagg |
| tools: make Travis commit linting more robust | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/2a8a28c43660a9e502e52d417faaff1fb7fd4d0f |
| 2a8a28c | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/2a8a28c43660a9e502e52d417faaff1fb7fd4d0f |
| #23307 (comment) | https://github.com/nodejs/node/pull/23307#issuecomment-428435859 |
| #23397 | https://github.com/nodejs/node/pull/23397 |
|
| https://patch-diff.githubusercontent.com/Trott |
|
| https://patch-diff.githubusercontent.com/rvagg |
| tools: do not lint commit message if var undefined | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/22043ccb840119337bca8d61f578b6ea1143257d |
| 22043cc | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/22043ccb840119337bca8d61f578b6ea1143257d |
| #23572 (comment) | https://github.com/nodejs/node/pull/23572#issuecomment-430850382 |
| #22842 (comment) | https://github.com/nodejs/node/pull/22842#issuecomment-430850049 |
| #23725 | https://github.com/nodejs/node/pull/23725 |
|
| https://patch-diff.githubusercontent.com/Trott |
|
| https://patch-diff.githubusercontent.com/rvagg |
| tools: clarify commit message linting | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/02209c5fa7d5d76307d7d3adc0f2d1e2ce0b1f88 |
| 02209c5 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/02209c5fa7d5d76307d7d3adc0f2d1e2ce0b1f88 |
| #23742 | https://github.com/nodejs/node/pull/23742 |
|
| https://patch-diff.githubusercontent.com/refack |
|
| https://patch-diff.githubusercontent.com/rvagg |
| build,meta: switch to gcc-4.9 on travis | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/85a6daeaef5e5f0cb9d3028e6ec0a8d80bd4dba6 |
| 85a6dae | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/85a6daeaef5e5f0cb9d3028e6ec0a8d80bd4dba6 |
| #23778 | https://github.com/nodejs/node/pull/23778 |
|
| https://patch-diff.githubusercontent.com/ZYSzys |
|
| https://patch-diff.githubusercontent.com/rvagg |
| doc: simplify path.basename() on POSIX and Windows | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/9afdc09f98be5da7abeb4be2f8950431182b0bf7 |
| 9afdc09 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/9afdc09f98be5da7abeb4be2f8950431182b0bf7 |
| #23864 | https://github.com/nodejs/node/pull/23864 |
|
| https://patch-diff.githubusercontent.com/lveteau |
|
| https://patch-diff.githubusercontent.com/rvagg |
| test: fix strictEqual() argument order | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/d0368b8245479ce644b5d1ec5d076a504f342b9b |
| d0368b8 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/d0368b8245479ce644b5d1ec5d076a504f342b9b |
| #23829 | https://github.com/nodejs/node/pull/23829 |
| https://patch-diff.githubusercontent.com/richardlau |
| richardlau | https://patch-diff.githubusercontent.com/richardlau |
|
Dec 4, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#pullrequestreview-181416383 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/files |
| doc/changelogs/CHANGELOG_V8.md | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/files#diff-1ec40ab5f20e9d1462efb347e4a49f31f864e692daa59f8d2c04179dcbe76f7f |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
| https://patch-diff.githubusercontent.com/richardlau |
| richardlau | https://patch-diff.githubusercontent.com/richardlau |
| Dec 4, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#issuecomment-444213393 |
| nodejs/Release#376 | https://github.com/nodejs/Release/issues/376 |
| last planned active release | https://github.com/nodejs/Release/wiki |
| only critical bugs, critical security fixes, and documentation updates will be permitted | https://github.com/nodejs/Release#release-plan |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
| https://patch-diff.githubusercontent.com/BethGriggs |
| BethGriggs | https://patch-diff.githubusercontent.com/BethGriggs |
| force-pushed | https://patch-diff.githubusercontent.com/nodejs/node/compare/1f271336a48bf9b68babc2f1913a8b7ab8c063ea..5c7cb5381c42653edd730f0be733f69ff7347c45 |
| 1f27133 | https://patch-diff.githubusercontent.com/nodejs/node/commit/1f271336a48bf9b68babc2f1913a8b7ab8c063ea |
| 5c7cb53 | https://patch-diff.githubusercontent.com/nodejs/node/commit/5c7cb5381c42653edd730f0be733f69ff7347c45 |
|
Compare
| https://patch-diff.githubusercontent.com/nodejs/node/compare/1f271336a48bf9b68babc2f1913a8b7ab8c063ea..5c7cb5381c42653edd730f0be733f69ff7347c45 |
| December 4, 2018 20:47 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#event-2005431420 |
| BethGriggs | https://patch-diff.githubusercontent.com/BethGriggs |
|
Dec 4, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#ref-commit-5c7cb53 |
|
| https://patch-diff.githubusercontent.com/BethGriggs |
| 2018-12-18, Version 8.14.1 'Carbon' (LTS) | https://patch-diff.githubusercontent.com/nodejs/node/commit/5c7cb5381c42653edd730f0be733f69ff7347c45 |
| 5c7cb53 | https://patch-diff.githubusercontent.com/nodejs/node/commit/5c7cb5381c42653edd730f0be733f69ff7347c45 |
| #24832 | https://github.com/nodejs/node/pull/24832 |
| https://patch-diff.githubusercontent.com/BethGriggs |
| BethGriggs | https://patch-diff.githubusercontent.com/BethGriggs |
| Dec 4, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#issuecomment-444255012 |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
| https://ci.nodejs.org/job/node-test-pull-request/19206/ | https://ci.nodejs.org/job/node-test-pull-request/19206/ |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1915/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/1915/ |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
| https://patch-diff.githubusercontent.com/BethGriggs |
| BethGriggs | https://patch-diff.githubusercontent.com/BethGriggs |
| Dec 5, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#issuecomment-444546199 |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1666/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1666/ |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
| https://patch-diff.githubusercontent.com/BethGriggs |
| BethGriggs | https://patch-diff.githubusercontent.com/BethGriggs |
| Dec 5, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#issuecomment-444564200 |
| https://nodejs.org/download/rc/v8.14.1-rc.1/ | https://nodejs.org/download/rc/v8.14.1-rc.1/ |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
| https://patch-diff.githubusercontent.com/BridgeAR |
| BridgeAR | https://patch-diff.githubusercontent.com/BridgeAR |
| Dec 5, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#issuecomment-444568384 |
| @BethGriggs | https://github.com/BethGriggs |
| #24786 | https://github.com/nodejs/node/pull/24786 |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
| aautio | https://patch-diff.githubusercontent.com/aautio |
| December 10, 2018 12:36 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#commits-pushed-6922231 |
|
| https://patch-diff.githubusercontent.com/aautio |
|
| https://patch-diff.githubusercontent.com/MylesBorins |
| doc: fix api documentation of http.createServer | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/692223182cc2700eb362218dae50b49fdcd56a93 |
| 6922231 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/692223182cc2700eb362218dae50b49fdcd56a93 |
| #24105 | https://github.com/nodejs/node/issues/24105 |
| #24869 | https://github.com/nodejs/node/pull/24869 |
|
| https://patch-diff.githubusercontent.com/Tiriel |
|
| https://patch-diff.githubusercontent.com/MylesBorins |
| doc: add description for inspector-only console methods. | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/74c1074d53046138947e546462b21c1f216d81c7 |
| 74c1074 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/74c1074d53046138947e546462b21c1f216d81c7 |
| #17004 | https://github.com/nodejs/node/pull/17004 |
| #16755 | https://github.com/nodejs/node/issues/16755 |
|
| https://patch-diff.githubusercontent.com/BridgeAR |
|
| https://patch-diff.githubusercontent.com/BethGriggs |
| assert: revert breaking change | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/62fb5dbec557745f9f828d728ca25f327ca5300c |
| 62fb5db | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/62fb5dbec557745f9f828d728ca25f327ca5300c |
| #23223 | https://github.com/nodejs/node/pull/23223 |
| #24786 | https://github.com/nodejs/node/pull/24786 |
| #23223 | https://github.com/nodejs/node/pull/23223 |
|
| https://patch-diff.githubusercontent.com/MylesBorins |
|
| https://patch-diff.githubusercontent.com/BethGriggs |
| test: verify order of error in h2 server stream | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/394cb42962f542127ab3e8309d3143319ab44226 |
| 394cb42 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/394cb42962f542127ab3e8309d3143319ab44226 |
| #24685 | https://github.com/nodejs/node/pull/24685 |
|
| https://patch-diff.githubusercontent.com/Flarna |
|
| https://patch-diff.githubusercontent.com/BethGriggs |
| http2: fix sequence of error/close events | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/4c24a82a654e1d9561af5e47ad98a31c34bca5c3 |
| 4c24a82 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/4c24a82a654e1d9561af5e47ad98a31c34bca5c3 |
| #24789 | https://github.com/nodejs/node/pull/24789 |
| #22850 | https://github.com/nodejs/node/pull/22850 |
| #24685 | https://github.com/nodejs/node/pull/24685 |
| #24559 | https://github.com/nodejs/node/issues/24559 |
| https://patch-diff.githubusercontent.com/BethGriggs |
| BethGriggs | https://patch-diff.githubusercontent.com/BethGriggs |
| force-pushed | https://patch-diff.githubusercontent.com/nodejs/node/compare/5c7cb5381c42653edd730f0be733f69ff7347c45..9fc8d9ac5dd6d1514a44740e896bb50e803a8c55 |
| 5c7cb53 | https://patch-diff.githubusercontent.com/nodejs/node/commit/5c7cb5381c42653edd730f0be733f69ff7347c45 |
| 9fc8d9a | https://patch-diff.githubusercontent.com/nodejs/node/commit/9fc8d9ac5dd6d1514a44740e896bb50e803a8c55 |
|
Compare
| https://patch-diff.githubusercontent.com/nodejs/node/compare/5c7cb5381c42653edd730f0be733f69ff7347c45..9fc8d9ac5dd6d1514a44740e896bb50e803a8c55 |
| December 11, 2018 17:14 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#event-2019326504 |
| BethGriggs | https://patch-diff.githubusercontent.com/BethGriggs |
|
Dec 11, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#ref-commit-9fc8d9a |
|
| https://patch-diff.githubusercontent.com/BethGriggs |
| 2018-12-18, Version 8.14.1 'Carbon' (LTS) | https://patch-diff.githubusercontent.com/nodejs/node/commit/9fc8d9ac5dd6d1514a44740e896bb50e803a8c55 |
| 9fc8d9a | https://patch-diff.githubusercontent.com/nodejs/node/commit/9fc8d9ac5dd6d1514a44740e896bb50e803a8c55 |
| #24786 | https://github.com/nodejs/node/pull/24786 |
| #24786 | https://github.com/nodejs/node/pull/24786 |
| #24789 | https://github.com/nodejs/node/pull/24789 |
| #24789 | https://github.com/nodejs/node/pull/24789 |
| #24832 | https://github.com/nodejs/node/pull/24832 |
| https://patch-diff.githubusercontent.com/BethGriggs |
| BethGriggs | https://patch-diff.githubusercontent.com/BethGriggs |
| Dec 11, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#issuecomment-446295933 |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
| https://ci.nodejs.org/job/node-test-pull-request/19424 | https://ci.nodejs.org/job/node-test-pull-request/19424 |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/1931/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/1931/ |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
| https://patch-diff.githubusercontent.com/MylesBorins |
| MylesBorins | https://patch-diff.githubusercontent.com/MylesBorins |
| Dec 12, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#issuecomment-446479706 |
| https://nodejs.org/download/rc/v8.14.1-rc.2/ | https://nodejs.org/download/rc/v8.14.1-rc.2/ |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
| https://patch-diff.githubusercontent.com/MylesBorins |
| MylesBorins | https://patch-diff.githubusercontent.com/MylesBorins |
| Dec 15, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#issuecomment-447584729 |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1689/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1689/ |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
| https://patch-diff.githubusercontent.com/Trott |
| Trott | https://patch-diff.githubusercontent.com/Trott |
| Dec 17, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#issuecomment-447971258 |
| https://ci.nodejs.org/job/node-test-pull-request/19611/ | https://ci.nodejs.org/job/node-test-pull-request/19611/ |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
| https://patch-diff.githubusercontent.com/MylesBorins |
| MylesBorins | https://patch-diff.githubusercontent.com/MylesBorins |
| force-pushed | https://patch-diff.githubusercontent.com/nodejs/node/compare/9fc8d9ac5dd6d1514a44740e896bb50e803a8c55..ab0abb148f4fffe5b0cc764cca530b6b5b3ba71e |
| 9fc8d9a | https://patch-diff.githubusercontent.com/nodejs/node/commit/9fc8d9ac5dd6d1514a44740e896bb50e803a8c55 |
| ab0abb1 | https://patch-diff.githubusercontent.com/nodejs/node/commit/ab0abb148f4fffe5b0cc764cca530b6b5b3ba71e |
|
Compare
| https://patch-diff.githubusercontent.com/nodejs/node/compare/9fc8d9ac5dd6d1514a44740e896bb50e803a8c55..ab0abb148f4fffe5b0cc764cca530b6b5b3ba71e |
| December 18, 2018 05:13 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#event-2032042529 |
| https://patch-diff.githubusercontent.com/MylesBorins |
| MylesBorins | https://patch-diff.githubusercontent.com/MylesBorins |
| Dec 18, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#issuecomment-448101741 |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
|
| https://patch-diff.githubusercontent.com/BethGriggs |
|
| https://patch-diff.githubusercontent.com/MylesBorins |
| 2018-12-18, Version 8.14.1 'Carbon' (LTS) | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/187694e2fa59d71577f9ee99c6d1a3d04c80c37d |
| 187694e | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/commits/187694e2fa59d71577f9ee99c6d1a3d04c80c37d |
| #24786 | https://github.com/nodejs/node/pull/24786 |
| #24786 | https://github.com/nodejs/node/pull/24786 |
| #24789 | https://github.com/nodejs/node/pull/24789 |
| #24789 | https://github.com/nodejs/node/pull/24789 |
| #24832 | https://github.com/nodejs/node/pull/24832 |
| https://patch-diff.githubusercontent.com/MylesBorins |
| MylesBorins | https://patch-diff.githubusercontent.com/MylesBorins |
| force-pushed | https://patch-diff.githubusercontent.com/nodejs/node/compare/ab0abb148f4fffe5b0cc764cca530b6b5b3ba71e..187694e2fa59d71577f9ee99c6d1a3d04c80c37d |
| ab0abb1 | https://patch-diff.githubusercontent.com/nodejs/node/commit/ab0abb148f4fffe5b0cc764cca530b6b5b3ba71e |
| 187694e | https://patch-diff.githubusercontent.com/nodejs/node/commit/187694e2fa59d71577f9ee99c6d1a3d04c80c37d |
|
Compare
| https://patch-diff.githubusercontent.com/nodejs/node/compare/ab0abb148f4fffe5b0cc764cca530b6b5b3ba71e..187694e2fa59d71577f9ee99c6d1a3d04c80c37d |
| December 18, 2018 05:43 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#event-2032074830 |
| https://patch-diff.githubusercontent.com/MylesBorins |
| MylesBorins | https://patch-diff.githubusercontent.com/MylesBorins |
| 187694e | https://patch-diff.githubusercontent.com/nodejs/node/commit/187694e2fa59d71577f9ee99c6d1a3d04c80c37d |
| Dec 18, 2018 | https://github.com/nodejs/node/pull/24832#event-2033456401 |
| MylesBorins | https://patch-diff.githubusercontent.com/MylesBorins |
|
Dec 18, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#ref-commit-b0c4207 |
|
| https://patch-diff.githubusercontent.com/MylesBorins |
| Working on v8.14.2 | https://patch-diff.githubusercontent.com/nodejs/node/commit/b0c4207659f229c8479396bad14471cdcefab627 |
| b0c4207 | https://patch-diff.githubusercontent.com/nodejs/node/commit/b0c4207659f229c8479396bad14471cdcefab627 |
| #24832 | https://github.com/nodejs/node/pull/24832 |
| MylesBorins | https://patch-diff.githubusercontent.com/MylesBorins |
|
Dec 18, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#ref-commit-1cbd377 |
|
| https://patch-diff.githubusercontent.com/BethGriggs |
|
| https://patch-diff.githubusercontent.com/MylesBorins |
| 2018-12-18, Version 8.14.1 'Carbon' (LTS) | https://patch-diff.githubusercontent.com/nodejs/node/commit/1cbd377078cd07447a6877fb9f844dd949a1cd43 |
| 1cbd377 | https://patch-diff.githubusercontent.com/nodejs/node/commit/1cbd377078cd07447a6877fb9f844dd949a1cd43 |
| #24786 | https://github.com/nodejs/node/pull/24786 |
| #24786 | https://github.com/nodejs/node/pull/24786 |
| #24789 | https://github.com/nodejs/node/pull/24789 |
| #24789 | https://github.com/nodejs/node/pull/24789 |
| #24832 | https://github.com/nodejs/node/pull/24832 |
| https://patch-diff.githubusercontent.com/MylesBorins |
| MylesBorins | https://patch-diff.githubusercontent.com/MylesBorins |
|
Dec 18, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#ref-pullrequest-392237588 |
|
blog: release post for v8.14.1
nodejs/nodejs.org#1949
| https://patch-diff.githubusercontent.com/nodejs/nodejs.org/pull/1949 |
| refack | https://patch-diff.githubusercontent.com/refack |
|
Jan 14, 2019
| https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#ref-commit-d28c3af |
|
| https://patch-diff.githubusercontent.com/BethGriggs |
|
| https://patch-diff.githubusercontent.com/refack |
| 2018-12-18, Version 8.14.1 'Carbon' (LTS) | https://patch-diff.githubusercontent.com/refack/node/commit/d28c3af828986ce8b7286d103c1167a402e29cfb |
| d28c3af | https://patch-diff.githubusercontent.com/refack/node/commit/d28c3af828986ce8b7286d103c1167a402e29cfb |
| nodejs#24786 | https://github.com/nodejs/node/pull/24786 |
| nodejs#24786 | https://github.com/nodejs/node/pull/24786 |
| nodejs#24789 | https://github.com/nodejs/node/pull/24789 |
| nodejs#24789 | https://github.com/nodejs/node/pull/24789 |
| nodejs#24832 | https://github.com/nodejs/node/pull/24832 |
| https://patch-diff.githubusercontent.com/BethGriggs |
| BethGriggs | https://patch-diff.githubusercontent.com/BethGriggs |
| March 5, 2019 17:38 | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832#event-2181705090 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F24832 |
|
| https://patch-diff.githubusercontent.com/richardlau |
|
richardlau
| https://patch-diff.githubusercontent.com/richardlau |
|
| https://patch-diff.githubusercontent.com/nodejs/node/pull/24832/files/1f271336a48bf9b68babc2f1913a8b7ab8c063ea |
|
build
| https://patch-diff.githubusercontent.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
doc
| https://patch-diff.githubusercontent.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
meta
| https://patch-diff.githubusercontent.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
|
v8 engine
| https://patch-diff.githubusercontent.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
|
| https://patch-diff.githubusercontent.com/BethGriggs |
|
| https://patch-diff.githubusercontent.com/nodejs-github-bot |
|
| https://patch-diff.githubusercontent.com/richardlau |
|
| https://patch-diff.githubusercontent.com/BridgeAR |
|
| https://patch-diff.githubusercontent.com/MylesBorins |
|
| https://patch-diff.githubusercontent.com/Trott |
|
| https://patch-diff.githubusercontent.com/jasnell |
|
| https://patch-diff.githubusercontent.com/Aiden01 |
|
| https://patch-diff.githubusercontent.com/sam-github |
|
| https://patch-diff.githubusercontent.com/fraxken |
|
| https://patch-diff.githubusercontent.com/RomainLanz |
|
| https://patch-diff.githubusercontent.com/bzoz |
|
| https://patch-diff.githubusercontent.com/phillipj |
|
| https://patch-diff.githubusercontent.com/srl295 |
|
| https://patch-diff.githubusercontent.com/danbev |
|
| https://patch-diff.githubusercontent.com/ErickWendel |
|
| https://patch-diff.githubusercontent.com/codebytere |
|
| https://patch-diff.githubusercontent.com/addaleax |
|
| https://patch-diff.githubusercontent.com/TimothyGu |
|
| https://patch-diff.githubusercontent.com/refack |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |