| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d0ffa286-3ca7-0729-5023-974f7a2f0ccc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D0A8:8D4A2:F690AE:13D6DF9:698FD415 |
| html-safe-nonce | 85ce2eb5f9e29e026c84e4205ce29ed34c4663c5a9007fae3f46846b6bc00a37 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMEE4OjhENEEyOkY2OTBBRToxM0Q2REY5OjY5OEZENDE1IiwidmlzaXRvcl9pZCI6Ijg4ODEwOTk3NzY5MTA2NzcwMTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4f51c8d914eef5631ff8e68a2ddd46d9bafc22c0f3548df68d62c657e87d2b2d |
| hovercard-subject-tag | pull_request:226581392 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/23956/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/df62a766344255b84e4e9c9806d0e436ef8d6824469d669a4d5bee45ded90c83/nodejs/node/pull/23956 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/df62a766344255b84e4e9c9806d0e436ef8d6824469d669a4d5bee45ded90c83/nodejs/node/pull/23956 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows)
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Westixy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d320682233dfd4d28c0b30554a564c2fcd229032 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23956 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23956 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956 |
| Reload | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956 |
| Reload | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956 |
|
nodejs
| https://patch-diff.githubusercontent.com/nodejs |
| node | https://patch-diff.githubusercontent.com/nodejs/node |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956 |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://patch-diff.githubusercontent.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://patch-diff.githubusercontent.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://patch-diff.githubusercontent.com/nodejs/node |
|
Issues
1.7k
| https://patch-diff.githubusercontent.com/nodejs/node/issues |
|
Pull requests
710
| https://patch-diff.githubusercontent.com/nodejs/node/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/nodejs/node/actions |
|
Projects
3
| https://patch-diff.githubusercontent.com/nodejs/node/projects |
|
Security
0
| https://patch-diff.githubusercontent.com/nodejs/node/security |
|
Insights
| https://patch-diff.githubusercontent.com/nodejs/node/pulse |
|
Code
| https://patch-diff.githubusercontent.com/nodejs/node |
|
Issues
| https://patch-diff.githubusercontent.com/nodejs/node/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/nodejs/node/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/nodejs/node/actions |
|
Projects
| https://patch-diff.githubusercontent.com/nodejs/node/projects |
|
Security
| https://patch-diff.githubusercontent.com/nodejs/node/security |
|
Insights
| https://patch-diff.githubusercontent.com/nodejs/node/pulse |
| Westixy | https://patch-diff.githubusercontent.com/Westixy |
| nodejs:master | https://patch-diff.githubusercontent.com/nodejs/node/tree/master |
| Westixy-FORK:master | https://patch-diff.githubusercontent.com/Westixy-FORK/node/tree/master |
| Conversation | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956 |
| Commits1 (1) | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956/commits |
| Checks | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956/checks |
| Files changed | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956/files |
| test: Fix strictEqual arguments order | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#top |
| Westixy | https://patch-diff.githubusercontent.com/Westixy |
| nodejs:master | https://patch-diff.githubusercontent.com/nodejs/node/tree/master |
| Westixy-FORK:master | https://patch-diff.githubusercontent.com/Westixy-FORK/node/tree/master |
|
| https://patch-diff.githubusercontent.com/Westixy |
| Westixy | https://patch-diff.githubusercontent.com/Westixy |
| Oct 29, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#issue-375043274 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956 |
| https://patch-diff.githubusercontent.com/nodejs-github-bot |
| nodejs-github-bot | https://patch-diff.githubusercontent.com/nodejs-github-bot |
|
test
| https://patch-diff.githubusercontent.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Oct 29, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#event-1932391196 |
| https://patch-diff.githubusercontent.com/cjihrig |
| cjihrig | https://patch-diff.githubusercontent.com/cjihrig |
|
Oct 29, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#pullrequestreview-169330172 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956/files |
| https://patch-diff.githubusercontent.com/targos |
| targos | https://patch-diff.githubusercontent.com/targos |
|
Oct 29, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#pullrequestreview-169331637 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956/files |
| https://patch-diff.githubusercontent.com/targos |
| targos | https://patch-diff.githubusercontent.com/targos |
|
fast-track
| https://patch-diff.githubusercontent.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Oct 29, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#event-1932407813 |
| https://patch-diff.githubusercontent.com/targos |
| targos | https://patch-diff.githubusercontent.com/targos |
| Oct 29, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#issuecomment-433933106 |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956 |
| https://patch-diff.githubusercontent.com/targos |
| targos | https://patch-diff.githubusercontent.com/targos |
| Oct 29, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#issuecomment-433933527 |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956 |
| https://patch-diff.githubusercontent.com/jasnell |
| jasnell | https://patch-diff.githubusercontent.com/jasnell |
|
Oct 29, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#pullrequestreview-169334209 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956/files |
|
| https://patch-diff.githubusercontent.com/Westixy |
| test: fix strictEqual arguments order | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956/commits/566bc4e77394902c5a9af4324850c44b88c00033 |
| 566bc4e | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956/commits/566bc4e77394902c5a9af4324850c44b88c00033 |
| https://patch-diff.githubusercontent.com/Westixy |
| Westixy | https://patch-diff.githubusercontent.com/Westixy |
| force-pushed | https://patch-diff.githubusercontent.com/nodejs/node/compare/e379d72cebb3046eacf8f55015f35bb6140278e2..566bc4e77394902c5a9af4324850c44b88c00033 |
| e379d72 | https://patch-diff.githubusercontent.com/nodejs/node/commit/e379d72cebb3046eacf8f55015f35bb6140278e2 |
| 566bc4e | https://patch-diff.githubusercontent.com/nodejs/node/commit/566bc4e77394902c5a9af4324850c44b88c00033 |
|
Compare
| https://patch-diff.githubusercontent.com/nodejs/node/compare/e379d72cebb3046eacf8f55015f35bb6140278e2..566bc4e77394902c5a9af4324850c44b88c00033 |
| October 29, 2018 14:41 | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#event-1932430555 |
| https://patch-diff.githubusercontent.com/trivikr |
| trivikr | https://patch-diff.githubusercontent.com/trivikr |
|
Oct 30, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#pullrequestreview-169588821 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956/files/566bc4e77394902c5a9af4324850c44b88c00033 |
| https://patch-diff.githubusercontent.com/trivikr |
| trivikr | https://patch-diff.githubusercontent.com/trivikr |
|
author ready
| https://patch-diff.githubusercontent.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 30, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#event-1933892598 |
| https://patch-diff.githubusercontent.com/fhinkel |
| fhinkel | https://patch-diff.githubusercontent.com/fhinkel |
|
Oct 30, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#pullrequestreview-169679611 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956/files/566bc4e77394902c5a9af4324850c44b88c00033 |
| https://patch-diff.githubusercontent.com/Trott |
| Trott | https://patch-diff.githubusercontent.com/Trott |
| Nov 2, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#issuecomment-435248307 |
| https://ci.nodejs.org/job/node-test-pull-request/18287/ | https://ci.nodejs.org/job/node-test-pull-request/18287/ |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956 |
| Trott | https://patch-diff.githubusercontent.com/Trott |
|
Nov 2, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#ref-commit-4f5be97 |
|
| https://patch-diff.githubusercontent.com/Westixy |
|
| https://patch-diff.githubusercontent.com/Trott |
| test: fix strictEqual arguments order | https://patch-diff.githubusercontent.com/Trott/io.js/commit/4f5be97e8dc40f005b18fc67209cd61abb7bcd71 |
| 4f5be97 | https://patch-diff.githubusercontent.com/Trott/io.js/commit/4f5be97e8dc40f005b18fc67209cd61abb7bcd71 |
| nodejs#23956 | https://github.com/nodejs/node/pull/23956 |
| https://patch-diff.githubusercontent.com/Trott |
| Trott | https://patch-diff.githubusercontent.com/Trott |
| Nov 2, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#issuecomment-435259471 |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956 |
| https://patch-diff.githubusercontent.com/Trott |
| Trott | https://patch-diff.githubusercontent.com/Trott |
| Nov 2, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#event-1942065244 |
| targos | https://patch-diff.githubusercontent.com/targos |
|
Nov 2, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#ref-commit-63778b7 |
|
| https://patch-diff.githubusercontent.com/Westixy |
|
| https://patch-diff.githubusercontent.com/targos |
| test: fix strictEqual arguments order | https://patch-diff.githubusercontent.com/nodejs/node/commit/63778b7ae1753dbd252797df577d11f52433eafd |
| 63778b7 | https://patch-diff.githubusercontent.com/nodejs/node/commit/63778b7ae1753dbd252797df577d11f52433eafd |
| #23956 | https://github.com/nodejs/node/pull/23956 |
| https://patch-diff.githubusercontent.com/BridgeAR |
| BridgeAR | https://patch-diff.githubusercontent.com/BridgeAR |
|
Nov 14, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#ref-pullrequest-380492752 |
|
Release proposal: v11.2
#24350
| https://patch-diff.githubusercontent.com/nodejs/node/pull/24350 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#232
| https://patch-diff.githubusercontent.com/beevelop/docker-nodejs/issues/232 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-android-nodejs#249
| https://patch-diff.githubusercontent.com/beevelop/docker-android-nodejs/issues/249 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#233
| https://patch-diff.githubusercontent.com/beevelop/docker-nodejs/issues/233 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#234
| https://patch-diff.githubusercontent.com/beevelop/docker-nodejs/issues/234 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#235
| https://patch-diff.githubusercontent.com/beevelop/docker-nodejs/issues/235 |
|
2018-11-15 Version 11.2.0 (Current) @BridgeAR
beevelop/docker-nodejs#236
| https://patch-diff.githubusercontent.com/beevelop/docker-nodejs/issues/236 |
| https://patch-diff.githubusercontent.com/MylesBorins |
| MylesBorins | https://patch-diff.githubusercontent.com/MylesBorins |
|
land-on-v8.x
| https://patch-diff.githubusercontent.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x |
| Nov 27, 2018 | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#event-1988750500 |
| MylesBorins | https://patch-diff.githubusercontent.com/MylesBorins |
|
Nov 27, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#ref-commit-480ae4f |
|
| https://patch-diff.githubusercontent.com/Westixy |
|
| https://patch-diff.githubusercontent.com/MylesBorins |
| test: fix strictEqual arguments order | https://patch-diff.githubusercontent.com/nodejs/node/commit/480ae4f5467b28a0d8db14adecf303dcf2eb242e |
| 480ae4f | https://patch-diff.githubusercontent.com/nodejs/node/commit/480ae4f5467b28a0d8db14adecf303dcf2eb242e |
| #23956 | https://github.com/nodejs/node/pull/23956 |
| MylesBorins | https://patch-diff.githubusercontent.com/MylesBorins |
|
Nov 27, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#ref-commit-31eff10 |
|
| https://patch-diff.githubusercontent.com/Westixy |
|
| https://patch-diff.githubusercontent.com/MylesBorins |
| test: fix strictEqual arguments order | https://patch-diff.githubusercontent.com/nodejs/node/commit/31eff105e0ff9f57d4ac45017ed5fe2b79beea63 |
| 31eff10 | https://patch-diff.githubusercontent.com/nodejs/node/commit/31eff105e0ff9f57d4ac45017ed5fe2b79beea63 |
| #23956 | https://github.com/nodejs/node/pull/23956 |
| https://patch-diff.githubusercontent.com/codebytere |
| codebytere | https://patch-diff.githubusercontent.com/codebytere |
|
Nov 27, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#ref-pullrequest-384882602 |
|
v10.13.1 proposal
#24675
| https://patch-diff.githubusercontent.com/nodejs/node/pull/24675 |
| rvagg | https://patch-diff.githubusercontent.com/rvagg |
|
Nov 28, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#ref-commit-d34ade8 |
|
| https://patch-diff.githubusercontent.com/Westixy |
|
| https://patch-diff.githubusercontent.com/rvagg |
| test: fix strictEqual arguments order | https://patch-diff.githubusercontent.com/nodejs/node/commit/d34ade875595caa8be42d0cbfdd02659b0748760 |
| d34ade8 | https://patch-diff.githubusercontent.com/nodejs/node/commit/d34ade875595caa8be42d0cbfdd02659b0748760 |
| #23956 | https://github.com/nodejs/node/pull/23956 |
| rvagg | https://patch-diff.githubusercontent.com/rvagg |
|
Nov 28, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#ref-commit-4b18d96 |
|
| https://patch-diff.githubusercontent.com/Westixy |
|
| https://patch-diff.githubusercontent.com/rvagg |
| test: fix strictEqual arguments order | https://patch-diff.githubusercontent.com/nodejs/node/commit/4b18d965de90b79aadfa11d822e2439df4aedcf7 |
| 4b18d96 | https://patch-diff.githubusercontent.com/nodejs/node/commit/4b18d965de90b79aadfa11d822e2439df4aedcf7 |
| #23956 | https://github.com/nodejs/node/pull/23956 |
| MylesBorins | https://patch-diff.githubusercontent.com/MylesBorins |
|
Nov 29, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#ref-commit-e0902c8 |
|
| https://patch-diff.githubusercontent.com/Westixy |
|
| https://patch-diff.githubusercontent.com/MylesBorins |
| test: fix strictEqual arguments order | https://patch-diff.githubusercontent.com/nodejs/node/commit/e0902c8b4ffa7b24ba2c513c2546f1d8737238f1 |
| e0902c8 | https://patch-diff.githubusercontent.com/nodejs/node/commit/e0902c8b4ffa7b24ba2c513c2546f1d8737238f1 |
| #23956 | https://github.com/nodejs/node/pull/23956 |
| https://patch-diff.githubusercontent.com/codebytere |
| codebytere | https://patch-diff.githubusercontent.com/codebytere |
|
Nov 29, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#ref-pullrequest-385836001 |
|
v10.14.2 proposal
#24727
| https://patch-diff.githubusercontent.com/nodejs/node/pull/24727 |
| MylesBorins | https://patch-diff.githubusercontent.com/MylesBorins |
|
Dec 3, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#ref-commit-52c9209 |
|
| https://patch-diff.githubusercontent.com/Westixy |
|
| https://patch-diff.githubusercontent.com/MylesBorins |
| test: fix strictEqual arguments order | https://patch-diff.githubusercontent.com/nodejs/node/commit/52c9209f1ca8dfd4e9dca9a00218fecb95ae4815 |
| 52c9209 | https://patch-diff.githubusercontent.com/nodejs/node/commit/52c9209f1ca8dfd4e9dca9a00218fecb95ae4815 |
| #23956 | https://github.com/nodejs/node/pull/23956 |
| https://patch-diff.githubusercontent.com/BethGriggs |
| BethGriggs | https://patch-diff.githubusercontent.com/BethGriggs |
|
Dec 4, 2018
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956#ref-pullrequest-387422551 |
|
v8.14.1 proposal
#24832
| https://patch-diff.githubusercontent.com/nodejs/node/pull/24832 |
|
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs
beevelop/docker-android-nodejs#267
| https://patch-diff.githubusercontent.com/beevelop/docker-android-nodejs/issues/267 |
|
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs
beevelop/docker-android-nodejs#268
| https://patch-diff.githubusercontent.com/beevelop/docker-android-nodejs/issues/268 |
|
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs
beevelop/docker-android-nodejs#269
| https://patch-diff.githubusercontent.com/beevelop/docker-android-nodejs/issues/269 |
|
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs
beevelop/docker-android-nodejs#270
| https://patch-diff.githubusercontent.com/beevelop/docker-android-nodejs/issues/270 |
|
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs
beevelop/docker-android-nodejs#271
| https://patch-diff.githubusercontent.com/beevelop/docker-android-nodejs/issues/271 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F23956 |
|
| https://patch-diff.githubusercontent.com/fhinkel |
|
fhinkel
| https://patch-diff.githubusercontent.com/fhinkel |
|
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956/files/566bc4e77394902c5a9af4324850c44b88c00033 |
|
| https://patch-diff.githubusercontent.com/jasnell |
|
jasnell
| https://patch-diff.githubusercontent.com/jasnell |
|
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956/files/e379d72cebb3046eacf8f55015f35bb6140278e2 |
|
| https://patch-diff.githubusercontent.com/targos |
|
targos
| https://patch-diff.githubusercontent.com/targos |
|
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956/files/e379d72cebb3046eacf8f55015f35bb6140278e2 |
|
| https://patch-diff.githubusercontent.com/cjihrig |
|
cjihrig
| https://patch-diff.githubusercontent.com/cjihrig |
|
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956/files/e379d72cebb3046eacf8f55015f35bb6140278e2 |
|
| https://patch-diff.githubusercontent.com/trivikr |
|
trivikr
| https://patch-diff.githubusercontent.com/trivikr |
|
| https://patch-diff.githubusercontent.com/nodejs/node/pull/23956/files/566bc4e77394902c5a9af4324850c44b88c00033 |
|
author ready
| https://patch-diff.githubusercontent.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
fast-track
| https://patch-diff.githubusercontent.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
test
| https://patch-diff.githubusercontent.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/node/pull/23956 |
|
| https://patch-diff.githubusercontent.com/Westixy |
|
| https://patch-diff.githubusercontent.com/targos |
|
| https://patch-diff.githubusercontent.com/Trott |
|
| https://patch-diff.githubusercontent.com/fhinkel |
|
| https://patch-diff.githubusercontent.com/jasnell |
|
| https://patch-diff.githubusercontent.com/cjihrig |
|
| https://patch-diff.githubusercontent.com/trivikr |
|
| https://patch-diff.githubusercontent.com/MylesBorins |
|
| https://patch-diff.githubusercontent.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |