| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:54a10798-ca09-04e8-691a-137deb9e5318 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 90F4:3C68A8:949F61:C880D1:6973DF7C |
| html-safe-nonce | f1958f28ac9aa3c595c553014342b5267c37411daf7e9db3162801e5014683a0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEY0OjNDNjhBODo5NDlGNjE6Qzg4MEQxOjY5NzNERjdDIiwidmlzaXRvcl9pZCI6IjUzNDM0NDEyMTA2OTE1NDI5MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9f8ed094e4ed2ea7fb10fe3d8ea2c726c8bf2f114f96eea68ea7d69a530c81c6 |
| hovercard-subject-tag | pull_request:1760003653 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/llnode/433/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a3312641fc4300180f1defe3260f9c8f5c7ba5aa8d5d6735a873f3e8502ae23a/nodejs/llnode/pull/433 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a3312641fc4300180f1defe3260f9c8f5c7ba5aa8d5d6735a873f3e8502ae23a/nodejs/llnode/pull/433 |
| og:image:alt | This is a followup to #389:
Updates the range of LLVM versions we check (from 20, which is next dev version, to 99)
Support downloading headers if the detected lldb version is the current dev rele... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | trxcllnt |
| hostname | github.com |
| expected-hostname | github.com |
| None | bcae444bf5f475d712cb2ad536c10eaebd406c84ae2d3a77c5f05aee5010c786 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/llnode git https://github.com/nodejs/llnode.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 45659211 |
| octolytics-dimension-repository_nwo | nodejs/llnode |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45659211 |
| octolytics-dimension-repository_network_root_nwo | nodejs/llnode |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7da815895d8ce3ba55f0017efb5a34bac921756a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fllnode%2Fpull%2F433 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fllnode%2Fpull%2F433 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fllnode |
| Reload | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433 |
| Reload | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433 |
| Reload | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433 |
|
nodejs
| https://patch-diff.githubusercontent.com/nodejs |
| llnode | https://patch-diff.githubusercontent.com/nodejs/llnode |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433 |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fnodejs%2Fllnode |
|
Fork
103
| https://patch-diff.githubusercontent.com/login?return_to=%2Fnodejs%2Fllnode |
|
Star
1.2k
| https://patch-diff.githubusercontent.com/login?return_to=%2Fnodejs%2Fllnode |
|
Code
| https://patch-diff.githubusercontent.com/nodejs/llnode |
|
Issues
59
| https://patch-diff.githubusercontent.com/nodejs/llnode/issues |
|
Pull requests
10
| https://patch-diff.githubusercontent.com/nodejs/llnode/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/nodejs/llnode/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/nodejs/llnode/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/nodejs/llnode/wiki |
|
Security
0
| https://patch-diff.githubusercontent.com/nodejs/llnode/security |
|
Insights
| https://patch-diff.githubusercontent.com/nodejs/llnode/pulse |
|
Code
| https://patch-diff.githubusercontent.com/nodejs/llnode |
|
Issues
| https://patch-diff.githubusercontent.com/nodejs/llnode/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/nodejs/llnode/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/nodejs/llnode/actions |
|
Projects
| https://patch-diff.githubusercontent.com/nodejs/llnode/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/nodejs/llnode/wiki |
|
Security
| https://patch-diff.githubusercontent.com/nodejs/llnode/security |
|
Insights
| https://patch-diff.githubusercontent.com/nodejs/llnode/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Fnodejs%2Fllnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Fnodejs%2Fllnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433#issue-comment-box |
| trxcllnt | https://patch-diff.githubusercontent.com/trxcllnt |
| nodejs:main | https://patch-diff.githubusercontent.com/nodejs/llnode/tree/main |
| trxcllnt:fix/use-llvm-dev-branch | https://patch-diff.githubusercontent.com/trxcllnt/llnode/tree/fix/use-llvm-dev-branch |
|
Support llvm dev releases
| https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433#top |
| trxcllnt | https://patch-diff.githubusercontent.com/trxcllnt |
| nodejs:main | https://patch-diff.githubusercontent.com/nodejs/llnode/tree/main |
| trxcllnt:fix/use-llvm-dev-branch | https://patch-diff.githubusercontent.com/trxcllnt/llnode/tree/fix/use-llvm-dev-branch |
|
Conversation
5
| https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433 |
|
Commits
8
| https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/files |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/nodejs/llnode/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/trxcllnt |
| trxcllnt | https://patch-diff.githubusercontent.com/trxcllnt |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433#issue-2172709208 |
| #389 | https://github.com/nodejs/llnode/pull/389 |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433 |
| trxcllnt | https://patch-diff.githubusercontent.com/trxcllnt |
| March 6, 2024 16:30 | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433#commits-pushed-41f395d |
|
| https://patch-diff.githubusercontent.com/trxcllnt |
| expand the number of possible future LLVM versions to 99 | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/commits/41f395d51c2105e78866e42b66473f39da4b6a6b |
| 41f395d | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/commits/41f395d51c2105e78866e42b66473f39da4b6a6b |
|
| https://patch-diff.githubusercontent.com/trxcllnt |
| check to see if the LLVM version is the current dev release | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/commits/3b6dd747879a2c40ec2477f05e93cc6a24b6879e |
| 3b6dd74 | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/commits/3b6dd747879a2c40ec2477f05e93cc6a24b6879e |
|
| https://patch-diff.githubusercontent.com/trxcllnt |
| update github workflow to test more LLVM versions, including the curr… | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/commits/2f7f28465ad8394c001914a9206b4e0f31600da4 |
| 2f7f284 | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/commits/2f7f28465ad8394c001914a9206b4e0f31600da4 |
| https://patch-diff.githubusercontent.com/codecov-commenter |
| codecov-commenter | https://patch-diff.githubusercontent.com/codecov-commenter |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433#issuecomment-1982138031 |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433 |
| Codecov | https://app.codecov.io/gh/nodejs/llnode/pull/433?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (de1f01d) | https://app.codecov.io/gh/nodejs/llnode/commit/de1f01d70a5c58111dd873d340f898023e4e8fe6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (1d965d1) | https://app.codecov.io/gh/nodejs/llnode/pull/433?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| ☔ View full report in Codecov by Sentry | https://app.codecov.io/gh/nodejs/llnode/pull/433?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Share it here | https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433 |
| trxcllnt | https://patch-diff.githubusercontent.com/trxcllnt |
| March 6, 2024 16:51 | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433#commits-pushed-460472d |
|
| https://patch-diff.githubusercontent.com/trxcllnt |
| update linter job to use lldb-11 | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/commits/460472da7fdeabe677bfdbd4928f8c4d9ed011fd |
| 460472d | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/commits/460472da7fdeabe677bfdbd4928f8c4d9ed011fd |
|
| https://patch-diff.githubusercontent.com/trxcllnt |
| parse the python version from the python3 binary | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/commits/c924ad93fcc18cf6b281a55e995efef576f6c098 |
| c924ad9 | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/commits/c924ad93fcc18cf6b281a55e995efef576f6c098 |
| https://patch-diff.githubusercontent.com/trxcllnt |
| trxcllnt | https://patch-diff.githubusercontent.com/trxcllnt |
|
Mar 7, 2024
| https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433#pullrequestreview-1921123859 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/files/c924ad93fcc18cf6b281a55e995efef576f6c098 |
| .github/workflows/push.yml | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/files/c924ad93fcc18cf6b281a55e995efef576f6c098#diff-f3fc934cf0d89bdf07de358896ff90f1202585df812cf606206d1830a9949811 |
| trxcllnt | https://patch-diff.githubusercontent.com/trxcllnt |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433#discussion_r1515347447 |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433 |
| https://patch-diff.githubusercontent.com/trxcllnt |
| trxcllnt | https://patch-diff.githubusercontent.com/trxcllnt |
|
Mar 7, 2024
| https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433#pullrequestreview-1921124432 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/files/c924ad93fcc18cf6b281a55e995efef576f6c098 |
| .github/workflows/push.yml | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/files/c924ad93fcc18cf6b281a55e995efef576f6c098#diff-f3fc934cf0d89bdf07de358896ff90f1202585df812cf606206d1830a9949811 |
| trxcllnt | https://patch-diff.githubusercontent.com/trxcllnt |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433#discussion_r1515347970 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433 |
| https://patch-diff.githubusercontent.com/trxcllnt |
| trxcllnt | https://patch-diff.githubusercontent.com/trxcllnt |
|
Mar 7, 2024
| https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433#pullrequestreview-1921125327 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/files/c924ad93fcc18cf6b281a55e995efef576f6c098 |
| .github/workflows/push.yml | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/files/c924ad93fcc18cf6b281a55e995efef576f6c098#diff-f3fc934cf0d89bdf07de358896ff90f1202585df812cf606206d1830a9949811 |
| trxcllnt | https://patch-diff.githubusercontent.com/trxcllnt |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433#discussion_r1515348629 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433 |
| trxcllnt | https://patch-diff.githubusercontent.com/trxcllnt |
| March 6, 2024 17:14 | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433#commits-pushed-e030df1 |
|
| https://patch-diff.githubusercontent.com/trxcllnt |
| add llvm libs to ld config and regenerate ld cache | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/commits/e030df1a7b6edc1c90e84a303120e2cde56032ec |
| e030df1 | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/commits/e030df1a7b6edc1c90e84a303120e2cde56032ec |
|
| https://patch-diff.githubusercontent.com/trxcllnt |
| remove ubuntu18.04 because that runner type was removed by github, ad… | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/commits/2348cebf42001a28e2c6956388b74dcc6233cb8b |
| 2348ceb | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/commits/2348cebf42001a28e2c6956388b74dcc6233cb8b |
|
| https://patch-diff.githubusercontent.com/trxcllnt |
| add concurrency key | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/commits/1d965d1c64ba73c0774ac4c2fa689a7c8d504be9 |
| 1d965d1 | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433/commits/1d965d1c64ba73c0774ac4c2fa689a7c8d504be9 |
| https://patch-diff.githubusercontent.com/trxcllnt |
| trxcllnt | https://patch-diff.githubusercontent.com/trxcllnt |
| Jul 16, 2024 | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433#issuecomment-2231504375 |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433 |
| @No9 | https://github.com/No9 |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fllnode%2Fpull%2F433 |
| Please reload this page | https://patch-diff.githubusercontent.com/nodejs/llnode/pull/433 |
|
| https://patch-diff.githubusercontent.com/trxcllnt |
|
| https://patch-diff.githubusercontent.com/codecov-commenter |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |