René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Test for the size of struct http_parser fails on 32 bit systems where there is padding/alignment for void*","articleBody":"Bonjour,\r\n\r\nPorting http-parser to AIX, where there are 32 and 64 bit environments, there is a test on sizeof (struct http_parser) which fails due to 8 byte reservation for void* on both 32 and 64 bit compiles.\r\n\r\nA clean option might be to change the   void *data   element of struct http_parser to be a union of uint64 and void*.\r\n\r\nBut this may not work if the 32 bit size of struct http_parser must remain at a total of 28 bytes (and in which case the test is in correct).\r\n\r\nHowever, supposing that this is an error in the test code, I provisionally used the following patch for the 32 bit build\r\n\r\n```\r\n--- ./test.c.ORIG       2020-11-27 22:02:53 +0100\r\n+++ ./test.c    2020-11-27 22:57:18 +0100\r\n@@ -4234,7 +4234,7 @@\r\n   printf(\"http_parser v%u.%u.%u (0x%06lx)\\n\", major, minor, patch, version);\r\n \r\n   printf(\"sizeof(http_parser) = %u\\n\", (unsigned int)sizeof(http_parser));\r\n-  assert(sizeof(http_parser) == 4 + 4 + 8 + 2 + 2 + 4 + sizeof(void *));\r\n+  assert(sizeof(http_parser) == 4 + 4 + 8 + 2 + 2 + 4 + 2*sizeof(void *));\r\n \r\n   //// API\r\n   test_preserve_data();\r\n```\r\n\r\n\r\nWe would like to ask for your expert advice on how best to resolve this issue.\r\n\r\nThanks.\r\n","author":{"url":"https://github.com/frmichael","@type":"Person","name":"frmichael"},"datePublished":"2020-11-30T10:11:25.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/526/http-parser/issues/526"}