Title: Fix commit_create_cb by julianmesa-gitkraken · Pull Request #1946 · nodegit/nodegit · GitHub
Open Graph Title: Fix commit_create_cb by julianmesa-gitkraken · Pull Request #1946 · nodegit/nodegit
X Title: Fix commit_create_cb by julianmesa-gitkraken · Pull Request #1946 · nodegit/nodegit
Description: The definition was wrong parents should be an array of Commits not Oids. Also we are copying the Oid in the callback so we are not returning the Oid so we must not set selfFreeing to false.
Open Graph Description: The definition was wrong parents should be an array of Commits not Oids. Also we are copying the Oid in the callback so we are not returning the Oid so we must not set selfFreeing to false.
X Description: The definition was wrong parents should be an array of Commits not Oids. Also we are copying the Oid in the callback so we are not returning the Oid so we must not set selfFreeing to false.
Opengraph URL: https://github.com/nodegit/nodegit/pull/1946
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c5c2d564-45ba-8403-c340-6dd3401ca67a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F86:2FC763:392FA5:5089B4:6970A671 |
| html-safe-nonce | 7e6ca0e87a50067cbb1630b64f813a9513c2c9860e74f3e51fad930c774ce6c2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Rjg2OjJGQzc2MzozOTJGQTU6NTA4OUI0OjY5NzBBNjcxIiwidmlzaXRvcl9pZCI6IjUxOTM1NjM4MjU3NzE2ODU0ODkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f24a010c93209e266d6fcd8830217015726fd4f9c7bea16457e64d404b0560d8 |
| hovercard-subject-tag | pull_request:1102011905 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/1946/files |
| twitter:image | https://avatars.githubusercontent.com/u/89994186?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/89994186?s=400&v=4 |
| og:image:alt | The definition was wrong parents should be an array of Commits not Oids. Also we are copying the Oid in the callback so we are not returning the Oid so we must not set selfFreeing to false. |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b06a4c45c45fd0bb038b3759265ea6e38211f45d18130bc65261990be6b5972a |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0e1c4964831785bd64cb22d82e7cf2391ae01f45 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width