Title: ESLint + Prettier + tsconfig by wmertens · Pull Request #1825 · nodegit/nodegit · GitHub
Open Graph Title: ESLint + Prettier + tsconfig by wmertens · Pull Request #1825 · nodegit/nodegit
X Title: ESLint + Prettier + tsconfig by wmertens · Pull Request #1825 · nodegit/nodegit
Description: This PR touches a lot of files due to the npm run lint final commit. This is all done by prettier and eslint and should be safe. To see the changes without the auto-fixes, look at master...4f78356 Changes: Set up ESLint together with Prettier and a JSDoc formatting plugin Made npm run lint also auto-fix problems that ESLint finds Added a tsconfig.json file so that VSCode (and anything else using tsc to check for errors) can do live code analysis and provide better tab completion. This doesn't touch anything else, it's just a single file. Fixed some JSDoc entries so they were parseable by the Prettier plugin Fixed straightforward ESLint errors (lint commit) Changed some array.some() invocations that used side-effects with their for loop equivalent (lint++ commit) Ran npm run lint ESLint finds more problems than JSHint, and integrating with Prettier is faster than having the two separately, plus it automatically disables ESLint rules related to formatting which is automated by Prettier. The JSDoc plugin ensures that the JSDoc entries are consistently formatted, and helps with detecting unparseable descriptions (they won't format). Merging this will cause open PRs to have merge conflicts. To fix those, there are two options: Rebasing the branch on top of master, running npm run lint after every merge conflict fixup (preferred for clean branches) Cherry-picking the commit that adds eslint, running npm run lint and committing the result (easiest)
Open Graph Description: This PR touches a lot of files due to the npm run lint final commit. This is all done by prettier and eslint and should be safe. To see the changes without the auto-fixes, look at master...4f78356 ...
X Description: This PR touches a lot of files due to the npm run lint final commit. This is all done by prettier and eslint and should be safe. To see the changes without the auto-fixes, look at master...4f78356 ...
Opengraph URL: https://github.com/nodegit/nodegit/pull/1825
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:b334f3cb-c497-aa9e-13c6-c31aa8940b8b |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | AEEC:184919:8FBAC9:C7C536:6970EF47 |
| html-safe-nonce | 2ad20432e98f8e0de3bc593df44d64ec6b54ed6b1d395dcb1d7c45925006d171 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUVDOjE4NDkxOTo4RkJBQzk6QzdDNTM2OjY5NzBFRjQ3IiwidmlzaXRvcl9pZCI6IjMwMzkyMjcyODI1NzMwMjkxOTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2ccd44da91a9f529c7d7cc34889bca06d44758e5a98e0df2c4d628e6776aa9b1 |
| hovercard-subject-tag | pull_request:586017278 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/1825/checks |
| twitter:image | https://avatars.githubusercontent.com/u/54934?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/54934?s=400&v=4 |
| og:image:alt | This PR touches a lot of files due to the npm run lint final commit. This is all done by prettier and eslint and should be safe. To see the changes without the auto-fixes, look at master...4f78356 ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b6ca3cb96fa07d8a62b95d681f9dc8fffb49a43f4fea2a5bcac6d8f5107cbf4e |
| turbo-cache-control | no-preview |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d2448578278810c7bf94faa67651ef5adb1abfde |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width