Title: migrate jshint to eslint by ChristianMurphy · Pull Request #1791 · nodegit/nodegit · GitHub
Open Graph Title: migrate jshint to eslint by ChristianMurphy · Pull Request #1791 · nodegit/nodegit
X Title: migrate jshint to eslint by ChristianMurphy · Pull Request #1791 · nodegit/nodegit
Description: configuration migration automated using https://github.com/brenolf/polyjuice. find and replace used to switch jshint ignore comments for eslint disable comments. alternative to #1338 there are a few unused vars and uses of proto, which jshint missed that eslint catches, that are being flagged. nodegit/lib/nodegit.js 1081:1 error The '__proto__' property is deprecated no-proto nodegit/lib/repository.js 1466:20 error 'promiseChain' is assigned a value but never used no-unused-vars nodegit/test/tests/commit.js 1045:5 error 'signature' is assigned a value but never used no-unused-vars nodegit/test/tests/merge.js 179:11 error 'ourBranch' is assigned a value but never used no-unused-vars 213:9 error 'theirCommit' is assigned a value but never used no-unused-vars 295:11 error 'ourBranch' is assigned a value but never used no-unused-vars 329:9 error 'theirCommit' is assigned a value but never used no-unused-vars 454:9 error 'ourCommit' is assigned a value but never used no-unused-vars 485:9 error 'theirCommit' is assigned a value but never used no-unused-vars 604:11 error 'ourCommit' is assigned a value but never used no-unused-vars 635:11 error 'theirCommit' is assigned a value but never used no-unused-vars 763:11 error 'ourCommit' is assigned a value but never used no-unused-vars 794:11 error 'theirCommit' is assigned a value but never used no-unused-vars 881:11 error 'ourBranch' is assigned a value but never used no-unused-vars 915:9 error 'theirCommit' is assigned a value but never used no-unused-vars 1037:9 error 'ourCommit' is assigned a value but never used no-unused-vars 1068:9 error 'theirCommit' is assigned a value but never used no-unused-vars 1184:9 error 'ourCommit' is assigned a value but never used no-unused-vars 1215:9 error 'theirCommit' is assigned a value but never used no-unused-vars nodegit/test/tests/revwalk.js 114:11 error 'storedCommits' is assigned a value but never used no-unused-vars nodegit/test/tests/signature.js 103:5 error 'time' is assigned a value but never used no-unused-vars nodegit/test/tests/stash.js 157:11 error 'oldContent' is assigned a value but never used no-unused-vars 189:11 error 'oldContent' is assigned a value but never used no-unused-vars ✖ 23 problems (23 errors, 0 warnings) these could either be ignored or the tests refactored to use the variable.
Open Graph Description: configuration migration automated using https://github.com/brenolf/polyjuice. find and replace used to switch jshint ignore comments for eslint disable comments. alternative to #1338 there are a f...
X Description: configuration migration automated using https://github.com/brenolf/polyjuice. find and replace used to switch jshint ignore comments for eslint disable comments. alternative to #1338 there are a f...
Opengraph URL: https://github.com/nodegit/nodegit/pull/1791
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:cd2c1c04-d0a4-455f-b497-e5549e254a66 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 92B8:85BCA:F0EDA7:1509AE1:6971FB6F |
| html-safe-nonce | a3c0df7fe95b8a6b0bb0ad7054c5f9d03ce88469ca0235ba14ee53233f8a468b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkI4Ojg1QkNBOkYwRURBNzoxNTA5QUUxOjY5NzFGQjZGIiwidmlzaXRvcl9pZCI6IjYwMDU1MTEzNTU2NzI2ODk1MTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | dda8ab82590dd88985cdb139f499c109ecc74f1351e37e13ea3ade419373ebe4 |
| hovercard-subject-tag | pull_request:478345578 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/1791/files |
| twitter:image | https://avatars.githubusercontent.com/u/3107513?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3107513?s=400&v=4 |
| og:image:alt | configuration migration automated using https://github.com/brenolf/polyjuice. find and replace used to switch jshint ignore comments for eslint disable comments. alternative to #1338 there are a f... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5d01a3551afdd1a0e12e78acaf3ba43a9a1f7dcb518695d6ed59db76a9290f13 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 062b05dcdf64ee7a3dad7acabb746494ae0982cc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width