Title: Expose error code in Status.file by rcjsuen · Pull Request #1468 · nodegit/nodegit · GitHub
Open Graph Title: Expose error code in Status.file by rcjsuen · Pull Request #1468 · nodegit/nodegit
X Title: Expose error code in Status.file by rcjsuen · Pull Request #1468 · nodegit/nodegit
Description: Found non-matching argument named return in descriptor.json for C function git_status_file The change I made for #1467 helped me discover an error in our wrapper for git_status_file. It seems like Status.file does not actually expose the C function's error code when an error occurs. I've fixed the descriptor and also added a test to hopefully ensure that this won't happen again in the future.
Open Graph Description: Found non-matching argument named return in descriptor.json for C function git_status_file The change I made for #1467 helped me discover an error in our wrapper for git_status_file. It seems like...
X Description: Found non-matching argument named return in descriptor.json for C function git_status_file The change I made for #1467 helped me discover an error in our wrapper for git_status_file. It seems like...
Opengraph URL: https://github.com/nodegit/nodegit/pull/1468
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5f41ebc4-d4ed-bc7f-fe7a-cbdb04a0d98a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8CF6:1BA1D5:1957007:237A2E7:6970DB6C |
| html-safe-nonce | 93450afe4689001ac0c3d3aa1d27869a2df59813fdf41c8683a7c957a7d98467 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0Y2OjFCQTFENToxOTU3MDA3OjIzN0EyRTc6Njk3MERCNkMiLCJ2aXNpdG9yX2lkIjoiNzEyNDU0OTkwNjIzMDk5MTcyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | afb04a3921251493d5744d894f853d433b002e1dc86916dc6dbd64602c821cab |
| hovercard-subject-tag | pull_request:176475721 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/1468/files |
| twitter:image | https://avatars.githubusercontent.com/u/15629116?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/15629116?s=400&v=4 |
| og:image:alt | Found non-matching argument named return in descriptor.json for C function git_status_file The change I made for #1467 helped me discover an error in our wrapper for git_status_file. It seems like... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9203e7efc62065329c3b7015a1e6d16fc14bce440abec7b0d3cbe9e4fb1e2e4 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | eb3c92b74ae48a78cffd8700b8eb5f60bad61528 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width