Title: Expose error code in Status.file by rcjsuen · Pull Request #1468 · nodegit/nodegit · GitHub
Open Graph Title: Expose error code in Status.file by rcjsuen · Pull Request #1468 · nodegit/nodegit
X Title: Expose error code in Status.file by rcjsuen · Pull Request #1468 · nodegit/nodegit
Description: Found non-matching argument named return in descriptor.json for C function git_status_file The change I made for #1467 helped me discover an error in our wrapper for git_status_file. It seems like Status.file does not actually expose the C function's error code when an error occurs. I've fixed the descriptor and also added a test to hopefully ensure that this won't happen again in the future.
Open Graph Description: Found non-matching argument named return in descriptor.json for C function git_status_file The change I made for #1467 helped me discover an error in our wrapper for git_status_file. It seems like...
X Description: Found non-matching argument named return in descriptor.json for C function git_status_file The change I made for #1467 helped me discover an error in our wrapper for git_status_file. It seems like...
Opengraph URL: https://github.com/nodegit/nodegit/pull/1468
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:32fd26fd-3eee-9b2e-cd4b-5e96b42e7425 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 9532:121D22:4039284:5735A2E:69709043 |
| html-safe-nonce | f4db94789c98b4ee8b93fd19c52f9e1726761867952669ca0a1f7dbe5d2d2da6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTMyOjEyMUQyMjo0MDM5Mjg0OjU3MzVBMkU6Njk3MDkwNDMiLCJ2aXNpdG9yX2lkIjoiNTYwNzM1ODUwNzEyNDgyMjA4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3795cd376ecd1202ca902d1c1fb59d3bfdefb1350cb29fb1a78ec66e35afd8b9 |
| hovercard-subject-tag | pull_request:176475721 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/1468/checks |
| twitter:image | https://avatars.githubusercontent.com/u/15629116?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/15629116?s=400&v=4 |
| og:image:alt | Found non-matching argument named return in descriptor.json for C function git_status_file The change I made for #1467 helped me discover an error in our wrapper for git_status_file. It seems like... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7d6181066430cc06553c8396ca201e194ae33cb9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width