Title: Output warning in JSON generator if an unmatched argument is found in descriptor.json by rcjsuen · Pull Request #1467 · nodegit/nodegit · GitHub
Open Graph Title: Output warning in JSON generator if an unmatched argument is found in descriptor.json by rcjsuen · Pull Request #1467 · nodegit/nodegit
X Title: Output warning in JSON generator if an unmatched argument is found in descriptor.json by rcjsuen · Pull Request #1467 · nodegit/nodegit
Description: When making additions or changes to NodeGit to match libgit2, we have to make changes to the generate/input/descriptor.json file. If we make a typo, it goes completely undetected until your test code fails or you when you manually inspect the generated C++ code. To make this feedback loop better, we should generate a warning if an argument name used in the descriptor does not match the name in the C function. This fixes #1464 and will make everyone's lives a lot easier when adding new API to NodeGit. The following is the new output from Travis CI. [nodegit] Running pre-install script [nodegit] Configuring libssh2. [nodegit] Checking submodule status [nodegit] Initializing submodules [nodegit] Generating native code Found non-matching argument named flags in descriptor.json for C function git_index_remove_all Found non-matching argument named flags in descriptor.json for C function git_index_update_all Found non-matching argument named force in descriptor.json for C function git_index_write Found non-matching argument named signature in descriptor.json for C function git_rebase_init Found non-matching argument named signature in descriptor.json for C function git_branch_create Found non-matching argument named log_message in descriptor.json for C function git_branch_create Found non-matching argument named log_message in descriptor.json for C function git_reset Found non-matching argument named signature in descriptor.json for C function git_reset Found non-matching argument named return in descriptor.json for C function git_status_file [nodegit] Running install script
Open Graph Description: When making additions or changes to NodeGit to match libgit2, we have to make changes to the generate/input/descriptor.json file. If we make a typo, it goes completely undetected until your test co...
X Description: When making additions or changes to NodeGit to match libgit2, we have to make changes to the generate/input/descriptor.json file. If we make a typo, it goes completely undetected until your test co...
Opengraph URL: https://github.com/nodegit/nodegit/pull/1467
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:4d9e0d68-3615-08f7-5305-04bfa35183cc |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | B3AC:2D5C0D:10D10E8:177D906:6970C763 |
| html-safe-nonce | 8a7660f9bbb980de43164e90792a35b5e8813b6f85d0a44ca5375e8ff188c965 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0FDOjJENUMwRDoxMEQxMEU4OjE3N0Q5MDY6Njk3MEM3NjMiLCJ2aXNpdG9yX2lkIjoiMzM1MDg1MzIzNDY0NDI3Mjk5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f4c7586a94ed6af02889079279f51374f5d2c77ba08cc36fcc70cbcc0811a899 |
| hovercard-subject-tag | pull_request:176342769 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/1467/checks |
| twitter:image | https://avatars.githubusercontent.com/u/15629116?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/15629116?s=400&v=4 |
| og:image:alt | When making additions or changes to NodeGit to match libgit2, we have to make changes to the generate/input/descriptor.json file. If we make a typo, it goes completely undetected until your test co... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 721764876e433c894814212f8100f6610f1dde78a987acc2e385d8be8e170e9c |
| turbo-cache-control | no-preview |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6ff3d08f4ee1c3f89ebedf4df8fc8fe851190294 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width