Title: Change how getReferenceCommit() retrieves commits by rcjsuen · Pull Request #1420 · nodegit/nodegit · GitHub
Open Graph Title: Change how getReferenceCommit() retrieves commits by rcjsuen · Pull Request #1420 · nodegit/nodegit
X Title: Change how getReferenceCommit() retrieves commits by rcjsuen · Pull Request #1420 · nodegit/nodegit
Description: The current code in repository.js assumes that the return value from reference.target() is an oid that points to a commit. nodegit/lib/repository.js Lines 1057 to 1069 in b6e1478 Repository.prototype.getReferenceCommit = function(name, callback) { var repository = this; return this.getReference(name).then(function(reference) { return repository.getCommit(reference.target()).then(function(commit) { if (typeof callback === "function") { callback(null, commit); } return commit; }); }, callback); }; However, this is not true for annotated commits as its target oid is actually the tag object itself. To get around this, reference.peel(NodeGit.Object.TYPE.COMMIT) should be used instead so that the reference object will fully unwrap itself to the underlying commit object. This should fix #1370.
Open Graph Description: The current code in repository.js assumes that the return value from reference.target() is an oid that points to a commit. nodegit/lib/repository.js Lines 1057 to 1...
X Description: The current code in repository.js assumes that the return value from reference.target() is an oid that points to a commit. nodegit/lib/repository.js Lines 1057 to 1...
Opengraph URL: https://github.com/nodegit/nodegit/pull/1420
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:727991e8-f231-9424-7187-887d772f5123 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B05C:A458E:2AC39A1:3C2518C:69710610 |
| html-safe-nonce | 2c211d59881c2adf955184d87ec32e0da18141b2f04d1c71231a04c020eaf1f4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDVDOkE0NThFOjJBQzM5QTE6M0MyNTE4Qzo2OTcxMDYxMCIsInZpc2l0b3JfaWQiOiIxOTY3NTI5NDc2NDU4ODc0Mzg0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 4ebe262cf17c50c8830b2d5508664375c1f92caa0e16e7b4619c35662600d671 |
| hovercard-subject-tag | pull_request:160113353 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodegit/nodegit/pull/1420/files |
| twitter:image | https://avatars.githubusercontent.com/u/15629116?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/15629116?s=400&v=4 |
| og:image:alt | The current code in repository.js assumes that the return value from reference.target() is an oid that points to a commit. nodegit/lib/repository.js Lines 1057 to 1... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6d0e7b0d5e294a53c55f49e80755e785182080c6e6a48c9ed353bedddaee69f4 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6d5a3a396bc74e65fd3ef897b0a99a6e489debaa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width