Title: Change generator to warn about invalid argument names · Issue #1464 · nodegit/nodegit · GitHub
Open Graph Title: Change generator to warn about invalid argument names · Issue #1464 · nodegit/nodegit
X Title: Change generator to warn about invalid argument names · Issue #1464 · nodegit/nodegit
Description: I had the following in my descriptor.json file: "args": { "result": { "isReturn": true }, "opts:": { "isOptional": true } I ran npm run generateJson and npm run generateNativeCode many times but the opts argument wouldn't become optional...
Open Graph Description: I had the following in my descriptor.json file: "args": { "result": { "isReturn": true }, "opts:": { "isOptional": true } I ran npm run generateJson and npm run generateNativeCode many times but th...
X Description: I had the following in my descriptor.json file: "args": { "result": { "isReturn": true }, "opts:": { "isOptional": true } I ran npm run generateJso...
Opengraph URL: https://github.com/nodegit/nodegit/issues/1464
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Change generator to warn about invalid argument names","articleBody":"I had the following in my descriptor.json file:\r\n```JavaScript\r\n \"args\": {\r\n \"result\": {\r\n \"isReturn\": true\r\n },\r\n \"opts:\": {\r\n \"isOptional\": true\r\n }\r\n```\r\nI ran `npm run generateJson` and `npm run generateNativeCode` many times but the `opts` argument wouldn't become optional in the generated C++ file. I finally realized I made a typo. I named the argument `opts:` instead of `opts`! :(\r\n\r\nWe should change the generator so that it will generate warnings if a specified argument's name doesn't match what's declared in libgit2.","author":{"url":"https://github.com/rcjsuen","@type":"Person","name":"rcjsuen"},"datePublished":"2018-03-20T08:03:57.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/1464/nodegit/issues/1464"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6393dec4-d3fc-6920-2f33-879d3ca1f655 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A3CC:158E36:335771E:44DFE5A:69706B38 |
| html-safe-nonce | 7ced96ef610d8b62d3e3e53a2c44d73aa85ac1dbee7a12acd1cc0295d0a42ca8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0NDOjE1OEUzNjozMzU3NzFFOjQ0REZFNUE6Njk3MDZCMzgiLCJ2aXNpdG9yX2lkIjoiODE3NTQyODA0NjA5NzIzMTkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 40a3f0eaefc042f75786720251ea1befe8bf880ef660721479a75f38d41fe1cd |
| hovercard-subject-tag | issue:306763077 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodegit/nodegit/1464/issue_layout |
| twitter:image | https://opengraph.githubassets.com/8a0c2dee2575b99815491321cc7b7a22cd3a39de54e5ba0227f161dc7abfc91d/nodegit/nodegit/issues/1464 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8a0c2dee2575b99815491321cc7b7a22cd3a39de54e5ba0227f161dc7abfc91d/nodegit/nodegit/issues/1464 |
| og:image:alt | I had the following in my descriptor.json file: "args": { "result": { "isReturn": true }, "opts:": { "isOptional": true } I ran npm run generateJson and npm run generateNativeCode many times but th... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rcjsuen |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodegit/nodegit git https://github.com/nodegit/nodegit.git |
| octolytics-dimension-user_id | 657068 |
| octolytics-dimension-user_login | nodegit |
| octolytics-dimension-repository_id | 1383170 |
| octolytics-dimension-repository_nwo | nodegit/nodegit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1383170 |
| octolytics-dimension-repository_network_root_nwo | nodegit/nodegit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7d6181066430cc06553c8396ca201e194ae33cb9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width