Title: General versus Per-Model flags · Issue #271 · networktocode/diffsync · GitHub
Open Graph Title: General versus Per-Model flags · Issue #271 · networktocode/diffsync
X Title: General versus Per-Model flags · Issue #271 · networktocode/diffsync
Description: Environment DiffSync version: 2.0.0 Proposed Functionality The way flags are managed in diffsync/diffsync/helpers.py Lines 185 to 208 in 315b5e9 if self.flags & DiffSyncFlags.SKIP_UNMATCHED_SRC and not dst_obj: log.debug("Skipping due to...
Open Graph Description: Environment DiffSync version: 2.0.0 Proposed Functionality The way flags are managed in diffsync/diffsync/helpers.py Lines 185 to 208 in 315b5e9 if self.flags & DiffSyncFlags.SKIP_UNMATCHED_SRC and...
X Description: Environment DiffSync version: 2.0.0 Proposed Functionality The way flags are managed in diffsync/diffsync/helpers.py Lines 185 to 208 in 315b5e9 if self.flags & DiffSyncFlags.SKIP_UNMATCHED_SRC...
Opengraph URL: https://github.com/networktocode/diffsync/issues/271
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"General versus Per-Model flags","articleBody":"### Environment\r\n* DiffSync version: 2.0.0\r\n\r\n\u003c!--\r\n Describe in detail the new functionality you are proposing.\r\n--\u003e\r\n### Proposed Functionality\r\n\r\nThe way flags are managed in https://github.com/networktocode/diffsync/blob/315b5e9396148209a71a9526c090b2899deab77a/diffsync/helpers.py#L185-L208, means that the GLOBAL flags always take precedence over the MODEL ones.\r\n\r\nI would propose changing the order (more specific first) and adding some flags that could negate the global behavior. For example:\r\n- global: `SKIP_UNMATCHED_DST`\r\n- model: `NO_SKIP_UNMATCHED_DST` (new one)\r\n\r\nThis should allow not skipping for only a specific model.\r\n\r\n\u003c!--\r\n Convey an example use case for your proposed feature. Write from the\r\n perspective of a user who would benefit from the proposed\r\n functionality and describe how.\r\n--\u003e\r\n### Use Case\r\n\r\n","author":{"url":"https://github.com/chadell","@type":"Person","name":"chadell"},"datePublished":"2024-03-12T13:08:14.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/271/diffsync/issues/271"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:d25c9d0b-680a-f4b3-1d5e-4ea4ea6d44e5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DD74:3B5BF:3A44C5B:4B08613:69910330 |
| html-safe-nonce | e98fd308bdf5572db0e13eb50dfd0b028f41b51ddef76468580c10476508e804 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDc0OjNCNUJGOjNBNDRDNUI6NEIwODYxMzo2OTkxMDMzMCIsInZpc2l0b3JfaWQiOiI1MjY5ODU5NTgxODcwMjc3NDI0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5bc3d45dbb740a6b7813a3a35c8df37709b74965228d76946d76597f13feb1c4 |
| hovercard-subject-tag | issue:2181581657 |
| github-keyboard-shortcuts | repository,issues,network-graph,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/networktocode/diffsync/271/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e003151e7b2998abb021a01bec879d4d40a1016e7bce50dc836f6b663dcb918b/networktocode/diffsync/issues/271 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e003151e7b2998abb021a01bec879d4d40a1016e7bce50dc836f6b663dcb918b/networktocode/diffsync/issues/271 |
| og:image:alt | Environment DiffSync version: 2.0.0 Proposed Functionality The way flags are managed in diffsync/diffsync/helpers.py Lines 185 to 208 in 315b5e9 if self.flags & DiffSyncFlags.SKIP_UNMATCHED_SRC and... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | chadell |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| go-import | github.com/networktocode/diffsync git https://github.com/networktocode/diffsync.git |
| octolytics-dimension-user_id | 13106404 |
| octolytics-dimension-user_login | networktocode |
| octolytics-dimension-repository_id | 292296974 |
| octolytics-dimension-repository_nwo | networktocode/diffsync |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 292296974 |
| octolytics-dimension-repository_network_root_nwo | networktocode/diffsync |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width