René's URL Explorer Experiment


Title: Override always default Android hostname verifier by Guatom · Pull Request #23 · nativescript-community/https · GitHub

Open Graph Title: Override always default Android hostname verifier by Guatom · Pull Request #23 · nativescript-community/https

X Title: Override always default Android hostname verifier by Guatom · Pull Request #23 · nativescript-community/https

Description: This fixes the following problem: javax.net.ssl.SSLPeerUnverifiedException: Hostname WWW.XXX.YYY.ZZZ not verified: ... ... subjectAltNames: [] ; Zone: ; Task: Promise.then ; Value: javax.net.ssl.SSLPeerUnverifiedException: Hostname WWW.XXX.YYY.ZZZ not verified: A couple of months ago, Android stopped accepting self-signed certificates without SAN value when performing a WS call. I took a look at nativescript-https's code and there's this option validatesDomainName: if false, it uses default Android hostname verification which throws the mentioned error; if true, it uses a custom hostname verifier. With my proposed change, the custom verifier will always be used, but it will return true if validatesDomainName === false and will use current logic if validatesDomainName === true. This can be returned some lines before, just at the beginning of verify and save some processing, but I think it looks fancier this way. I'll modify the code if needed. I used this for a development environment and I thought it was useful since I saw some people having the same problem. I think this could be useful for someone else. Best regards from _travelDevs.

Open Graph Description: This fixes the following problem: javax.net.ssl.SSLPeerUnverifiedException: Hostname WWW.XXX.YYY.ZZZ not verified: ... ... subjectAltNames: [] ; Zone: <root> ; Task: Promise.then ; Value: jav...

X Description: This fixes the following problem: javax.net.ssl.SSLPeerUnverifiedException: Hostname WWW.XXX.YYY.ZZZ not verified: ... ... subjectAltNames: [] ; Zone: &lt;root&gt; ; Task: Promise.then ; Va...

Opengraph URL: https://github.com/nativescript-community/https/pull/23

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:19c84c9d-3bb8-ac6f-28d3-ffcf0309eb1e
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-idC256:1A8975:1260C0:173223:699108C7
html-safe-nonce887ac7a61c0b228252b3878e424512169c67ac8bd2d0213577b21a8831c98268
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjU2OjFBODk3NToxMjYwQzA6MTczMjIzOjY5OTEwOEM3IiwidmlzaXRvcl9pZCI6IjU5MzQ3NjcxMjgyNzYxNzUwNDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc041486873b134850f5e1a8b3bae23d62e658fc71d54f410653c656ce3e23103
hovercard-subject-tagpull_request:167518847
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nativescript-community/https/pull/23/checks
twitter:imagehttps://avatars.githubusercontent.com/u/15987263?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15987263?s=400&v=4
og:image:altThis fixes the following problem: javax.net.ssl.SSLPeerUnverifiedException: Hostname WWW.XXX.YYY.ZZZ not verified: ... ... subjectAltNames: [] ; Zone: <root> ; Task: Promise.then ; Value: jav...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-preview
go-importgithub.com/nativescript-community/https git https://github.com/nativescript-community/https.git
octolytics-dimension-user_id50633791
octolytics-dimension-user_loginnativescript-community
octolytics-dimension-repository_id77530217
octolytics-dimension-repository_nwonativescript-community/https
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id77530217
octolytics-dimension-repository_network_root_nwonativescript-community/https
turbo-body-classeslogged-out env-production page-responsive full-width full-width-p-0
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/nativescript-community/https/pull/23/checks#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnativescript-community%2Fhttps%2Fpull%2F23%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnativescript-community%2Fhttps%2Fpull%2F23%2Fchecks
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=nativescript-community%2Fhttps
Reloadhttps://patch-diff.githubusercontent.com/nativescript-community/https/pull/23/checks
Reloadhttps://patch-diff.githubusercontent.com/nativescript-community/https/pull/23/checks
Reloadhttps://patch-diff.githubusercontent.com/nativescript-community/https/pull/23/checks
nativescript-community https://patch-diff.githubusercontent.com/nativescript-community
httpshttps://patch-diff.githubusercontent.com/nativescript-community/https
Please reload this pagehttps://patch-diff.githubusercontent.com/nativescript-community/https/pull/23/checks
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fnativescript-community%2Fhttps
Fork 40 https://patch-diff.githubusercontent.com/login?return_to=%2Fnativescript-community%2Fhttps
Star 51 https://patch-diff.githubusercontent.com/login?return_to=%2Fnativescript-community%2Fhttps
Code https://patch-diff.githubusercontent.com/nativescript-community/https
Issues 13 https://patch-diff.githubusercontent.com/nativescript-community/https/issues
Pull requests 1 https://patch-diff.githubusercontent.com/nativescript-community/https/pulls
Actions https://patch-diff.githubusercontent.com/nativescript-community/https/actions
Projects 0 https://patch-diff.githubusercontent.com/nativescript-community/https/projects
Security 0 https://patch-diff.githubusercontent.com/nativescript-community/https/security
Insights https://patch-diff.githubusercontent.com/nativescript-community/https/pulse
Code https://patch-diff.githubusercontent.com/nativescript-community/https
Issues https://patch-diff.githubusercontent.com/nativescript-community/https/issues
Pull requests https://patch-diff.githubusercontent.com/nativescript-community/https/pulls
Actions https://patch-diff.githubusercontent.com/nativescript-community/https/actions
Projects https://patch-diff.githubusercontent.com/nativescript-community/https/projects
Security https://patch-diff.githubusercontent.com/nativescript-community/https/security
Insights https://patch-diff.githubusercontent.com/nativescript-community/https/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fnativescript-community%2Fhttps%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fnativescript-community%2Fhttps%2Fissues%2Fnew%2Fchoose
Guatomhttps://patch-diff.githubusercontent.com/Guatom
nativescript-community:masterhttps://patch-diff.githubusercontent.com/nativescript-community/https/tree/master
Guatom:masterhttps://patch-diff.githubusercontent.com/Guatom/nativescript-https/tree/master
Conversation 4 https://patch-diff.githubusercontent.com/nativescript-community/https/pull/23
Commits 1 https://patch-diff.githubusercontent.com/nativescript-community/https/pull/23/commits
Checks 0 https://patch-diff.githubusercontent.com/nativescript-community/https/pull/23/checks
Files changed https://patch-diff.githubusercontent.com/nativescript-community/https/pull/23/files
Please reload this pagehttps://patch-diff.githubusercontent.com/nativescript-community/https/pull/23/checks
Please reload this pagehttps://patch-diff.githubusercontent.com/nativescript-community/https/pull/23/checks
Override always default Android hostname verifier https://patch-diff.githubusercontent.com/nativescript-community/https/pull/23/checks#top
Please reload this pagehttps://patch-diff.githubusercontent.com/nativescript-community/https/pull/23/checks
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.