Title: about strategy of socket closed · Issue #8 · msgpack-rpc/msgpack-rpc-python · GitHub
Open Graph Title: about strategy of socket closed · Issue #8 · msgpack-rpc/msgpack-rpc-python
X Title: about strategy of socket closed · Issue #8 · msgpack-rpc/msgpack-rpc-python
Description: HI, when ClientSocket was closed, I think the Session._request_table were no longer necessary. future under current strategy will be wait until timeout, but if Client set timeout None, when socket closed, there will be endless wait. def ...
Open Graph Description: HI, when ClientSocket was closed, I think the Session._request_table were no longer necessary. future under current strategy will be wait until timeout, but if Client set timeout None, when socket ...
X Description: HI, when ClientSocket was closed, I think the Session._request_table were no longer necessary. future under current strategy will be wait until timeout, but if Client set timeout None, when socket ...
Opengraph URL: https://github.com/msgpack-rpc/msgpack-rpc-python/issues/8
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"about strategy of socket closed ","articleBody":"HI,\nwhen `ClientSocket` was closed, I think the `Session._request_table` were no longer necessary.\n`future` under current strategy will be wait until timeout, but if `Client` set timeout `None`, when socket closed, there will be endless wait.\n\n``` python\n def on_close(self, sock):\n # Avoid calling self.on_connect_failed after self.close called.\n if self._closed:\n return\n\n # if sock in self._sockets:\n # self._sockets.remove(sock)\n # self._connecting = 0\n # else:\n # Tornado does not have on_connect_failed event.\n self.on_connect_failed(sock)\n```\n\nWhat do you think?\n","author":{"url":"https://github.com/huangwei1024","@type":"Person","name":"huangwei1024"},"datePublished":"2015-02-03T15:52:42.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/8/msgpack-rpc-python/issues/8"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:049ba848-7463-c70f-85d6-f0706f3aa3fb |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C982:BB76B:2379131:2D89F3B:697FD27E |
| html-safe-nonce | 519a97b955f2b14e3441bb8e0200c4594a377f9ae604a5bce349cddb918eb5ff |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTgyOkJCNzZCOjIzNzkxMzE6MkQ4OUYzQjo2OTdGRDI3RSIsInZpc2l0b3JfaWQiOiI4MDc3MzQ0NTUzNTI4NDQ3NjE0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e395333c1a687c43c2661b30dac49068c2749cb0e5f979ad96c498e8f2694a88 |
| hovercard-subject-tag | issue:56395528 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/msgpack-rpc/msgpack-rpc-python/8/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b9c73aa73668b9a61791091e1721d2b4b585a8345fc5175f643247bc094350c5/msgpack-rpc/msgpack-rpc-python/issues/8 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b9c73aa73668b9a61791091e1721d2b4b585a8345fc5175f643247bc094350c5/msgpack-rpc/msgpack-rpc-python/issues/8 |
| og:image:alt | HI, when ClientSocket was closed, I think the Session._request_table were no longer necessary. future under current strategy will be wait until timeout, but if Client set timeout None, when socket ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | huangwei1024 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6 |
| turbo-cache-control | no-preview |
| go-import | github.com/msgpack-rpc/msgpack-rpc-python git https://github.com/msgpack-rpc/msgpack-rpc-python.git |
| octolytics-dimension-user_id | 1770939 |
| octolytics-dimension-user_login | msgpack-rpc |
| octolytics-dimension-repository_id | 8030543 |
| octolytics-dimension-repository_nwo | msgpack-rpc/msgpack-rpc-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 8030543 |
| octolytics-dimension-repository_network_root_nwo | msgpack-rpc/msgpack-rpc-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7c85641c598ad130c74f7bcc27f58575cac69551 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width