René's URL Explorer Experiment


Title: Fix case where string encoding overhead is larger than needed by nresare · Pull Request #108 · msgpack/msgpack-python · GitHub

Open Graph Title: Fix case where string encoding overhead is larger than needed by nresare · Pull Request #108 · msgpack/msgpack-python

X Title: Fix case where string encoding overhead is larger than needed by nresare · Pull Request #108 · msgpack/msgpack-python

Description: According to the spec "serializers SHOULD use the format which represents the data in the smallest number of bytes". This is not true for strings between 32 and (2^8)-1 bytes which has an encoding overhead of 3 bytes instead of the required 2. My guess is that the somewhat strange conditional in fallback.py:598 (and cython equivalent) is to make sure that old raw type test cases in test_case.py that test for encoding overhead succeeds. This commit updates the test case to test for the encoding overhead for both str and bin types of various lengths.

Open Graph Description: According to the spec "serializers SHOULD use the format which represents the data in the smallest number of bytes". This is not true for strings between 32 and (2^8)-1 bytes which has an...

X Description: According to the spec "serializers SHOULD use the format which represents the data in the smallest number of bytes". This is not true for strings between 32 and (2^8)-1 bytes whic...

Opengraph URL: https://github.com/msgpack/msgpack-python/pull/108

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:39885383-74c6-de80-068b-5bb460a84ad6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id83C8:16BD33:10B42AC:176307E:696FC718
html-safe-nonce7ad2be7086879aef50bcd33a6e333b3338f041db08bd123f591609066450d0dd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0M4OjE2QkQzMzoxMEI0MkFDOjE3NjMwN0U6Njk2RkM3MTgiLCJ2aXNpdG9yX2lkIjoiNTg1Mjg0Njg1NDgwNTM3NDc0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac598ddb72dc3c34035b7323bc8135707d64eb5bf118902e49636e651811e0218c
hovercard-subject-tagpull_request:22388124
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/msgpack/msgpack-python/pull/108/files
twitter:imagehttps://avatars.githubusercontent.com/u/541939?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/541939?s=400&v=4
og:image:altAccording to the spec "serializers SHOULD use the format which represents the data in the smallest number of bytes". This is not true for strings between 32 and (2^8)-1 bytes which has an...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None330ca0f04ee8ecef1da04306a0dd49293f64679ee9a4bd5eaf2e1272bfdcf145
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/msgpack/msgpack-python git https://github.com/msgpack/msgpack-python.git
octolytics-dimension-user_id198264
octolytics-dimension-user_loginmsgpack
octolytics-dimension-repository_id2242705
octolytics-dimension-repository_nwomsgpack/msgpack-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id2242705
octolytics-dimension-repository_network_root_nwomsgpack/msgpack-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release816ad575e27a390de2e2089ebe75261d12de9b37
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-python%2Fpull%2F108%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-python%2Fpull%2F108%2Ffiles
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=msgpack%2Fmsgpack-python
Reloadhttps://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files
Reloadhttps://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files
Reloadhttps://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files
msgpack https://patch-diff.githubusercontent.com/msgpack
msgpack-pythonhttps://patch-diff.githubusercontent.com/msgpack/msgpack-python
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fmsgpack%2Fmsgpack-python
Fork 238 https://patch-diff.githubusercontent.com/login?return_to=%2Fmsgpack%2Fmsgpack-python
Star 2.1k https://patch-diff.githubusercontent.com/login?return_to=%2Fmsgpack%2Fmsgpack-python
Code https://patch-diff.githubusercontent.com/msgpack/msgpack-python
Issues 3 https://patch-diff.githubusercontent.com/msgpack/msgpack-python/issues
Pull requests 3 https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pulls
Discussions https://patch-diff.githubusercontent.com/msgpack/msgpack-python/discussions
Actions https://patch-diff.githubusercontent.com/msgpack/msgpack-python/actions
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/msgpack/msgpack-python/security
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files
Insights https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pulse
Code https://patch-diff.githubusercontent.com/msgpack/msgpack-python
Issues https://patch-diff.githubusercontent.com/msgpack/msgpack-python/issues
Pull requests https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pulls
Discussions https://patch-diff.githubusercontent.com/msgpack/msgpack-python/discussions
Actions https://patch-diff.githubusercontent.com/msgpack/msgpack-python/actions
Security https://patch-diff.githubusercontent.com/msgpack/msgpack-python/security
Insights https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fmsgpack%2Fmsgpack-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fmsgpack%2Fmsgpack-python%2Fissues%2Fnew%2Fchoose
nresarehttps://patch-diff.githubusercontent.com/nresare
msgpack:masterhttps://patch-diff.githubusercontent.com/msgpack/msgpack-python/tree/master
nresare:pr/overly-long-strhttps://patch-diff.githubusercontent.com/nresare/msgpack-python/tree/pr/overly-long-str
Conversation 2 https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108
Commits 1 https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/commits
Checks 0 https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/checks
Files changed https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files
Fix case where string encoding overhead is larger than needed https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files#top
Show all changes 1 commit https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files
0422211 Fix case where string encoding overhead is larger than needed Oct 7, 2014 https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/commits/04222112193875382a5309f3eb3a1824d752c355
Clear filters https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files
fallback.py https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files#diff-f0ef50c152a99b4bcd7326e0dd398927ac285ee234ec697b7544594b8d457a1d
pack_template.h https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files#diff-daa52ff34eb64fef45835109eeacf68190e9d85e6e3373bdb995c5379fc0802f
test_case.py https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files#diff-d1da31e6da74bff5f659f1f5472cea5a1d446988cdca69a4257c66e2abdab25f
msgpack/fallback.pyhttps://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files#diff-f0ef50c152a99b4bcd7326e0dd398927ac285ee234ec697b7544594b8d457a1d
View file https://patch-diff.githubusercontent.com/nresare/msgpack-python/blob/04222112193875382a5309f3eb3a1824d752c355/msgpack/fallback.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files#diff-f0ef50c152a99b4bcd7326e0dd398927ac285ee234ec697b7544594b8d457a1d
https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files#diff-f0ef50c152a99b4bcd7326e0dd398927ac285ee234ec697b7544594b8d457a1d
msgpack/pack_template.hhttps://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files#diff-daa52ff34eb64fef45835109eeacf68190e9d85e6e3373bdb995c5379fc0802f
View file https://patch-diff.githubusercontent.com/nresare/msgpack-python/blob/04222112193875382a5309f3eb3a1824d752c355/msgpack/pack_template.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files#diff-daa52ff34eb64fef45835109eeacf68190e9d85e6e3373bdb995c5379fc0802f
https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files#diff-daa52ff34eb64fef45835109eeacf68190e9d85e6e3373bdb995c5379fc0802f
test/test_case.pyhttps://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files#diff-d1da31e6da74bff5f659f1f5472cea5a1d446988cdca69a4257c66e2abdab25f
View file https://patch-diff.githubusercontent.com/nresare/msgpack-python/blob/04222112193875382a5309f3eb3a1824d752c355/test/test_case.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files#diff-d1da31e6da74bff5f659f1f5472cea5a1d446988cdca69a4257c66e2abdab25f
https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files#diff-d1da31e6da74bff5f659f1f5472cea5a1d446988cdca69a4257c66e2abdab25f
https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files#diff-d1da31e6da74bff5f659f1f5472cea5a1d446988cdca69a4257c66e2abdab25f
https://patch-diff.githubusercontent.com/msgpack/msgpack-python/pull/108/files#diff-d1da31e6da74bff5f659f1f5472cea5a1d446988cdca69a4257c66e2abdab25f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.