Title: Fix case where string encoding overhead is larger than needed by nresare · Pull Request #108 · msgpack/msgpack-python · GitHub
Open Graph Title: Fix case where string encoding overhead is larger than needed by nresare · Pull Request #108 · msgpack/msgpack-python
X Title: Fix case where string encoding overhead is larger than needed by nresare · Pull Request #108 · msgpack/msgpack-python
Description: According to the spec "serializers SHOULD use the format which represents the data in the smallest number of bytes". This is not true for strings between 32 and (2^8)-1 bytes which has an encoding overhead of 3 bytes instead of the required 2. My guess is that the somewhat strange conditional in fallback.py:598 (and cython equivalent) is to make sure that old raw type test cases in test_case.py that test for encoding overhead succeeds. This commit updates the test case to test for the encoding overhead for both str and bin types of various lengths.
Open Graph Description: According to the spec "serializers SHOULD use the format which represents the data in the smallest number of bytes". This is not true for strings between 32 and (2^8)-1 bytes which has an...
X Description: According to the spec "serializers SHOULD use the format which represents the data in the smallest number of bytes". This is not true for strings between 32 and (2^8)-1 bytes whic...
Opengraph URL: https://github.com/msgpack/msgpack-python/pull/108
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:b4ef4ed5-4450-9b21-1a28-9c1261f2a09b |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | AE5A:241B02:6BCB64:997153:696FAE1F |
| html-safe-nonce | c58c3316b8f1784082bcc11c6d4d90bd9a22316bcdd1f94406b064c438303b2d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTVBOjI0MUIwMjo2QkNCNjQ6OTk3MTUzOjY5NkZBRTFGIiwidmlzaXRvcl9pZCI6IjcyOTc5NTE5NjgyMzI1MjUxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1ccbd82fb85b03128b132d420f52e7f8895f24de3463313e09d6a27e1e48b7db |
| hovercard-subject-tag | pull_request:22388124 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/msgpack/msgpack-python/pull/108/checks |
| twitter:image | https://avatars.githubusercontent.com/u/541939?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/541939?s=400&v=4 |
| og:image:alt | According to the spec "serializers SHOULD use the format which represents the data in the smallest number of bytes". This is not true for strings between 32 and (2^8)-1 bytes which has an... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 356c704aafcc9a6179b2bc62a546ee20a28226cdeddba29d8ae86c3750ef0f76 |
| turbo-cache-control | no-preview |
| go-import | github.com/msgpack/msgpack-python git https://github.com/msgpack/msgpack-python.git |
| octolytics-dimension-user_id | 198264 |
| octolytics-dimension-user_login | msgpack |
| octolytics-dimension-repository_id | 2242705 |
| octolytics-dimension-repository_nwo | msgpack/msgpack-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 2242705 |
| octolytics-dimension-repository_network_root_nwo | msgpack/msgpack-python |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e19b0670387556fcdd8027326ad85eecb0b536dd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width