Title: Canonicalising pack by stephenpascoe · Pull Request #1 · msgpack/msgpack-python · GitHub
Open Graph Title: Canonicalising pack by stephenpascoe · Pull Request #1 · msgpack/msgpack-python
X Title: Canonicalising pack by stephenpascoe · Pull Request #1 · msgpack/msgpack-python
Description: I'd like to make canonicalised pack data to make suitable for hashing. I've noticed msgpack-perl already supports this. Would you consider this patch to allow sorting of dictionary keys during packing? The code preserves the original logic as much as possible at the expense of repeating a for loop. This could be made more concise. Also has a test. Although I can't get the tests running because "msgpack.packs" doesn't exist.
Open Graph Description: I'd like to make canonicalised pack data to make suitable for hashing. I've noticed msgpack-perl already supports this. Would you consider this patch to allow sorting of dictionary keys d...
X Description: I'd like to make canonicalised pack data to make suitable for hashing. I've noticed msgpack-perl already supports this. Would you consider this patch to allow sorting of dictionar...
Opengraph URL: https://github.com/msgpack/msgpack-python/pull/1
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:93119b1b-23a3-69b5-3eae-05a88a9437c9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 868C:D6BAD:599036D:796D42F:697374E1 |
| html-safe-nonce | 90df77cd2e8148df641ebb362e469ca013b987d76843efd7c6131226517ab9b0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjhDOkQ2QkFEOjU5OTAzNkQ6Nzk2RDQyRjo2OTczNzRFMSIsInZpc2l0b3JfaWQiOiI0NzAyNTUxNjcxMTYwNjY1MzEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 512c0bca1794ea06af5d228a139282ce07bd3d5458580147ec0facf5c7e73b8b |
| hovercard-subject-tag | pull_request:426049 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/msgpack/msgpack-python/pull/1/files |
| twitter:image | https://avatars.githubusercontent.com/u/677427?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/677427?s=400&v=4 |
| og:image:alt | I'd like to make canonicalised pack data to make suitable for hashing. I've noticed msgpack-perl already supports this. Would you consider this patch to allow sorting of dictionary keys d... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4cf879a11b0a28a85543899a36aaee9ec9ca2fb7bedad86c0da5731193c95f01 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/msgpack/msgpack-python git https://github.com/msgpack/msgpack-python.git |
| octolytics-dimension-user_id | 198264 |
| octolytics-dimension-user_login | msgpack |
| octolytics-dimension-repository_id | 2242705 |
| octolytics-dimension-repository_nwo | msgpack/msgpack-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 2242705 |
| octolytics-dimension-repository_network_root_nwo | msgpack/msgpack-python |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fe8be790582ef7a55477ce1918ac0ed16b106d31 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width