René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Possible memory leak in `php_msgpack_unserialize`","articleBody":"Hi :wave:,\r\n\r\nI came across a possible memory leak in msgpack \r\n\r\nI can reproduce the leak in php `8.2` and `8.3` and in msgpack `2.2.0`, `3.0.0`, and `master`. \r\n\r\n```php\r\n\u003c?php\r\n$data = hex2bin('89716235369266a1b030656238313037383332393464363764');\r\n$unserialized = msgpack_unserialize($data);\r\n// var_dump($unserialized);\r\n```\r\n\r\nOutput:\r\n```bash\r\n❯ sapi/cli/php msgpack-reproducer.php\r\n\r\nWarning: [msgpack] (msgpack_unserialize_map_item) illegal key type in /home/mike/dev/phpfarm/src/php-8.3.11-debug/msgpack-reproducer.php on line 5\r\n\r\nWarning: Array to string conversion in /home/mike/dev/phpfarm/src/php-8.3.11-debug/msgpack-reproducer.php on line 5\r\n\r\nWarning: [msgpack] (php_msgpack_unserialize) Extra bytes in /home/mike/dev/phpfarm/src/php-8.3.11-debug/msgpack-reproducer.php on line 5\r\n[Thu Oct  3 10:31:36 2024]  Script:  '/home/mike/dev/phpfarm/src/php-8.3.11-debug/msgpack-reproducer.php'\r\n/home/mike/dev/phpfarm/src/php-8.3.11-debug/Zend/zend_string.h(174) :  Freeing 0x0000749bd1203c40 (32 bytes), script=/home/mike/dev/phpfarm/src/php-8.3.11-debug/msgpack-reproducer.php\r\n[Thu Oct  3 10:31:36 2024]  Script:  '/home/mike/dev/phpfarm/src/php-8.3.11-debug/msgpack-reproducer.php'\r\n/home/mike/dev/phpfarm/src/php-8.3.11-debug/Zend/zend_hash.c(291) :  Freeing 0x0000749bd125db40 (56 bytes), script=/home/mike/dev/phpfarm/src/php-8.3.11-debug/msgpack-reproducer.php\r\n[Thu Oct  3 10:31:36 2024]  Script:  '/home/mike/dev/phpfarm/src/php-8.3.11-debug/msgpack-reproducer.php'\r\n/home/mike/dev/phpfarm/src/php-8.3.11-debug/Zend/zend_hash.c(157) :  Freeing 0x0000749bd1261180 (136 bytes), script=/home/mike/dev/phpfarm/src/php-8.3.11-debug/msgpack-reproducer.php\r\n=== Total 3 memory leaks detected ===\r\n\r\n```\r\n\r\nValgrind has more info:\r\n\r\n```bash\r\n$ USE_ZEND_ALLOC=0 valgrind sapi/cli/php --leak-check=full msgpack-reproducer.php\r\n=620239== Command: sapi/cli/php msgpack-reproducer.php\r\n==620239==\r\n\r\nWarning: [msgpack] (msgpack_unserialize_map_item) illegal key type in /home/mike/dev/phpfarm/src/php-8.3.11-debug/msgpack-reproducer.php on line 5\r\n\r\nWarning: Array to string conversion in /home/mike/dev/phpfarm/src/php-8.3.11-debug/msgpack-reproducer.php on line 5\r\n\r\nWarning: [msgpack] (php_msgpack_unserialize) Extra bytes in /home/mike/dev/phpfarm/src/php-8.3.11-debug/msgpack-reproducer.php on line 5\r\n==620239==\r\n==620239== HEAP SUMMARY:\r\n==620239==     in use at exit: 224 bytes in 3 blocks\r\n==620239==   total heap usage: 31,171 allocs, 31,167 frees, 21,577,011 bytes allocated\r\n==620239==\r\n==620239== 224 (56 direct, 168 indirect) bytes in 1 blocks are definitely lost in loss record 3 of 3\r\n==620239==    at 0x484977B: malloc (vg_replace_malloc.c:446)\r\n==620239==    by 0xD9BD5B: __zend_malloc (zend_alloc.c:3128)\r\n==620239==    by 0xD9A9B0: _malloc_custom (zend_alloc.c:2491)\r\n==620239==    by 0xD9AAEE: _emalloc (zend_alloc.c:2610)\r\n==620239==    by 0xDED989: _zend_new_array (zend_hash.c:291)\r\n==620239==    by 0x8CA788: msgpack_unserialize_array (msgpack_unpack.c:550)\r\n==620239==    by 0x8C39BA: msgpack_unserialize_execute (unpack_template.h:231)\r\n==620239==    by 0x8C4B9D: php_msgpack_unserialize (msgpack.c:252)\r\n==620239==    by 0x8C4F2D: zif_msgpack_unserialize (msgpack.c:318)\r\n==620239==    by 0xE18118: ZEND_DO_ICALL_SPEC_RETVAL_USED_HANDLER (zend_vm_execute.h:1337)\r\n==620239==    by 0xE8DBD3: execute_ex (zend_vm_execute.h:57216)\r\n==620239==    by 0xE92419: zend_execute (zend_vm_execute.h:61604)\r\n==620239==\r\n==620239== LEAK SUMMARY:\r\n==620239==    definitely lost: 56 bytes in 1 blocks\r\n==620239==    indirectly lost: 168 bytes in 2 blocks\r\n==620239==      possibly lost: 0 bytes in 0 blocks\r\n==620239==    still reachable: 0 bytes in 0 blocks\r\n==620239==         suppressed: 0 bytes in 0 blocks\r\n```\r\n\r\nVersion info:\r\n\r\n```bash\r\nPHP 8.3.11 (cli) (built: Sep 15 2024 18:27:47) (NTS DEBUG)\r\nCopyright (c) The PHP Group\r\nZend Engine v4.3.11, Copyright (c) Zend Technologies\r\n\r\nmsgpack\r\n\r\nMessagePack Support =\u003e enabled\r\nSession Support =\u003e enabled\r\nMessagePack APCu Serializer ABI =\u003e no\r\nextension Version =\u003e 3.0.0\r\nheader Version =\u003e 3.2.0\r\n\r\nDirective =\u003e Local Value =\u003e Master Value\r\nmsgpack.error_display =\u003e On =\u003e On\r\nmsgpack.php_only =\u003e On =\u003e On\r\nmsgpack.assoc =\u003e On =\u003e On\r\nmsgpack.illegal_key_insert =\u003e Off =\u003e Off\r\nmsgpack.use_str8_serialization =\u003e On =\u003e On\r\n```\r\n\r\nLet me know if you need any more information. I might try and track it down but I'm not very familiar with the internal working of the library :smile:","author":{"url":"https://github.com/michael-grunder","@type":"Person","name":"michael-grunder"},"datePublished":"2024-10-03T17:45:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/176/msgpack-php/issues/176"}