René's URL Explorer Experiment


Title: Change the timing to emit 'msg' event to consume a buffer in advance by shinichy · Pull Request #32 · msgpack/msgpack-node · GitHub

Open Graph Title: Change the timing to emit 'msg' event to consume a buffer in advance by shinichy · Pull Request #32 · msgpack/msgpack-node

X Title: Change the timing to emit 'msg' event to consume a buffer in advance by shinichy · Pull Request #32 · msgpack/msgpack-node

Description: When I work with msgpack.Stream + deasync(https://github.com/abbr/deasync), the following program causes stack overflow. This issue is caused because msgpack.Stream emits 'msg' event before it consumes a buffer and deasync allows processing io events before finishing 'msg' event callbacks. I know this doesn't usually happen but it's better to emit 'msg' after consuming a buffer to handle this kind of case. 'use strict' var net = require('net'); var path = '/tmp/deasync.sock'; var msgpack = require('msgpack'); var server = net.createServer(function(c) { c.on('data', function() { c.write(msgpack.pack('foo')); }); c.on('end', function() { console.log('end') server.close() }) c.write(msgpack.pack('hello')); }); server.listen(path); var done = false; var client = net.createConnection(path) var stream = new msgpack.Stream(client) stream.on('msg', function(msg) { console.log('msg: ' + msg) if (msg === 'hello') { client.write(msgpack.pack('foo')); require('deasync').loopWhile(() => !done); console.log('done'); client.end() } else if (msg === 'foo') { done = true; } }); Output msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello msg: hello :0 RangeError: Maximum call stack size exceeded

Open Graph Description: When I work with msgpack.Stream + deasync(https://github.com/abbr/deasync), the following program causes stack overflow. This issue is caused because msgpack.Stream emits 'msg' event before...

X Description: When I work with msgpack.Stream + deasync(https://github.com/abbr/deasync), the following program causes stack overflow. This issue is caused because msgpack.Stream emits 'msg' even...

Opengraph URL: https://github.com/msgpack/msgpack-node/pull/32

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2935a44a-307d-bc63-41fd-84be81c796a7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD3E:147859:120CBC:185255:698F5ADA
html-safe-nonce1d807881231b73ced613d7637a5e308de002c0d358aec3600507949f392d4039
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDNFOjE0Nzg1OToxMjBDQkM6MTg1MjU1OjY5OEY1QURBIiwidmlzaXRvcl9pZCI6IjI5MjE0Nzg4MTI4Mjk5NjUwMTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9070cced02bfb8d992843d0cb0e7015e25d863ef2e3f00363887d2edcab93f7d
hovercard-subject-tagpull_request:52077370
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/msgpack/msgpack-node/pull/32/files
twitter:imagehttps://avatars.githubusercontent.com/u/900172?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/900172?s=400&v=4
og:image:altWhen I work with msgpack.Stream + deasync(https://github.com/abbr/deasync), the following program causes stack overflow. This issue is caused because msgpack.Stream emits 'msg' event before...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None974b952535e389ab3b5c0ef3f15bde9af29b6b38f7486069c43d99e51de0e563
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/msgpack/msgpack-node git https://github.com/msgpack/msgpack-node.git
octolytics-dimension-user_id198264
octolytics-dimension-user_loginmsgpack
octolytics-dimension-repository_id7430783
octolytics-dimension-repository_nwomsgpack/msgpack-node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7430783
octolytics-dimension-repository_network_root_nwomsgpack/msgpack-node
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb8e9d6dae5817b2dbe0a3d6d920ff8d3db837168
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/files#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-node%2Fpull%2F32%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-node%2Fpull%2F32%2Ffiles
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=msgpack%2Fmsgpack-node
Reloadhttps://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/files
Reloadhttps://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/files
Reloadhttps://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/files
msgpack https://patch-diff.githubusercontent.com/msgpack
msgpack-nodehttps://patch-diff.githubusercontent.com/msgpack/msgpack-node
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fmsgpack%2Fmsgpack-node
Fork 70 https://patch-diff.githubusercontent.com/login?return_to=%2Fmsgpack%2Fmsgpack-node
Star 316 https://patch-diff.githubusercontent.com/login?return_to=%2Fmsgpack%2Fmsgpack-node
Code https://patch-diff.githubusercontent.com/msgpack/msgpack-node
Issues 19 https://patch-diff.githubusercontent.com/msgpack/msgpack-node/issues
Pull requests 3 https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pulls
Actions https://patch-diff.githubusercontent.com/msgpack/msgpack-node/actions
Projects 0 https://patch-diff.githubusercontent.com/msgpack/msgpack-node/projects
Security 0 https://patch-diff.githubusercontent.com/msgpack/msgpack-node/security
Insights https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pulse
Code https://patch-diff.githubusercontent.com/msgpack/msgpack-node
Issues https://patch-diff.githubusercontent.com/msgpack/msgpack-node/issues
Pull requests https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pulls
Actions https://patch-diff.githubusercontent.com/msgpack/msgpack-node/actions
Projects https://patch-diff.githubusercontent.com/msgpack/msgpack-node/projects
Security https://patch-diff.githubusercontent.com/msgpack/msgpack-node/security
Insights https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fmsgpack%2Fmsgpack-node%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fmsgpack%2Fmsgpack-node%2Fissues%2Fnew%2Fchoose
shinichyhttps://patch-diff.githubusercontent.com/shinichy
msgpack:masterhttps://patch-diff.githubusercontent.com/msgpack/msgpack-node/tree/master
silkedit:change_emit_msg_timinghttps://patch-diff.githubusercontent.com/silkedit/msgpack-node/tree/change_emit_msg_timing
Conversation 0 https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32
Commits 1 https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/commits
Checks 0 https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/checks
Files changed https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/files
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/files
Change the timing to emit 'msg' event to consume a buffer in advance https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/files#top
Show all changes 1 commit https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/files
e2768d7 Change the timing to emit 'msg' event to consume a buffer in advance shinichy Nov 30, 2015 https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/commits/e2768d7e6960caa1e8886b5d84e4d6c60038140e
Clear filters https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/files
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/files
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/files
lib/msgpack.jshttps://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/files#diff-2a5ad80b81a2e53f90f361d448f7a18d44b5340a2d0b3766eacf65d211f754ec
View file https://patch-diff.githubusercontent.com/msgpack/msgpack-node/blob/e2768d7e6960caa1e8886b5d84e4d6c60038140e/lib/msgpack.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/files#diff-2a5ad80b81a2e53f90f361d448f7a18d44b5340a2d0b3766eacf65d211f754ec
https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/files#diff-2a5ad80b81a2e53f90f361d448f7a18d44b5340a2d0b3766eacf65d211f754ec
https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pull/32/files#diff-2a5ad80b81a2e53f90f361d448f7a18d44b5340a2d0b3766eacf65d211f754ec
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.