René's URL Explorer Experiment


Title: Optinally wrap msgpack_object instead of converting to V8 object · Issue #40 · msgpack/msgpack-node · GitHub

Open Graph Title: Optinally wrap msgpack_object instead of converting to V8 object · Issue #40 · msgpack/msgpack-node

X Title: Optinally wrap msgpack_object instead of converting to V8 object · Issue #40 · msgpack/msgpack-node

Description: Currently msgpack.unpack(), converts the msgpack_object from C/C++ lib into a V8 object visiting the msgpack_object entirely with recursion. Such an approach is known to be ~ 3.5 times slower than JSON.parse(). I could get approximately ...

Open Graph Description: Currently msgpack.unpack(), converts the msgpack_object from C/C++ lib into a V8 object visiting the msgpack_object entirely with recursion. Such an approach is known to be ~ 3.5 times slower than ...

X Description: Currently msgpack.unpack(), converts the msgpack_object from C/C++ lib into a V8 object visiting the msgpack_object entirely with recursion. Such an approach is known to be ~ 3.5 times slower than ...

Opengraph URL: https://github.com/msgpack/msgpack-node/issues/40

X: @github

direct link

Domain: patch-diff.githubusercontent.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Optinally wrap msgpack_object instead of converting to V8 object","articleBody":"Currently `msgpack.unpack()`, converts the `msgpack_object` from C/C++ lib into a V8 object visiting the `msgpack_object` entirely with recursion.\r\nSuch an approach is known to be ~ 3.5 times [slower](https://github.com/msgpack/msgpack-node#performance) than `JSON.parse()`. I could get approximately the same performance on nodejs 7.5 with msgpack 1.0.2.\r\n\r\nIn `msgpack.cc`, the recursive implementation of `msgpack_to_v8` repeatedly calls `Nan::New`.\r\nBuilding the V8 object is the most expensive part and disabling V8 object creation (C library `msgpack_unpack`) still being called, I could get encouraging numbers:\r\n\r\n`json: 723.140ms\r\nmsgpack: 458.431ms`\r\n\r\nmedian out of 10 runs of:\r\n\r\n```javascript\r\nconsole.time('json');\r\nvar sj = JSON.stringify(data);\r\nfor (let i = 0; i \u003c 500000; i++) {\r\n    JSON.parse(sj);\r\n}\r\nconsole.timeEnd('json');\r\nvar sj = msgpack.pack(data);\r\nconsole.time('msgpack');\r\nfor (let i = 0; i \u003c 500000; i++) {\r\n    msgpack.unpack(sj);\r\n}\r\nconsole.timeEnd('msgpack');\r\n```\r\n\r\nsuggesting that most of the time is spent to build a V8 object.\r\n\r\nIn some use cases where the full object is not needed or not repeatedly accessed, better performance could be achieved wrapping the `msgpack_object` struct within a V8 object with getters of computed property names (not sure how transparent that can be).\r\n\r\nIf an `msgpack_object` representing:\r\n\r\n```javascript\r\nvar o = {\"a\" : 1, \"b\" : 2, \"c\" : [1, 2, 3]};\r\n```\r\n\r\nis given, `o.c[1]` only creates and returns a number instead of the full object structure.\r\nAssumption is to have less overhead and performance comparable to direct use of C library.\r\nWas this ever tried? Does it make sense at all?","author":{"url":"https://github.com/comick","@type":"Person","name":"comick"},"datePublished":"2017-02-26T13:59:33.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/40/msgpack-node/issues/40"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:133f1efd-da48-23ee-fa49-5c2ed28af8f6
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD7BA:8D4A2:173131D:1DD1A8A:698FF12C
html-safe-nonce6ab288572c23b1b79a494bfe666215872d3e80f147b5318503b2f4eff53798d5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0JBOjhENEEyOjE3MzEzMUQ6MUREMUE4QTo2OThGRjEyQyIsInZpc2l0b3JfaWQiOiI1ODcyODU1NTYxMjUxMzIwMTA4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4421e1a78a8396c4e7229959845a06057922a19073bc84ff5b5e6d6ec99b045c
hovercard-subject-tagissue:210320137
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/msgpack/msgpack-node/40/issue_layout
twitter:imagehttps://opengraph.githubassets.com/57594c4d72ba3d3ece6e402221bc1fe7ccd66b4d1cc7d8be2c767e7413343e21/msgpack/msgpack-node/issues/40
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/57594c4d72ba3d3ece6e402221bc1fe7ccd66b4d1cc7d8be2c767e7413343e21/msgpack/msgpack-node/issues/40
og:image:altCurrently msgpack.unpack(), converts the msgpack_object from C/C++ lib into a V8 object visiting the msgpack_object entirely with recursion. Such an approach is known to be ~ 3.5 times slower than ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecomick
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-preview
go-importgithub.com/msgpack/msgpack-node git https://github.com/msgpack/msgpack-node.git
octolytics-dimension-user_id198264
octolytics-dimension-user_loginmsgpack
octolytics-dimension-repository_id7430783
octolytics-dimension-repository_nwomsgpack/msgpack-node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7430783
octolytics-dimension-repository_network_root_nwomsgpack/msgpack-node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/msgpack/msgpack-node/issues/40#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-node%2Fissues%2F40
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-node%2Fissues%2F40
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=msgpack%2Fmsgpack-node
Reloadhttps://patch-diff.githubusercontent.com/msgpack/msgpack-node/issues/40
Reloadhttps://patch-diff.githubusercontent.com/msgpack/msgpack-node/issues/40
Reloadhttps://patch-diff.githubusercontent.com/msgpack/msgpack-node/issues/40
msgpack https://patch-diff.githubusercontent.com/msgpack
msgpack-nodehttps://patch-diff.githubusercontent.com/msgpack/msgpack-node
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fmsgpack%2Fmsgpack-node
Fork 70 https://patch-diff.githubusercontent.com/login?return_to=%2Fmsgpack%2Fmsgpack-node
Star 316 https://patch-diff.githubusercontent.com/login?return_to=%2Fmsgpack%2Fmsgpack-node
Code https://patch-diff.githubusercontent.com/msgpack/msgpack-node
Issues 19 https://patch-diff.githubusercontent.com/msgpack/msgpack-node/issues
Pull requests 3 https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pulls
Actions https://patch-diff.githubusercontent.com/msgpack/msgpack-node/actions
Projects 0 https://patch-diff.githubusercontent.com/msgpack/msgpack-node/projects
Security 0 https://patch-diff.githubusercontent.com/msgpack/msgpack-node/security
Insights https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pulse
Code https://patch-diff.githubusercontent.com/msgpack/msgpack-node
Issues https://patch-diff.githubusercontent.com/msgpack/msgpack-node/issues
Pull requests https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pulls
Actions https://patch-diff.githubusercontent.com/msgpack/msgpack-node/actions
Projects https://patch-diff.githubusercontent.com/msgpack/msgpack-node/projects
Security https://patch-diff.githubusercontent.com/msgpack/msgpack-node/security
Insights https://patch-diff.githubusercontent.com/msgpack/msgpack-node/pulse
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/msgpack/msgpack-node/issues/40
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/msgpack/msgpack-node/issues/40
Optinally wrap msgpack_object instead of converting to V8 objecthttps://patch-diff.githubusercontent.com/msgpack/msgpack-node/issues/40#top
https://github.com/comick
https://github.com/comick
comickhttps://github.com/comick
on Feb 26, 2017https://github.com/msgpack/msgpack-node/issues/40#issue-210320137
slowerhttps://github.com/msgpack/msgpack-node#performance
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.