René's URL Explorer Experiment


Title: Call toJSON() on non-ext objects when it exists by kevincennis · Pull Request #188 · msgpack/msgpack-javascript · GitHub

Open Graph Title: Call toJSON() on non-ext objects when it exists by kevincennis · Pull Request #188 · msgpack/msgpack-javascript

X Title: Call toJSON() on non-ext objects when it exists by kevincennis · Pull Request #188 · msgpack/msgpack-javascript

Description: Currently, @msgpack/msgpack does not automatically call .toJSON() on objects which define that method. Since JSON and msgpack have significant overlap in semantics and intent, and toJSON() is a sig...

Open Graph Description: Currently, @msgpack/msgpack does not automatically call .toJSON() on objects which define that method. Since JSON and msgpack have significant overlap in semantics and intent, and toJSON() is a sig...

X Description: Currently, @msgpack/msgpack does not automatically call .toJSON() on objects which define that method. Since JSON and msgpack have significant overlap in semantics and intent, and toJSON() is a sig...

Opengraph URL: https://github.com/msgpack/msgpack-javascript/pull/188

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bdc6f115-d10f-611b-c6e9-c6e19a6ccfcc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD534:A9721:49FD2E9:64A93B3:69730CD7
html-safe-nonceb98c2aea0114fcb1ab37d18f15cee72a338ad6e331e19774c0a19421f0ab89b9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTM0OkE5NzIxOjQ5RkQyRTk6NjRBOTNCMzo2OTczMENENyIsInZpc2l0b3JfaWQiOiIzNTk5MjUxNDkwNDM5NDk2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac044ff2ec2c42df98a8bec6e4ce766c9c4eb748c8ab53ff28f7614e0e3a63f964
hovercard-subject-tagpull_request:717126121
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/msgpack/msgpack-javascript/188/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bf7e4269392f08c9b52df96d418da16a3657277fd727dfbfcc29c1dbc332c39c/msgpack/msgpack-javascript/pull/188
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bf7e4269392f08c9b52df96d418da16a3657277fd727dfbfcc29c1dbc332c39c/msgpack/msgpack-javascript/pull/188
og:image:altCurrently, @msgpack/msgpack does not automatically call .toJSON() on objects which define that method. Since JSON and msgpack have significant overlap in semantics and intent, and toJSON() is a sig...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekevincennis
hostnamegithub.com
expected-hostnamegithub.com
None44ab3188c1dcfe3be0f9c3feca2e04e14fb79f120939ce2395e4f15ab96ec1d4
turbo-cache-controlno-preview
go-importgithub.com/msgpack/msgpack-javascript git https://github.com/msgpack/msgpack-javascript.git
octolytics-dimension-user_id198264
octolytics-dimension-user_loginmsgpack
octolytics-dimension-repository_id2761854
octolytics-dimension-repository_nwomsgpack/msgpack-javascript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id2761854
octolytics-dimension-repository_network_root_nwomsgpack/msgpack-javascript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea5e2b48bd1260476599758f5d253b5d24092ab84
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-javascript%2Fpull%2F188
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-javascript%2Fpull%2F188
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=msgpack%2Fmsgpack-javascript
Reloadhttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
Reloadhttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
Reloadhttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
msgpack https://patch-diff.githubusercontent.com/msgpack
msgpack-javascripthttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fmsgpack%2Fmsgpack-javascript
Fork 173 https://patch-diff.githubusercontent.com/login?return_to=%2Fmsgpack%2Fmsgpack-javascript
Star 1.5k https://patch-diff.githubusercontent.com/login?return_to=%2Fmsgpack%2Fmsgpack-javascript
Code https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript
Issues 16 https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/issues
Pull requests 4 https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pulls
Discussions https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/discussions
Actions https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/actions
Security 0 https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/security
Insights https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pulse
Code https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript
Issues https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/issues
Pull requests https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pulls
Discussions https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/discussions
Actions https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/actions
Security https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/security
Insights https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fmsgpack%2Fmsgpack-javascript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fmsgpack%2Fmsgpack-javascript%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188#issue-comment-box
kevincennishttps://patch-diff.githubusercontent.com/kevincennis
msgpack:mainhttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/tree/main
kevincennis:mainhttps://patch-diff.githubusercontent.com/kevincennis/msgpack-javascript/tree/main
Call toJSON() on non-ext objects when it exists https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188#top
kevincennishttps://patch-diff.githubusercontent.com/kevincennis
msgpack:mainhttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/tree/main
kevincennis:mainhttps://patch-diff.githubusercontent.com/kevincennis/msgpack-javascript/tree/main
Conversation 8 https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
Commits 1 https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188/commits
Checks 0 https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188/checks
Files changed https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188/files
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/kevincennis
kevincennishttps://patch-diff.githubusercontent.com/kevincennis
Aug 21, 2021https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188#issue-976096010
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
toJSON()https://tc39.es/ecma262/#sec-serializejsonproperty
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
https://patch-diff.githubusercontent.com/kevincennis
kevincennishttps://patch-diff.githubusercontent.com/kevincennis
Aug 21, 2021https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188#issuecomment-903091464
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
this commit in msgpack/msgpack-nodehttps://github.com/msgpack/msgpack-node/commit/44f322bd89c1b317f3895ee9700d3336c0723c01
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
https://patch-diff.githubusercontent.com/kevincennis
Call toJSON() on non-ext objects when it existshttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188/commits/b04a35109940a6ada4c9a1c207990ebfd78eb0cf
b04a351https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188/commits/b04a35109940a6ada4c9a1c207990ebfd78eb0cf
https://patch-diff.githubusercontent.com/kevincennis
kevincennishttps://patch-diff.githubusercontent.com/kevincennis
force-pushedhttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/compare/02d8ae61f200b581c69c293da855d2257b7d9e5a..b04a35109940a6ada4c9a1c207990ebfd78eb0cf
02d8ae6https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/commit/02d8ae61f200b581c69c293da855d2257b7d9e5a
b04a351https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/commit/b04a35109940a6ada4c9a1c207990ebfd78eb0cf
Compare https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/compare/02d8ae61f200b581c69c293da855d2257b7d9e5a..b04a35109940a6ada4c9a1c207990ebfd78eb0cf
August 21, 2021 10:14https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188#event-5189665655
https://patch-diff.githubusercontent.com/codecov-commenter
codecov-commenterhttps://patch-diff.githubusercontent.com/codecov-commenter
Aug 23, 2021https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188#issuecomment-903376659
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
Codecovhttps://codecov.io/gh/msgpack/msgpack-javascript/pull/188?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack
#188https://codecov.io/gh/msgpack/msgpack-javascript/pull/188?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack
1b6f0b6https://github.com/msgpack/msgpack-javascript/commit/1b6f0b6ed16f5247318cdaa6267450017d4346ba
mainhttps://codecov.io/gh/msgpack/msgpack-javascript/commit/97700045f68664cf6c8c09d135e2dd387dbc9b6c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack
9770004https://github.com/msgpack/msgpack-javascript/commit/97700045f68664cf6c8c09d135e2dd387dbc9b6c
1b6f0b6https://github.com/msgpack/msgpack-javascript/commit/1b6f0b6ed16f5247318cdaa6267450017d4346ba
b04a351https://github.com/msgpack/msgpack-javascript/commit/b04a35109940a6ada4c9a1c207990ebfd78eb0cf
b04a351https://github.com/msgpack/msgpack-javascript/commit/b04a35109940a6ada4c9a1c207990ebfd78eb0cf
https://codecov.io/gh/msgpack/msgpack-javascript/pull/188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack
Impacted Fileshttps://codecov.io/gh/msgpack/msgpack-javascript/pull/188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack
src/Encoder.tshttps://codecov.io/gh/msgpack/msgpack-javascript/pull/188/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack#diff-c3JjL0VuY29kZXIudHM=
Continue to review full report at Codecovhttps://codecov.io/gh/msgpack/msgpack-javascript/pull/188?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack
Codecovhttps://codecov.io/gh/msgpack/msgpack-javascript/pull/188?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack
9770004...b04a351https://codecov.io/gh/msgpack/msgpack-javascript/pull/188?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack
comment docshttps://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
https://patch-diff.githubusercontent.com/gfx
gfxhttps://patch-diff.githubusercontent.com/gfx
Aug 23, 2021https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188#issuecomment-903378983
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
type extensionshttps://github.com/msgpack/msgpack-javascript#extension-types
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
https://patch-diff.githubusercontent.com/kevincennis
kevincennishttps://patch-diff.githubusercontent.com/kevincennis
Aug 23, 2021https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188#issuecomment-903449940
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify#tojson_behaviorhttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify#tojson_behavior
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
https://patch-diff.githubusercontent.com/kevincennis
kevincennishttps://patch-diff.githubusercontent.com/kevincennis
Aug 23, 2021https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188#issuecomment-903822400
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
https://github.com/moment/moment/blob/e96809208c9d1b1bbe22d605e76985770024de42/src/lib/moment/prototype.js#L66https://github.com/moment/moment/blob/e96809208c9d1b1bbe22d605e76985770024de42/src/lib/moment/prototype.js#L66
https://github.com/Automattic/mongoose/blob/master/lib/document.js#L3794https://github.com/Automattic/mongoose/blob/master/lib/document.js#L3794
https://github.com/immutable-js/immutable-js/blob/cb534f07b4187c1c32cd1a166dec257f55f28c51/src/Record.js#L230https://github.com/immutable-js/immutable-js/blob/cb534f07b4187c1c32cd1a166dec257f55f28c51/src/Record.js#L230
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
https://patch-diff.githubusercontent.com/gfx
gfxhttps://patch-diff.githubusercontent.com/gfx
Sep 1, 2021https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188#issuecomment-909793517
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
https://patch-diff.githubusercontent.com/kevincennis
kevincennishttps://patch-diff.githubusercontent.com/kevincennis
Sep 1, 2021https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188#issuecomment-910170466
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
https://patch-diff.githubusercontent.com/spmurrayzzz
spmurrayzzzhttps://patch-diff.githubusercontent.com/spmurrayzzz
Sep 3, 2021https://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188#issuecomment-912596735
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
@kevincennishttps://github.com/kevincennis
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-javascript%2Fpull%2F188
Please reload this pagehttps://patch-diff.githubusercontent.com/msgpack/msgpack-javascript/pull/188
https://patch-diff.githubusercontent.com/kevincennis
https://patch-diff.githubusercontent.com/codecov-commenter
https://patch-diff.githubusercontent.com/gfx
https://patch-diff.githubusercontent.com/spmurrayzzz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.