René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Loading modules.json with the wrong encoding","articleBody":"After installing Unity Editor 2019.4.15f1 with Unity Hub 2.4.2 on Japanese Windows 10 Pro 2004, `Get-UnitySetupInstance` complains with the following error:\r\n\r\n```console\r\nPS C:\\Program Files\\Unity\\Hub\\Editor\\2019.4.15f1\u003e Get-UnitySetupInstance\r\n警告: ':' または '}' ではなく無効なオブジェクトが渡されました。 (7767): [{\"id\":\"visualstudio\",\"name\":\"Microsoft Visual Studio Community 2019\",\"description\":\"Downloads and installs.... (snipped)\r\n```\r\n\r\nIt orignates from this line:\r\n\r\nhttps://github.com/microsoft/unitysetup.powershell/blob/602fb720ea42220dae7a85b5b63cbc5538ff06a4/UnitySetup/UnitySetup.psm1#L1236\r\n\r\n`Get-Content -Raw` loads `modules.json` with the wrong encoding which causes subsequent `ConvertFrom-Json` to fail:\r\n\r\n```console\r\nPS C:\\Program Files\\Unity\\Hub\\Editor\\2019.4.15f1\u003e Get-Content .\\modules.json -Raw | ConvertFrom-Json\r\nConvertFrom-Json : ':' または '}' ではなく無効なオブジェクトが渡されました。 (7767): [{\"id\":\"visualstudio\",\"name\":\"Microsoft Visual Studio Community 2019\",\"description\":\"Downloads and installs.... (snipped)\r\n```\r\n\r\n`modules.json` is actually in UTF-8 without BOM.  `Get-Content -Encoding UTF8` would workaround this case, but I'm not confident whether it's a correct fix:\r\n\r\n```console\r\nPS C:\\Program Files\\Unity\\Hub\\Editor\\2019.4.15f1\u003e Get-Content .\\modules.json -Encoding UTF8 | ConvertFrom-Json\r\n\r\n\r\nid            : visualstudio\r\nname          : Microsoft Visual Studio Community 2019\r\ndescription   : Downloads and installs Microsoft Visual Studio Community 2019. By installing this you accept the license terms for Visual Studio.\r\ndownloadUrl   : https://go.microsoft.com/fwlink/?linkid=2086755\r\ncategory      : Dev tools\r\ninstalledSize : 1331200000\r\ndownloadSize  : 1363148800\r\nvisible       : True\r\nselected      : False\r\ncmd           : --productId \"Microsoft.VisualStudio.Product.Community\" --add \"Microsoft.VisualStudio.Workload.ManagedGame\" --add \"Microsoft.VisualStudio.Workload.NativeDesktop\" --add \"Microsoft.VisualStudio.Component.VC.Tools.x86.x64\" --add \"Microsoft.VisualStudio.Comp\r\n                onent.Windows10SDK.16299.Desktop\" --campaign \"Unity3d_Unity\" --passive --norestart --wait\r\neulaUrl1      : https://go.microsoft.com/fwlink/?linkid=2092534\r\neulaLabel1    : Visual Studio 2019 Community License Terms\r\neulaMessage   : Please review and accept the license terms before downloading and installing Microsoft Visual Studio.\r\n\r\n...(snipped)...\r\n\r\nid            : language-ja\r\nname          : 日本語\r\ndescription   : 日本語\r\ndownloadUrl   : https://new-translate.unity3d.jp/v1/live/54/2019.4/ja\r\ncategory      : Language packs (Preview)\r\nvisible       : True\r\nselected      : False\r\ndestination   : {UNITY_PATH}/Editor/Data/Localization\r\ninstalledSize : 1739231\r\ndownloadSize  : 1739231\r\n\r\n...(snipped)\r\n```\r\n\r\nIt would be better to have a fall back path on modules.json parsing failures by adding a try-catch block.","author":{"url":"https://github.com/yaegashi","@type":"Person","name":"yaegashi"},"datePublished":"2020-11-29T05:20:23.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/218/unitysetup.powershell/issues/218"}