| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2fe135f7-87f7-3b5c-b11a-dbcbc0bd1f1d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AD70:85F87:2E5252:3ACB0D:697F3D61 |
| html-safe-nonce | 7160e5bf54662583fc7bb172582af38e52384f6b5574075b6d9830fc31278eb2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDcwOjg1Rjg3OjJFNTI1MjozQUNCMEQ6Njk3RjNENjEiLCJ2aXNpdG9yX2lkIjoiNzE2NzAwMzcyOTUxMjU3ODQwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 97f7a63471352fc764b002985ebb0d2a406dd5117d43106612c8ef3be4a7ef17 |
| hovercard-subject-tag | pull_request:1761003648 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/node-api-dotnet/217/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/014f2329ed9477e71a15d609d3a8c8b9d1844cc1a3d6de99df6ebc67844884fe/microsoft/node-api-dotnet/pull/217 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/014f2329ed9477e71a15d609d3a8c8b9d1844cc1a3d6de99df6ebc67844884fe/microsoft/node-api-dotnet/pull/217 |
| og:image:alt | .NET provides multiple APIs for loading libraries. One of them is NativeLibrary.Load(string), which imports the library directly from the specified path. However, this requires the caller to search... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | samardzicneo |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/node-api-dotnet git https://github.com/microsoft/node-api-dotnet.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 608430367 |
| octolytics-dimension-repository_nwo | microsoft/node-api-dotnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 608430367 |
| octolytics-dimension-repository_network_root_nwo | microsoft/node-api-dotnet |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7c85641c598ad130c74f7bcc27f58575cac69551 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fnode-api-dotnet%2Fpull%2F217 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fnode-api-dotnet%2Fpull%2F217 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fnode-api-dotnet |
| Reload | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| Reload | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| Reload | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
|
microsoft
| https://patch-diff.githubusercontent.com/microsoft |
| node-api-dotnet | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fmicrosoft%2Fnode-api-dotnet |
|
Fork
77
| https://patch-diff.githubusercontent.com/login?return_to=%2Fmicrosoft%2Fnode-api-dotnet |
|
Star
724
| https://patch-diff.githubusercontent.com/login?return_to=%2Fmicrosoft%2Fnode-api-dotnet |
|
Code
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet |
|
Issues
55
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/issues |
|
Pull requests
6
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pulls |
|
Discussions
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/discussions |
|
Actions
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/actions |
|
Projects
1
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/projects |
|
Models
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/models |
|
Security
0
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/security |
|
Insights
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pulse |
|
Code
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet |
|
Issues
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pulls |
|
Discussions
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/discussions |
|
Actions
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/actions |
|
Projects
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/projects |
|
Models
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/models |
|
Security
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/security |
|
Insights
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Fmicrosoft%2Fnode-api-dotnet%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Fmicrosoft%2Fnode-api-dotnet%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#issue-comment-box |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| microsoft:main | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/tree/main |
| samardzicneo:high-level-library-load | https://patch-diff.githubusercontent.com/samardzicneo/node-api-dotnet/tree/high-level-library-load |
|
Use high-level library load API
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#top |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| microsoft:main | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/tree/main |
| samardzicneo:high-level-library-load | https://patch-diff.githubusercontent.com/samardzicneo/node-api-dotnet/tree/high-level-library-load |
|
Conversation
28
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
|
Commits
21
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/files |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#issue-2173824637 |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| https://patch-diff.githubusercontent.com/samardzicneo |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| force-pushed | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/compare/b3691018a3c3a2c40f0904289c3a0a689c3e0df5..0708d4438d1ba9a063bdbe7365c7a42b8f83db5d |
| b369101 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/commit/b3691018a3c3a2c40f0904289c3a0a689c3e0df5 |
| 0708d44 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/commit/0708d4438d1ba9a063bdbe7365c7a42b8f83db5d |
|
Compare
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/compare/b3691018a3c3a2c40f0904289c3a0a689c3e0df5..0708d4438d1ba9a063bdbe7365c7a42b8f83db5d |
| March 7, 2024 13:51 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#event-12042640692 |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| use high-level library loading | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/d765df3c9cefaca58ae1e875c81cd599535a6847 |
| d765df3 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/d765df3c9cefaca58ae1e875c81cd599535a6847 |
| https://patch-diff.githubusercontent.com/samardzicneo |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| force-pushed | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/compare/0708d4438d1ba9a063bdbe7365c7a42b8f83db5d..d765df3c9cefaca58ae1e875c81cd599535a6847 |
| 0708d44 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/commit/0708d4438d1ba9a063bdbe7365c7a42b8f83db5d |
| d765df3 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/commit/d765df3c9cefaca58ae1e875c81cd599535a6847 |
|
Compare
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/compare/0708d4438d1ba9a063bdbe7365c7a42b8f83db5d..d765df3c9cefaca58ae1e875c81cd599535a6847 |
| March 7, 2024 13:52 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#event-12042653208 |
| https://patch-diff.githubusercontent.com/samardzicneo |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| March 7, 2024 18:39 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#event-12046460422 |
| https://patch-diff.githubusercontent.com/samardzicneo |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#issuecomment-1984196395 |
| @jasongin | https://github.com/jasongin |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| https://patch-diff.githubusercontent.com/jasongin |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#issuecomment-1984202324 |
| Build libnode and publish nuget packages #107 | https://github.com/microsoft/node-api-dotnet/issues/107 |
| from a fixed path in the repo | https://github.com/microsoft/node-api-dotnet/blob/def23a58c9d9c7083549087f1ed7421a3f5e5478/test/TestUtils.cs#L76 |
| NativeLibrary.cs | https://github.com/microsoft/node-api-dotnet/blob/main/src/NodeApi/Runtime/NativeLibrary.cs |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| maybe fix build | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/d877e5445338a1095906e3707e7d010afe8b853d |
| d877e54 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/d877e5445338a1095906e3707e7d010afe8b853d |
| https://patch-diff.githubusercontent.com/samardzicneo |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#issuecomment-1984325827 |
| @jasongin | https://github.com/jasongin |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| March 7, 2024 21:03 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#commits-pushed-1dd3250 |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| undo brainfart moment | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/1dd3250dea6f962b32d918e5d926d692a7a4024d |
| 1dd3250 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/1dd3250dea6f962b32d918e5d926d692a7a4024d |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| this will fix it | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/e6fa1c6f34aa0c47a72e2aa7f0c637d1d7a608f5 |
| e6fa1c6 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/e6fa1c6f34aa0c47a72e2aa7f0c637d1d7a608f5 |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| i need more sleep | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/61c787a463769395ad98bf818e9e185b4dd4da2c |
| 61c787a | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/61c787a463769395ad98bf818e9e185b4dd4da2c |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| remove using directive and reference Assembly by full name | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/ca3313c5b1d79043b67f3037284d8d8a646ba719 |
| ca3313c | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/ca3313c5b1d79043b67f3037284d8d8a646ba719 |
| https://patch-diff.githubusercontent.com/samardzicneo |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| March 7, 2024 20:24 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#event-12047663015 |
| https://patch-diff.githubusercontent.com/jasongin |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
|
Mar 7, 2024
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#pullrequestreview-1923650668 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/files/ca3313c5b1d79043b67f3037284d8d8a646ba719 |
| src/NodeApi/Runtime/NodejsPlatform.cs | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/files/ca3313c5b1d79043b67f3037284d8d8a646ba719#diff-a296b2b4612ef459a5e60ef7ce6a23261a27c19432914dacb2f2696800448378 |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1516896610 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| Mar 9, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1518577861 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| src/NodeApi/Runtime/NodejsPlatform.cs | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/files/ca3313c5b1d79043b67f3037284d8d8a646ba719#diff-a296b2b4612ef459a5e60ef7ce6a23261a27c19432914dacb2f2696800448378 |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1516897782 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| Mar 9, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1518578456 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| src/NodeApi/Runtime/NodejsPlatform.cs | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/files/ca3313c5b1d79043b67f3037284d8d8a646ba719#diff-a296b2b4612ef459a5e60ef7ce6a23261a27c19432914dacb2f2696800448378 |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1516900689 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| Mar 9, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1518577762 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| https://patch-diff.githubusercontent.com/jasongin |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#issuecomment-1984594245 |
| @samardzicneo | https://github.com/samardzicneo |
| #218 | https://github.com/microsoft/node-api-dotnet/issues/218 |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| https://patch-diff.githubusercontent.com/samardzicneo |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#issuecomment-1984626741 |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| @jasongin | https://github.com/jasongin |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| March 9, 2024 14:04 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#commits-pushed-06121a9 |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| Merge branch 'main' into high-level-library-load | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/06121a96939af5aa5f5dc54ffd5baf0fc661bfa9 |
| 06121a9 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/06121a96939af5aa5f5dc54ffd5baf0fc661bfa9 |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| try to add search | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/f751f2b76d55793edc7a64f9c7a4351a9573d274 |
| f751f2b | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/f751f2b76d55793edc7a64f9c7a4351a9573d274 |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| update platform file | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/c9b67b630a7b831ee07db6621e519a295dea3572 |
| c9b67b6 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/c9b67b630a7b831ee07db6621e519a295dea3572 |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| use path combine | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/2497f24ae36ca810f97bf642184957ed3337506e |
| 2497f24 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/2497f24ae36ca810f97bf642184957ed3337506e |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| fix build | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/f24f6d2a5e416e4a2f35f214cefc2490ecae7859 |
| f24f6d2 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/f24f6d2a5e416e4a2f35f214cefc2490ecae7859 |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| fix nullability | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/009a09f0990ae93f4dfce32843c9802e36096724 |
| 009a09f | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/009a09f0990ae93f4dfce32843c9802e36096724 |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| add null check | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/e6e1b386db82a0fcda82802b175fde789b9eff45 |
| e6e1b38 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/e6e1b386db82a0fcda82802b175fde789b9eff45 |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| fix loading call | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/16e53be20fcd2b73764f2aac0ba4540c3f069bcb |
| 16e53be | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/16e53be20fcd2b73764f2aac0ba4540c3f069bcb |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| simplify null check | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/f3b8f1e8feac05f8ecf39f55d336260ae07fd876 |
| f3b8f1e | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/f3b8f1e8feac05f8ecf39f55d336260ae07fd876 |
| https://patch-diff.githubusercontent.com/samardzicneo |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
| March 9, 2024 14:21 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#event-12063243839 |
| https://patch-diff.githubusercontent.com/jasongin |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
|
Mar 13, 2024
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#pullrequestreview-1933030421 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/files/f3b8f1e8feac05f8ecf39f55d336260ae07fd876 |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#pullrequestreview-1933030421 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| src/NodeApi/Runtime/NodejsPlatform.cs | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/files/f3b8f1e8feac05f8ecf39f55d336260ae07fd876#diff-a296b2b4612ef459a5e60ef7ce6a23261a27c19432914dacb2f2696800448378 |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
| Mar 13, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1522372743 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| the default search behavior is considered unsafe | https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca5393 |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| Mar 13, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1523352384 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| src/NodeApi/Runtime/NativeLibrary.cs | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/files/f3b8f1e8feac05f8ecf39f55d336260ae07fd876#diff-2160d39720e6d97a2f74dcbdf18d55ab22620e1b7e50477be3b59beb069ce2c0 |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
| Mar 13, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1522372956 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| Mar 13, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1523352544 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| src/NodeApi/Runtime/NativeLibrary.cs | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/files/f3b8f1e8feac05f8ecf39f55d336260ae07fd876#diff-2160d39720e6d97a2f74dcbdf18d55ab22620e1b7e50477be3b59beb069ce2c0 |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
| Mar 13, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1522375189 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| Mar 13, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1523353033 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| fix safety concerns | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/11cfb01c0a64b2e6208e66cc598af1a53172b3dc |
| 11cfb01 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/11cfb01c0a64b2e6208e66cc598af1a53172b3dc |
| https://patch-diff.githubusercontent.com/samardzicneo |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| Mar 13, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#issuecomment-1994476147 |
| @jasongin | https://github.com/jasongin |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| different search path | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/678e3ba3e0f3424c3860680ff0fa76b5e3d3936c |
| 678e3ba | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/678e3ba3e0f3424c3860680ff0fa76b5e3d3936c |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| March 13, 2024 15:26 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#commits-pushed-5b0e460 |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| make search path more specific | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/5b0e460aa2eaf06449901d31dc0e4426979724bb |
| 5b0e460 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/5b0e460aa2eaf06449901d31dc0e4426979724bb |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| Merge branch 'microsoft:main' into high-level-library-load | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/11a708ee951bde70332c904527dea2c6ce3acd12 |
| 11a708e | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/11a708ee951bde70332c904527dea2c6ce3acd12 |
| https://patch-diff.githubusercontent.com/samardzicneo |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
| March 13, 2024 14:27 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#event-12104434614 |
| https://patch-diff.githubusercontent.com/jasongin |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
|
Mar 22, 2024
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#pullrequestreview-1953717054 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/files/11a708ee951bde70332c904527dea2c6ce3acd12 |
| src/NodeApi/Runtime/NodejsPlatform.cs | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/files/11a708ee951bde70332c904527dea2c6ce3acd12#diff-a296b2b4612ef459a5e60ef7ce6a23261a27c19432914dacb2f2696800448378 |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
| Mar 22, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1534885668 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| listed as one of the unsafe options | https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca5393 |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| Mar 24, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1536762768 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
| Apr 6, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1554480990 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| dotnet/dotnet-api-docs#3205 | https://github.com/dotnet/dotnet-api-docs/issues/3205 |
| disabled by default | https://github.com/dotnet/roslyn-analyzers/issues/2855 |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
| Apr 6, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1554485987 |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| src/NodeApi/Runtime/NativeLibrary.cs | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/files/11a708ee951bde70332c904527dea2c6ce3acd12#diff-2160d39720e6d97a2f74dcbdf18d55ab22620e1b7e50477be3b59beb069ce2c0 |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| src/NodeApi/Runtime/NativeLibrary.cs | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/files/11a708ee951bde70332c904527dea2c6ce3acd12#diff-2160d39720e6d97a2f74dcbdf18d55ab22620e1b7e50477be3b59beb069ce2c0 |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
| Mar 22, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1534908485 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| Mar 24, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1536762005 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| jasongin | https://patch-diff.githubusercontent.com/jasongin |
| Apr 6, 2024 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#discussion_r1554477477 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| src/NodeApi/Runtime/NativeLibrary.cs | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/files/11a708ee951bde70332c904527dea2c6ce3acd12#diff-2160d39720e6d97a2f74dcbdf18d55ab22620e1b7e50477be3b59beb069ce2c0 |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
| samardzicneo | https://patch-diff.githubusercontent.com/samardzicneo |
| March 27, 2024 13:59 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#commits-pushed-0260cbd |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| Merge branch 'main' into high-level-library-load | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/0260cbde1c1c0b1a35836eb098cc54d84fe0ed7e |
| 0260cbd | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/0260cbde1c1c0b1a35836eb098cc54d84fe0ed7e |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
| threads | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/bc1091cae0196a5d2f05b73e694da16657af54e0 |
| bc1091c | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/commits/bc1091cae0196a5d2f05b73e694da16657af54e0 |
| https://patch-diff.githubusercontent.com/vmoroz |
| vmoroz | https://patch-diff.githubusercontent.com/vmoroz |
| Mar 14, 2025 | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217#event-16781337439 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fnode-api-dotnet%2Fpull%2F217 |
|
| https://patch-diff.githubusercontent.com/jasongin |
|
jasongin
| https://patch-diff.githubusercontent.com/jasongin |
|
| https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217/files/bc1091cae0196a5d2f05b73e694da16657af54e0 |
|
| https://patch-diff.githubusercontent.com/vmoroz |
|
vmoroz
| https://patch-diff.githubusercontent.com/vmoroz |
| Please reload this page | https://patch-diff.githubusercontent.com/microsoft/node-api-dotnet/pull/217 |
|
| https://patch-diff.githubusercontent.com/samardzicneo |
|
| https://patch-diff.githubusercontent.com/jasongin |
|
| https://patch-diff.githubusercontent.com/vmoroz |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |