René's URL Explorer Experiment


Title: Remove implicit hstring constructor for string_view by justanotheranonymoususer · Pull Request #1529 · microsoft/cppwinrt · GitHub

Open Graph Title: Remove implicit hstring constructor for string_view by justanotheranonymoususer · Pull Request #1529 · microsoft/cppwinrt

X Title: Remove implicit hstring constructor for string_view by justanotheranonymoususer · Pull Request #1529 · microsoft/cppwinrt

Description: Fixes #1527 In C++, string_view has no notion of a null terminator, which is assumed by create_string_reference.

Open Graph Description: Fixes #1527 In C++, string_view has no notion of a null terminator, which is assumed by create_string_reference.

X Description: Fixes #1527 In C++, string_view has no notion of a null terminator, which is assumed by create_string_reference.

Opengraph URL: https://github.com/microsoft/cppwinrt/pull/1529

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c1648e6e-15aa-1005-73eb-c7569447bad1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9332:3D45D4:D8025D:1145CB4:697542EF
html-safe-nonce5415fb030c4087126ee7616344e0d73e0566c7527ccdbe09c6c67afd5dc821ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzMyOjNENDVENDpEODAyNUQ6MTE0NUNCNDo2OTc1NDJFRiIsInZpc2l0b3JfaWQiOiIyOTE1OTEyNTMwOTE3NjcxNjYzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac05e8d346396d3194204adb0ac18ff7e940ee8fe5fb248ab24a5d0fe192cb18e3
hovercard-subject-tagpull_request:3152418989
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/cppwinrt/1529/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b07c714cff92962de5b0ae17c590916e8d7761672ad5c4cb22b99bae843abeee/microsoft/cppwinrt/pull/1529
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b07c714cff92962de5b0ae17c590916e8d7761672ad5c4cb22b99bae843abeee/microsoft/cppwinrt/pull/1529
og:image:altFixes #1527 In C++, string_view has no notion of a null terminator, which is assumed by create_string_reference.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejustanotheranonymoususer
hostnamegithub.com
expected-hostnamegithub.com
None4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f
turbo-cache-controlno-preview
go-importgithub.com/microsoft/cppwinrt git https://github.com/microsoft/cppwinrt.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id68223326
octolytics-dimension-repository_nwomicrosoft/cppwinrt
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68223326
octolytics-dimension-repository_network_root_nwomicrosoft/cppwinrt
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release488b30e96dfd057fbbe44c6665ccbc030b729dde
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1529
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1529
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fcppwinrt
Reloadhttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529
Reloadhttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529
Reloadhttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529
microsoft https://patch-diff.githubusercontent.com/microsoft
cppwinrthttps://patch-diff.githubusercontent.com/microsoft/cppwinrt
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fmicrosoft%2Fcppwinrt
Fork 266 https://patch-diff.githubusercontent.com/login?return_to=%2Fmicrosoft%2Fcppwinrt
Star 1.8k https://patch-diff.githubusercontent.com/login?return_to=%2Fmicrosoft%2Fcppwinrt
Code https://patch-diff.githubusercontent.com/microsoft/cppwinrt
Issues 3 https://patch-diff.githubusercontent.com/microsoft/cppwinrt/issues
Pull requests 2 https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pulls
Actions https://patch-diff.githubusercontent.com/microsoft/cppwinrt/actions
Models https://patch-diff.githubusercontent.com/microsoft/cppwinrt/models
Security 0 https://patch-diff.githubusercontent.com/microsoft/cppwinrt/security
Insights https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pulse
Code https://patch-diff.githubusercontent.com/microsoft/cppwinrt
Issues https://patch-diff.githubusercontent.com/microsoft/cppwinrt/issues
Pull requests https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pulls
Actions https://patch-diff.githubusercontent.com/microsoft/cppwinrt/actions
Models https://patch-diff.githubusercontent.com/microsoft/cppwinrt/models
Security https://patch-diff.githubusercontent.com/microsoft/cppwinrt/security
Insights https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fmicrosoft%2Fcppwinrt%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fmicrosoft%2Fcppwinrt%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529#issue-comment-box
justanotheranonymoususerhttps://patch-diff.githubusercontent.com/justanotheranonymoususer
microsoft:masterhttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/tree/master
justanotheranonymoususer:fix-1527https://patch-diff.githubusercontent.com/justanotheranonymoususer/cppwinrt/tree/fix-1527
Remove implicit hstring constructor for string_view https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529#top
justanotheranonymoususerhttps://patch-diff.githubusercontent.com/justanotheranonymoususer
microsoft:masterhttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/tree/master
justanotheranonymoususer:fix-1527https://patch-diff.githubusercontent.com/justanotheranonymoususer/cppwinrt/tree/fix-1527
Conversation 7 https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529
Commits 3 https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529/commits
Checks 1 https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529/checks
Files changed https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529/files
Please reload this pagehttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/justanotheranonymoususer
justanotheranonymoususerhttps://patch-diff.githubusercontent.com/justanotheranonymoususer
Jan 7, 2026https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529#issue-3788581809
#1527https://github.com/microsoft/cppwinrt/issues/1527
Please reload this pagehttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529
https://patch-diff.githubusercontent.com/justanotheranonymoususer
Remove implicit hstring constructor for string_viewhttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529/commits/7d7b8273bf41693af273e5dc253f6fa75c52e10f
7d7b827https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529/commits/7d7b8273bf41693af273e5dc253f6fa75c52e10f
microsoft#1527https://github.com/microsoft/cppwinrt/issues/1527
https://patch-diff.githubusercontent.com/sylveon
sylveonhttps://patch-diff.githubusercontent.com/sylveon
Jan 8, 2026https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529#issuecomment-3722237459
@DefaultRyanhttps://github.com/DefaultRyan
Please reload this pagehttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529
https://patch-diff.githubusercontent.com/justanotheranonymoususer
justanotheranonymoususerhttps://patch-diff.githubusercontent.com/justanotheranonymoususer
Jan 8, 2026https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529#issuecomment-3722998781
Please reload this pagehttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529
justanotheranonymoususerhttps://patch-diff.githubusercontent.com/justanotheranonymoususer
January 8, 2026 11:57https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529#commits-pushed-8dc471a
https://patch-diff.githubusercontent.com/justanotheranonymoususer
Delete ptr+size constructorhttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529/commits/8dc471a6a469202a888694fcaa113fabbeb69484
8dc471ahttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529/commits/8dc471a6a469202a888694fcaa113fabbeb69484
https://patch-diff.githubusercontent.com/justanotheranonymoususer
Try to fixhttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529/commits/af9103d8ba65c4b4c8b6d9a9330e2c8eb54201a2
af9103dhttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529/commits/af9103d8ba65c4b4c8b6d9a9330e2c8eb54201a2
https://patch-diff.githubusercontent.com/DefaultRyan
DefaultRyanhttps://patch-diff.githubusercontent.com/DefaultRyan
Jan 8, 2026 https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529#pullrequestreview-3640904388
View reviewed changes https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529/files/af9103d8ba65c4b4c8b6d9a9330e2c8eb54201a2
strings/base_string_input.hhttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529/files/af9103d8ba65c4b4c8b6d9a9330e2c8eb54201a2#diff-3ec523b81218ac44bb717f8c3fa57d614e7085560791a8529959db05bfb8b54e
DefaultRyanhttps://patch-diff.githubusercontent.com/DefaultRyan
Jan 8, 2026https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529#discussion_r2673589913
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#1123https://github.com/microsoft/cppwinrt/issues/1123
Please reload this pagehttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529
https://patch-diff.githubusercontent.com/justanotheranonymoususer
justanotheranonymoususerhttps://patch-diff.githubusercontent.com/justanotheranonymoususer
Jan 8, 2026https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529#issuecomment-3725333149
https://en.cppreference.com/w/cpp/language/attributes/deprecatedhttps://en.cppreference.com/w/cpp/language/attributes/deprecated
…https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529
#1529 (comment)https://github.com/microsoft/cppwinrt/pull/1529#discussion_r2673589913
#1123https://github.com/microsoft/cppwinrt/issues/1123
#1123https://github.com/microsoft/cppwinrt/issues/1123
#1529 (review)https://github.com/microsoft/cppwinrt/pull/1529#pullrequestreview-3640904388
https://github.com/notifications/unsubscribe-auth/ABMDRPEW3NHONMQM5QMSZM34F2U45AVCNFSM6AAAAACQ6EBF3SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMNBQHEYDIMZYHAhttps://github.com/notifications/unsubscribe-auth/ABMDRPEW3NHONMQM5QMSZM34F2U45AVCNFSM6AAAAACQ6EBF3SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMNBQHEYDIMZYHA
Please reload this pagehttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529
https://patch-diff.githubusercontent.com/YexuanXiao
YexuanXiaohttps://patch-diff.githubusercontent.com/YexuanXiao
Jan 9, 2026https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529#issuecomment-3728488315
#1244https://github.com/microsoft/cppwinrt/issues/1244
Please reload this pagehttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529
https://patch-diff.githubusercontent.com/YexuanXiao
YexuanXiaohttps://patch-diff.githubusercontent.com/YexuanXiao
Jan 9, 2026 https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529#ref-issue-3796610174
Could C++/WinRT consider adding a basic_cstring_view? #1531 https://patch-diff.githubusercontent.com/microsoft/cppwinrt/issues/1531
https://patch-diff.githubusercontent.com/apps/github-actions
github-actionshttps://patch-diff.githubusercontent.com/apps/github-actions
Jan 20, 2026https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529#issuecomment-3770547557
Please reload this pagehttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529
https://patch-diff.githubusercontent.com/apps/github-actions
github-actionshttps://patch-diff.githubusercontent.com/apps/github-actions
no-pr-activity https://patch-diff.githubusercontent.com/microsoft/cppwinrt/issues?q=state%3Aopen%20label%3Ano-pr-activity
Jan 20, 2026https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529#event-22149132378
https://patch-diff.githubusercontent.com/justanotheranonymoususer
justanotheranonymoususerhttps://patch-diff.githubusercontent.com/justanotheranonymoususer
Jan 20, 2026https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529#issuecomment-3771275184
…https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529
microsoft/cppwinrt#1529https://github.com/microsoft/cppwinrt/pull/1529
#1529 (comment)https://github.com/microsoft/cppwinrt/pull/1529#issuecomment-3770547557
#1529 (comment)https://github.com/microsoft/cppwinrt/pull/1529#issuecomment-3770547557
https://github.com/notifications/unsubscribe-auth/ABMDRPHSCZ22K6DFMWXCZAL4HVZ5TAVCNFSM6AAAAACQ6EBF3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTONZQGU2DONJVG4https://github.com/notifications/unsubscribe-auth/ABMDRPHSCZ22K6DFMWXCZAL4HVZ5TAVCNFSM6AAAAACQ6EBF3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTONZQGU2DONJVG4
Please reload this pagehttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529
https://patch-diff.githubusercontent.com/apps/github-actions
github-actionshttps://patch-diff.githubusercontent.com/apps/github-actions
no-pr-activity https://patch-diff.githubusercontent.com/microsoft/cppwinrt/issues?q=state%3Aopen%20label%3Ano-pr-activity
Jan 21, 2026https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529#event-22175562856
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1529
https://patch-diff.githubusercontent.com/DefaultRyan
DefaultRyan https://patch-diff.githubusercontent.com/DefaultRyan
https://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529/files/af9103d8ba65c4b4c8b6d9a9330e2c8eb54201a2
Bug: winrt::box_value(std::wstring_view(...)) may cause abort https://github.com/microsoft/cppwinrt/issues/1527
Please reload this pagehttps://patch-diff.githubusercontent.com/microsoft/cppwinrt/pull/1529
https://patch-diff.githubusercontent.com/justanotheranonymoususer
https://patch-diff.githubusercontent.com/sylveon
https://patch-diff.githubusercontent.com/YexuanXiao
https://patch-diff.githubusercontent.com/DefaultRyan
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.