Title: Is `VisitBaseType` internal field used consistently? · Issue #144 · microsoft/SqlScriptDOM · GitHub
Open Graph Title: Is `VisitBaseType` internal field used consistently? · Issue #144 · microsoft/SqlScriptDOM
X Title: Is `VisitBaseType` internal field used consistently? · Issue #144 · microsoft/SqlScriptDOM
Description: While diving deep into debugging my app I accidentally have noticed this: TSqlFragmentVisitor final code contains many blocks which check of VisitBaseType internal field value and if it is true then Visit method for base types is called,...
Open Graph Description: While diving deep into debugging my app I accidentally have noticed this: TSqlFragmentVisitor final code contains many blocks which check of VisitBaseType internal field value and if it is true the...
X Description: While diving deep into debugging my app I accidentally have noticed this: TSqlFragmentVisitor final code contains many blocks which check of VisitBaseType internal field value and if it is true the...
Opengraph URL: https://github.com/microsoft/SqlScriptDOM/issues/144
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Is `VisitBaseType` internal field used consistently?","articleBody":"While diving deep into debugging my app I accidentally have noticed this: TSqlFragmentVisitor final code contains many blocks which check of `VisitBaseType` internal field value and if it is `true` then Visit method for base types is called, but for some sql-fragment classes Visit method implementation has this check negated and the behavior is reversed:\n\n```csharp\n // Summary:\n // Visitor for DeclareCursorStatement\n public virtual void Visit(DeclareCursorStatement node)\n {\n if (!VisitBaseType) \u003c\u003c\u003c--- here\n {\n Visit((TSqlFragment)node);\n }\n }\n\n //\n // Summary:\n // Explicit Visitor for DeclareCursorStatement\n public virtual void ExplicitVisit(DeclareCursorStatement node)\n {\n if (VisitBaseType)\n {\n Visit((TSqlStatement)node);\n Visit((TSqlFragment)node);\n }\n\n Visit(node);\n node.AcceptChildren(this);\n }\n```\n\nIs this expected behavior? If so, please clarify what was the intent, how `VisitBaseType` should be understood.","author":{"url":"https://github.com/IVNSTN","@type":"Person","name":"IVNSTN"},"datePublished":"2025-07-03T08:29:49.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/144/SqlScriptDOM/issues/144"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f81ff9cf-a23e-c701-8b21-79223d0a384c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C2F8:18D43C:273FC1:365DA5:698F2DE4 |
| html-safe-nonce | 584bf49f997d7302ce52e376526ba3761dffa46d5bf38269cc3f06f4bb9cef09 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkY4OjE4RDQzQzoyNzNGQzE6MzY1REE1OjY5OEYyREU0IiwidmlzaXRvcl9pZCI6IjEwNjEyNjU4MDA0NzQ2MDI5ODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 65090c1b2c267fc9aabf9e2f08f626acd0dd8a2321d5bfb934ae834175c16787 |
| hovercard-subject-tag | issue:3198530115 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/SqlScriptDOM/144/issue_layout |
| twitter:image | https://opengraph.githubassets.com/bebe5086526bbcf6b825571bdcbf1acb8f51a147fac10dba4310b152f3d0c20e/microsoft/SqlScriptDOM/issues/144 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bebe5086526bbcf6b825571bdcbf1acb8f51a147fac10dba4310b152f3d0c20e/microsoft/SqlScriptDOM/issues/144 |
| og:image:alt | While diving deep into debugging my app I accidentally have noticed this: TSqlFragmentVisitor final code contains many blocks which check of VisitBaseType internal field value and if it is true the... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | IVNSTN |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6102991c714c1a6a27d05fb4f96ea6ca87a6750b4f093b95cc57ed1b84b145a1 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/SqlScriptDOM git https://github.com/microsoft/SqlScriptDOM.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 543316377 |
| octolytics-dimension-repository_nwo | microsoft/SqlScriptDOM |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 543316377 |
| octolytics-dimension-repository_network_root_nwo | microsoft/SqlScriptDOM |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e2fe82f90e107669021e243add8f74ea2a9be1b3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width