René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Consider replacing `foreach` on IList/List with `for` loop","articleBody":"When parsing thousands of scripts `foreach` approach generates at least N * 2 unnecessary enumerators, e.g. in TSQL160Parser [here](https://github.com/microsoft/SqlScriptDOM/blob/42f5cad3e7faeee7010a889ea09bea65512db84d/SqlScriptDom/Parser/TSql/TSql150Parser.cs#L89) and [here](https://github.com/microsoft/SqlScriptDOM/blob/42f5cad3e7faeee7010a889ea09bea65512db84d/SqlScriptDom/Parser/TSql/TSql150Parser.cs#L115).\n\nAlso somewhere in the deep of generated code it produces lots (~N*10) of enumerators on `IList\u003cIdentifier\u003e` but I was unable to locate this place. It'd be great if this was fixed too.\n\nAlso please take a look at this `IEnumerable` [implicit cast](https://github.com/microsoft/SqlScriptDOM/blob/42f5cad3e7faeee7010a889ea09bea65512db84d/tools/AstGen/ClassDescription.cs#L249) wherease the source is `List` and some code addressing this `IEnumerable` with `foreach` could be actually rewritten into more optimal `for`. And there is another suspicious `foreach` a couple of [lines below](https://github.com/microsoft/SqlScriptDOM/blob/42f5cad3e7faeee7010a889ea09bea65512db84d/tools/AstGen/ClassDescription.cs#L260) which may affect iterating through children objects. Perhaps it will work faster and with less garbage objects for GC if implemented as `for` loop and index-based access to `IList` elements.","author":{"url":"https://github.com/IVNSTN","@type":"Person","name":"IVNSTN"},"datePublished":"2025-06-21T13:33:23.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/138/SqlScriptDOM/issues/138"}