Title: Modernization of the library to make it usable in modern PHP applications by coogle · Pull Request #4 · mapcode-foundation/mapcode-php · GitHub
Open Graph Title: Modernization of the library to make it usable in modern PHP applications by coogle · Pull Request #4 · mapcode-foundation/mapcode-php
X Title: Modernization of the library to make it usable in modern PHP applications by coogle · Pull Request #4 · mapcode-foundation/mapcode-php
Description: Currently this SDK isn't really usable in modern PHP applications due to it's vast usage of the global namespace which has long since been retired as a best practice. Additionally, it does not have the metadata needed to be included into modern PHP projects via the PHP package manager composer. This PR fixes both issues. Essentially what I've done is a simple wrapping of all the global namespaced functions into the Mapcode namespace. I then created an object to hold all the global variables / lookup tables MapcodeData and updated all the references to $GLOBALS to use the MapcodeData::$varname equivalent`. I also cleaned up the autoloading a tad and added a composer.json which can then be registered at https://packagist.org so others can easily use the library. Along with these changes I updated the sample, unit tests (all passing), and documentation to reflect how it can be used. I updated the version to 2.3.0, although I think arguably it would make sense to call this 3.0.0. All of these changes were necessary in order to use the library in any sort of professional PHP application context, and if necessary we'll maintain this as our own fork of the original SDK -- but I'd love to see this PR merged so we won't have to do that!
Open Graph Description: Currently this SDK isn't really usable in modern PHP applications due to it's vast usage of the global namespace which has long since been retired as a best practice. Additionally, it does ...
X Description: Currently this SDK isn't really usable in modern PHP applications due to it's vast usage of the global namespace which has long since been retired as a best practice. Additionally, ...
Opengraph URL: https://github.com/mapcode-foundation/mapcode-php/pull/4
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:73f9ecdc-6c3f-7d14-a0df-198c0ff8c3a9 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | DFFC:340321:499C240:5F86DDF:697507CB |
| html-safe-nonce | 716176c62126fca2f19de2e2c08d09dbe39e14c149da88c5444cf417197ae4e7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkZDOjM0MDMyMTo0OTlDMjQwOjVGODZEREY6Njk3NTA3Q0IiLCJ2aXNpdG9yX2lkIjoiMjUyMjc1NTgxMTY2Njg4ODY1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 275d486146a9d1e55dc69a10959fd85f85dfb9a982c34c277b71fc58e29f1f5b |
| hovercard-subject-tag | pull_request:1647119793 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/mapcode-foundation/mapcode-php/pull/4/checks |
| twitter:image | https://avatars.githubusercontent.com/u/1863471?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1863471?s=400&v=4 |
| og:image:alt | Currently this SDK isn't really usable in modern PHP applications due to it's vast usage of the global namespace which has long since been retired as a best practice. Additionally, it does ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f |
| turbo-cache-control | no-preview |
| go-import | github.com/mapcode-foundation/mapcode-php git https://github.com/mapcode-foundation/mapcode-php.git |
| octolytics-dimension-user_id | 8832474 |
| octolytics-dimension-user_login | mapcode-foundation |
| octolytics-dimension-repository_id | 40119124 |
| octolytics-dimension-repository_nwo | mapcode-foundation/mapcode-php |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 40119124 |
| octolytics-dimension-repository_network_root_nwo | mapcode-foundation/mapcode-php |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 488b30e96dfd057fbbe44c6665ccbc030b729dde |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width