René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"C4244 compiler warnings: type conversions causing possible loss of data","articleBody":"As pointed out in a closed issue, compiling for electron using:\r\n node-gyp rebuild --target=3.0.6 --arch=x64 --dist-url=https://atom.io/download/electron \r\ncauses many C4244 warnings.\r\n\r\nThese seem benign, as the compiler does implicit type conversions.\r\nI nevertheless suppressed these  warnings by using casts in the code for node-stringbuilder.c\r\neg:   buffer[resultListLength++] = (uint32_t)starePointer + 1;   // approx line 73\r\n        buffer[resultListLength++] = (uint32_t)starePointer + 1;  //  approx line 133\r\n        buffer[resultListLength++] = (uint32_t)sourcePointer + 1;  // approx line 250\r\n        int64_t log2Floor(int64_t n) {return (int64_t) (floor(log2((double)n)));  // approx line 488\r\n         int64_t addedLength = (int64_t) pow((double)2, (double)(i - 1)) * contentBufferLength;  // 848\r\n          int64_t realAddedCount = (int64_t)pow((double)2, (double)log2Count);    // approx 851\r\n      int64_t addedLength = (int64_t)pow((double)2,(double)( i - 1)) * originalLength; // approx  1188\r\n      int64_t realAddedCount = (int64_t)pow((double)2, (double)log2Count);   // approx 1191\r\n\r\nBut these explicit casts are probably not necessary, and whether they'd impact on performance anyway I'm not sure. \r\n\r\n\r\n","author":{"url":"https://github.com/xthdraft","@type":"Person","name":"xthdraft"},"datePublished":"2018-11-14T01:51:51.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/3/node-stringbuilder/issues/3"}