René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Unintentional Identity file signing ","articleBody":"Hi, while troubleshooting some unrelated problems I noticed this client is generated signed key certs for any identity that we use in the in the ssh command.\r\nThe culprit seems to be this:\r\nhttps://github.com/lyft/python-blessclient/blob/master/blessclient/client.py#L171\r\n\r\ncalled here:\r\nhttps://github.com/lyft/python-blessclient/blob/master/blessclient/client.py#L448\r\n\r\nGiven an ssh config as recommended: \r\n```\r\nMatch exec \"env | grep -q BLESS_COMPLETE || /Users/stype/blessclient/blessclient.run --gui --host '%h'\"\r\n\tIdentityFile ~/.ssh/blessid\r\n```\r\n\r\nIf we are to call any other ssh command as:\r\n`ssh -i ~/.ssh/mykey user@host` \r\nand we didn't have a filter on `domain_regex:` blessclient will still generate and sign the `mykey` key.\r\n\r\nWhile I believe this could be in some case desired functionality(when doing `ssh` wrapping instead of ssh config), I think it might be better to just let it toggle via an env var or the existing `BLESS_IDENTITYFILE` as in most cases than not if you specify a particular identity on the command line, you want to use exactly that to auth and signing is unnecessary.\r\n\r\nIf this is accepted I can create a PR to cleanup/implement this.\r\n\r\n  ","author":{"url":"https://github.com/pecigonzalo","@type":"Person","name":"pecigonzalo"},"datePublished":"2018-01-09T16:58:25.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/26/python-blessclient/issues/26"}