Title: Fix: Correct handling of `import module as alias` in LPython semantic analysis by amritamishra01 · Pull Request #2872 · lcompilers/lpython · GitHub
Open Graph Title: Fix: Correct handling of `import module as alias` in LPython semantic analysis by amritamishra01 · Pull Request #2872 · lcompilers/lpython
X Title: Fix: Correct handling of `import module as alias` in LPython semantic analysis by amritamishra01 · Pull Request #2872 · lcompilers/lpython
Description: Summary This PR fixes an issue where import statements with aliases (e.g., import numpy as np) would load the module correctly but fail to register the alias (np) in the current scope. As a result, subsequent code using the alias (like np.array()) would fail with NameError: 'np' is not defined. This patch updates the semantic analysis phase to ensure import aliases are correctly created and installed into the symbol table as ExternalSymbols. Technical Changes Modified visit_Import in src/lpython/semantics/python_ast_to_asr.cpp: Refactored the logic to merge module name extraction and module loading into a single loop. Previously, these were handled in separate loops, causing the alias information (x.m_names[i].m_asname) to be lost before the symbol registration step. Implemented Alias Registration: Added logic to check for the presence of an alias. If an alias exists, the compiler now creates an ASR::ExternalSymbol_t in the current scope. This symbol maps the alias name (e.g., np) to the loaded module symbol (e.g., numpy), mirroring Python's behavior. Verification I verified the fix using the following reproduction script repro.py: import numpy as np print(np.array([1, 2, 3])) Before Fix: Compiling failed with: semantic error: NameError: 'np' is not defined After Fix: The compiler successfully resolves the alias. Running with --show-asr confirms the creation of the ExternalSymbol: np: (ExternalSymbol 2 np 1 numpy numpy [] numpy Public ) Fixes #2814
Open Graph Description: Summary This PR fixes an issue where import statements with aliases (e.g., import numpy as np) would load the module correctly but fail to register the alias (np) in the current scope. As a result,...
X Description: Summary This PR fixes an issue where import statements with aliases (e.g., import numpy as np) would load the module correctly but fail to register the alias (np) in the current scope. As a result,...
Opengraph URL: https://github.com/lcompilers/lpython/pull/2872
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bd865844-5da6-7328-9eea-d80d9a22b8ed |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E786:32E2B7:80638:B6B3D:69787F04 |
| html-safe-nonce | c1916a1dd9a48cf30dcb0fc750e29d35d94fc6ecb97e888ef177a8ea63d11508 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzg2OjMyRTJCNzo4MDYzODpCNkIzRDo2OTc4N0YwNCIsInZpc2l0b3JfaWQiOiI1MDg2MzQyNzYzMjUxMjY5MzgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e79cd8ba9da9a98ca3052996efb1431ec6505a4328c6aea359cfe93c89fb0ba0 |
| hovercard-subject-tag | pull_request:3078136980 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/lcompilers/lpython/pull/2872/files |
| twitter:image | https://avatars.githubusercontent.com/u/171616930?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/171616930?s=400&v=4 |
| og:image:alt | Summary This PR fixes an issue where import statements with aliases (e.g., import numpy as np) would load the module correctly but fail to register the alias (np) in the current scope. As a result,... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2981c597c945c1d90ac6fa355ce7929b2f413dfe7872ca5c435ee53a24a1de50 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/lcompilers/lpython git https://github.com/lcompilers/lpython.git |
| octolytics-dimension-user_id | 96538276 |
| octolytics-dimension-user_login | lcompilers |
| octolytics-dimension-repository_id | 442864346 |
| octolytics-dimension-repository_nwo | lcompilers/lpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 442864346 |
| octolytics-dimension-repository_network_root_nwo | lcompilers/lpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 520b65a872113b919c1bbdb03834a50af15859fd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width