| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:17543ba2-8848-7b12-f2ac-4c8fa9815e01 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DED8:2E3323:58258F7:77E5838:69782655 |
| html-safe-nonce | 78e2f51de51075cbe37997a45c7f20f538b45d1ba917f1ed5e53f01e9b3cba82 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUQ4OjJFMzMyMzo1ODI1OEY3Ojc3RTU4Mzg6Njk3ODI2NTUiLCJ2aXNpdG9yX2lkIjoiNzk3NjI5NzczODQyMzI0ODQ2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | eaa806fe12a0cfc1f2ddb4540480736b7a835ef724987718a1207c5eb09b63a3 |
| hovercard-subject-tag | pull_request:1753342270 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/lcompilers/lpython/pull/2571/files |
| twitter:image | https://avatars.githubusercontent.com/u/124593234?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/124593234?s=400&v=4 |
| og:image:alt | Till now, LPython's math module has sqrt() and cbrt() functions that work only for f64 types. In this PR, I have added support for i32, i64, f32 and f64 datatypes, along with an integration test. |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2981c597c945c1d90ac6fa355ce7929b2f413dfe7872ca5c435ee53a24a1de50 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/lcompilers/lpython git https://github.com/lcompilers/lpython.git |
| octolytics-dimension-user_id | 96538276 |
| octolytics-dimension-user_login | lcompilers |
| octolytics-dimension-repository_id | 442864346 |
| octolytics-dimension-repository_nwo | lcompilers/lpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 442864346 |
| octolytics-dimension-repository_network_root_nwo | lcompilers/lpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8cc3e064910e26648760f573a358cfc07c97b42c |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Flcompilers%2Flpython%2Fpull%2F2571%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Flcompilers%2Flpython%2Fpull%2F2571%2Ffiles |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=lcompilers%2Flpython |
| Reload | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
| Reload | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
| Reload | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
|
lcompilers
| https://patch-diff.githubusercontent.com/lcompilers |
| lpython | https://patch-diff.githubusercontent.com/lcompilers/lpython |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Flcompilers%2Flpython |
|
Fork
173
| https://patch-diff.githubusercontent.com/login?return_to=%2Flcompilers%2Flpython |
|
Star
1.6k
| https://patch-diff.githubusercontent.com/login?return_to=%2Flcompilers%2Flpython |
|
Code
| https://patch-diff.githubusercontent.com/lcompilers/lpython |
|
Issues
503
| https://patch-diff.githubusercontent.com/lcompilers/lpython/issues |
|
Pull requests
85
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/lcompilers/lpython/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/lcompilers/lpython/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/lcompilers/lpython/wiki |
|
Security
0
| https://patch-diff.githubusercontent.com/lcompilers/lpython/security |
|
Insights
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pulse |
|
Code
| https://patch-diff.githubusercontent.com/lcompilers/lpython |
|
Issues
| https://patch-diff.githubusercontent.com/lcompilers/lpython/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/lcompilers/lpython/actions |
|
Projects
| https://patch-diff.githubusercontent.com/lcompilers/lpython/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/lcompilers/lpython/wiki |
|
Security
| https://patch-diff.githubusercontent.com/lcompilers/lpython/security |
|
Insights
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Flcompilers%2Flpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Flcompilers%2Flpython%2Fissues%2Fnew%2Fchoose |
| Kishan-Ved | https://patch-diff.githubusercontent.com/Kishan-Ved |
| lcompilers:main | https://patch-diff.githubusercontent.com/lcompilers/lpython/tree/main |
| Kishan-Ved:sqrtcbrt | https://patch-diff.githubusercontent.com/Kishan-Ved/lpython/tree/sqrtcbrt |
|
Conversation
20
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571 |
|
Commits
4
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
| Please reload this page | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
|
Added support for i32, i64, f32 and f64's sqrt and cbrt
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#top |
|
Show all changes
4 commits
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
|
87415bf
Added Support for real and integer sqrt and cbrt
Kishan-Ved Mar 3, 2024
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/commits/87415bfef674fd8a51b0e96ea597c78fecc09571 |
|
6b11066
updated
Kishan-Ved Mar 3, 2024
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/commits/6b11066c69a447b059c6a9cf592389faf4b1f525 |
|
f5c8b3d
updated
Kishan-Ved Mar 3, 2024
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/commits/f5c8b3d51a53a4f7fd084e86d244f851a02468e2 |
|
2e34731
added integration test
Kishan-Ved Mar 3, 2024
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/commits/2e347314bd8c0aba32a27a90d935fb7e95bc0f6f |
|
Clear filters
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
| Please reload this page | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
| Please reload this page | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
|
CMakeLists.txt
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#diff-67c8fb3f4b6629c703ecb1c20661e195a435fe18141d370cd76cd2abc39021a8 |
|
test_math_04.py
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#diff-fe5217a25de97885b51975f21cd5aaaec434e4fd8d1ea7a77efc1a606c380b4e |
|
math.py
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#diff-a0a76ce2e75e1f9a54274ee8aca7dc1c2c969ae0b3b4cc788272d21fde74f27e |
| integration_tests/CMakeLists.txt | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#diff-67c8fb3f4b6629c703ecb1c20661e195a435fe18141d370cd76cd2abc39021a8 |
|
View file
| https://patch-diff.githubusercontent.com/lcompilers/lpython/blob/2e347314bd8c0aba32a27a90d935fb7e95bc0f6f/integration_tests/CMakeLists.txt |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#diff-67c8fb3f4b6629c703ecb1c20661e195a435fe18141d370cd76cd2abc39021a8 |
| ubaidsk | https://patch-diff.githubusercontent.com/ubaidsk |
| Mar 6, 2024 | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#r1515144790 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
| Kishan-Ved | https://patch-diff.githubusercontent.com/Kishan-Ved |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#r1515915125 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
| Kishan-Ved | https://patch-diff.githubusercontent.com/Kishan-Ved |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#r1515920481 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://docs.python.org/3/library/math.html | https://docs.python.org/3/library/math.html |
| Please reload this page | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
| Kishan-Ved | https://patch-diff.githubusercontent.com/Kishan-Ved |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#r1515976439 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
| ubaidsk | https://patch-diff.githubusercontent.com/ubaidsk |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#r1516176287 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
| Kishan-Ved | https://patch-diff.githubusercontent.com/Kishan-Ved |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#r1516181662 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #2556 | https://github.com/lcompilers/lpython/pull/2556 |
| Please reload this page | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
|
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#diff-67c8fb3f4b6629c703ecb1c20661e195a435fe18141d370cd76cd2abc39021a8 |
| integration_tests/test_math_04.py | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#diff-fe5217a25de97885b51975f21cd5aaaec434e4fd8d1ea7a77efc1a606c380b4e |
|
View file
| https://patch-diff.githubusercontent.com/lcompilers/lpython/blob/2e347314bd8c0aba32a27a90d935fb7e95bc0f6f/integration_tests/test_math_04.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/{{ revealButtonHref }} |
| ubaidsk | https://patch-diff.githubusercontent.com/ubaidsk |
| Mar 6, 2024 | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#r1515158689 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
| Kishan-Ved | https://patch-diff.githubusercontent.com/Kishan-Ved |
| Mar 7, 2024 | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#r1515916310 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
| src/runtime/math.py | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#diff-a0a76ce2e75e1f9a54274ee8aca7dc1c2c969ae0b3b4cc788272d21fde74f27e |
|
View file
| https://patch-diff.githubusercontent.com/lcompilers/lpython/blob/2e347314bd8c0aba32a27a90d935fb7e95bc0f6f/src/runtime/math.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#diff-a0a76ce2e75e1f9a54274ee8aca7dc1c2c969ae0b3b4cc788272d21fde74f27e |
| ubaidsk | https://patch-diff.githubusercontent.com/ubaidsk |
| Mar 6, 2024 | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#r1515150558 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @certik | https://github.com/certik |
| Please reload this page | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
| ubaidsk | https://patch-diff.githubusercontent.com/ubaidsk |
| Mar 6, 2024 | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#r1515151755 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
| Thirumalai-Shaktivel | https://patch-diff.githubusercontent.com/Thirumalai-Shaktivel |
| Mar 9, 2024 | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#r1518507874 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://gcc.gnu.org/onlinedocs/gfortran/SQRT.html | https://gcc.gnu.org/onlinedocs/gfortran/SQRT.html |
| Please reload this page | https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files |
|
| https://patch-diff.githubusercontent.com/lcompilers/lpython/pull/2571/files#diff-a0a76ce2e75e1f9a54274ee8aca7dc1c2c969ae0b3b4cc788272d21fde74f27e |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |