Title: Approvals Api does not work with replacing rules · Issue #11 · launchdarkly/api-client-python · GitHub
Open Graph Title: Approvals Api does not work with replacing rules · Issue #11 · launchdarkly/api-client-python
X Title: Approvals Api does not work with replacing rules · Issue #11 · launchdarkly/api-client-python
Description: When doing a rule replacement, the semantic patch expects the field variationId to be present. However, the internal model for Rule has a property variation. These are incompatible and the service throws an error. import launchdarkly_api...
Open Graph Description: When doing a rule replacement, the semantic patch expects the field variationId to be present. However, the internal model for Rule has a property variation. These are incompatible and the service ...
X Description: When doing a rule replacement, the semantic patch expects the field variationId to be present. However, the internal model for Rule has a property variation. These are incompatible and the service ...
Opengraph URL: https://github.com/launchdarkly/api-client-python/issues/11
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Approvals Api does not work with replacing rules","articleBody":"When doing a rule replacement, the semantic patch expects the field `variationId` to be present. However, the internal model for Rule has a property `variation`. These are incompatible and the service throws an error.\r\n\r\n```python\r\n\r\nimport launchdarkly_api\r\nfrom launchdarkly_api.api import approvals_api\r\n\r\nconfiguration = launchdarkly_api.Configuration()\r\nconfiguration.api_key[\"ApiKey\"] = API_KEY\r\napi_client = launchdarkly_api.ApiClient(configuration)\r\napprovals_client = approvals_api.ApprovalsApi(api_client)\r\n\r\nrules = [\r\n Rule(\r\n clauses=[\r\n Clause(attribute=\"service\", negate=False, op=\"in\", values=['fake-service']),\r\n ],\r\n variation=0,\r\n track_events=False,\r\n )\r\n]\r\n\r\napproval_request = CreateFlagConfigApprovalRequestRequest(\r\n comment=\"comment\",\r\n description=\"description\",\r\n instructions=Instructions([\r\n Instruction(\r\n kind=\"replaceRules\",\r\n rules=rules\r\n ),\r\n ]),\r\n notify_member_ids=['my_id_number']\r\n)\r\n\r\napprovals_client.post_approval_request('project', 'TEST_FLAG', 'test', approval_request)\r\n```\r\n\r\n```\r\n{\"code\":\"invalid_request\",\"message\":\"rule index 0: instruction variationId or rolloutWeights must be specified\"}\r\n```\r\n\r\nAs you can see from the [model for Rule,](https://github.com/launchdarkly/api-client-python/blob/8.0.0/docs/Rule.md) the attribute is called `variation`, not `variationId`.\r\nI can try to use a raw dictionary that conforms to the semantic patch pattern, but then I get a different error:\r\n```python\r\nconfiguration = launchdarkly_api.Configuration()\r\nconfiguration.api_key[\"ApiKey\"] = API_KEY\r\napi_client = launchdarkly_api.ApiClient(configuration)\r\napprovals_client = approvals_api.ApprovalsApi(api_client)\r\n\r\nrules = [\r\n Rule(\r\n clauses=[\r\n Clause(attribute=\"service\", negate=False, op=\"in\", values=['fake-service']),\r\n ],\r\n variation=0,\r\n track_events=False,\r\n )\r\n]\r\n\r\napproval_request = CreateFlagConfigApprovalRequestRequest(\r\n comment=\"comment\",\r\n description=\"description\",\r\n instructions=Instructions([\r\n Instruction(\r\n kind=\"replaceRules\",\r\n rules=[\r\n {\r\n \"variationId\": 1,\r\n \"clauses\": [\r\n {\r\n \"attribute\": \"service\",\r\n \"op\": \"in\",\r\n \"negate\": False,\r\n \"values\": [\"fake-service\"]\r\n }\r\n ],\r\n }\r\n ]\r\n ),\r\n ]),\r\n notify_member_ids=['my-member-id']\r\n)\r\n\r\napprovals_client.post_approval_request('project', 'TEST_FLAG', 'test', approval_request)\r\n```\r\n```\r\nAttributeError: 'dict' object has no attribute '_composed_schemas'\r\n```","author":{"url":"https://github.com/chrisdurand-RL","@type":"Person","name":"chrisdurand-RL"},"datePublished":"2022-05-12T01:07:37.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":7},"url":"https://github.com/11/api-client-python/issues/11"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:dc1d527a-c733-f08f-7fd5-389cf0bf6c1a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C9C6:66C53:F3B230:13D079B:699209E0 |
| html-safe-nonce | af8820051d3d1363d62aba4971903658bf508442c0726cd86f5f9a7282508ca4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUM2OjY2QzUzOkYzQjIzMDoxM0QwNzlCOjY5OTIwOUUwIiwidmlzaXRvcl9pZCI6IjQ1MDY5NTc2NjUyNjI2NTgyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 44a0d7b8798f4f2fbef1e129d1d568867d950940f882e49fd24658b01c836bec |
| hovercard-subject-tag | issue:1233321887 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/launchdarkly/api-client-python/11/issue_layout |
| twitter:image | https://opengraph.githubassets.com/a0ceaf05e2dfe551ec13b96e319d3c06d9139f8d06acadf878f90a60c617e865/launchdarkly/api-client-python/issues/11 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a0ceaf05e2dfe551ec13b96e319d3c06d9139f8d06acadf878f90a60c617e865/launchdarkly/api-client-python/issues/11 |
| og:image:alt | When doing a rule replacement, the semantic patch expects the field variationId to be present. However, the internal model for Rule has a property variation. These are incompatible and the service ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | chrisdurand-RL |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| go-import | github.com/launchdarkly/api-client-python git https://github.com/launchdarkly/api-client-python.git |
| octolytics-dimension-user_id | 8039656 |
| octolytics-dimension-user_login | launchdarkly |
| octolytics-dimension-repository_id | 102905895 |
| octolytics-dimension-repository_nwo | launchdarkly/api-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 102905895 |
| octolytics-dimension-repository_network_root_nwo | launchdarkly/api-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width