Title: JsonDiff bug found · Issue #163 · java-json-tools/json-patch · GitHub
Open Graph Title: JsonDiff bug found · Issue #163 · java-json-tools/json-patch
X Title: JsonDiff bug found · Issue #163 · java-json-tools/json-patch
Description: Consider the following Jsons: Source: { "store": { "a": [ "v1", "v2" ] } } Target: { "store": { "a": [] } } running JsonDiff.asJson(source, target) returns: [ { "op" : "remove", "path" : "/store/a/0" }, { "op" : "remove", "path" : "/stor...
Open Graph Description: Consider the following Jsons: Source: { "store": { "a": [ "v1", "v2" ] } } Target: { "store": { "a": [] } } running JsonDiff.asJson(source, target) returns: [ { "op" : "remove", "path" : "/store/a/...
X Description: Consider the following Jsons: Source: { "store": { "a": [ "v1", "v2" ] } } Target: { "store": { "a": [] } } running JsonDiff.asJson(sourc...
Opengraph URL: https://github.com/java-json-tools/json-patch/issues/163
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"JsonDiff bug found","articleBody":"Consider the following Jsons:\r\n\r\n**Source:**\r\n```\r\n{\r\n \"store\": {\r\n \"a\": [\r\n \"v1\",\r\n \"v2\"\r\n ]\r\n }\r\n}\r\n```\r\n\r\n**Target:**\r\n```\r\n{\r\n \"store\": {\r\n \"a\": []\r\n }\r\n}\r\n```\r\n\r\nrunning `JsonDiff.asJson(source, target)` returns:\r\n\r\n```\r\n[ {\r\n \"op\" : \"remove\",\r\n \"path\" : \"/store/a/0\"\r\n}, {\r\n \"op\" : \"remove\",\r\n \"path\" : \"/store/a/0\"\r\n} ]\r\n```\r\n\r\nwhich as it is seen both path is same but actually the next path should be `\"/store/a/1\"`. The reason is there is a bug in **JsonDiff** class in function **generateArrayDiffs**. There is a for loop as:\r\n\r\n```\r\nfor(index = size; index \u003c firstSize; ++index) {\r\n processor.valueRemoved(pointer.append(size), source.get(index));\r\n}\r\n```\r\n\r\nWhich should be changed to:\r\n\r\n```\r\nfor(index = size; index \u003c firstSize; ++index) {\r\n processor.valueRemoved(pointer.append(index), source.get(index));\r\n}\r\n```","author":{"url":"https://github.com/fmoghaddam","@type":"Person","name":"fmoghaddam"},"datePublished":"2024-10-01T10:47:21.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/163/json-patch/issues/163"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:2dd70cfa-930a-9996-49e5-b1a92163216a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E6B8:300F19:69425F7:87C9155:69761547 |
| html-safe-nonce | 257ec286b7099ec287e0ce50b94659929cb15c69cf432ad13764873a70a780a6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkI4OjMwMEYxOTo2OTQyNUY3Ojg3QzkxNTU6Njk3NjE1NDciLCJ2aXNpdG9yX2lkIjoiMzEzODM0MDQwODkxMjEyMzIwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 816b592ba0c9ffe4f447242db2fe1e9393d95b743c7ad9f8b97453d2e63f6e19 |
| hovercard-subject-tag | issue:2558860662 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/java-json-tools/json-patch/163/issue_layout |
| twitter:image | https://opengraph.githubassets.com/2a0370e1b29ae943125516449cab79e7d128ce3cceb50a7bb19627ff5830a131/java-json-tools/json-patch/issues/163 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2a0370e1b29ae943125516449cab79e7d128ce3cceb50a7bb19627ff5830a131/java-json-tools/json-patch/issues/163 |
| og:image:alt | Consider the following Jsons: Source: { "store": { "a": [ "v1", "v2" ] } } Target: { "store": { "a": [] } } running JsonDiff.asJson(source, target) returns: [ { "op" : "remove", "path" : "/store/a/... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | fmoghaddam |
| hostname | github.com |
| expected-hostname | github.com |
| None | c6814b4cc7afd45cd6e64525d0cff0e76dd802f315a5b0e55a7abda1d1d070d0 |
| turbo-cache-control | no-preview |
| go-import | github.com/java-json-tools/json-patch git https://github.com/java-json-tools/json-patch.git |
| octolytics-dimension-user_id | 28316821 |
| octolytics-dimension-user_login | java-json-tools |
| octolytics-dimension-repository_id | 8911984 |
| octolytics-dimension-repository_nwo | java-json-tools/json-patch |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 8911984 |
| octolytics-dimension-repository_network_root_nwo | java-json-tools/json-patch |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4ea235bfed58ef16c8a5642b3ac64b74f10c9f52 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width